feed: ability to close reply form #23

Merged
offbyn merged 1 commits from feed-close-reply-form into master 2 years ago
offbyn commented 2 years ago
Owner

This is an approach to close the reply-to-form automatically when
focus is lost and only if the input is empty. A second way to close the reply-to-form is provided by toggling the reply icon.

Fixes #16

This is an approach to close the reply-to-form automatically when focus is lost and only if the input is empty. A second way to close the reply-to-form is provided by toggling the reply icon. Fixes https://git.qcode.ch/nostr/nostrweb/issues/16
offbyn self-assigned this 2 years ago
offbyn added 1 commit 2 years ago
ci/woodpecker/pr/woodpecker Pipeline was successful Details
ci/woodpecker/push/woodpecker Pipeline was successful Details
11fbc7aa7d
feed: ability to close reply form
This is an approach to close the reply-to-form automatically when
focus is lost and only if the input is empty. A second way to close
the reply-to-form is provided by toggling the reply icon.
offbyn requested review from x1ddos 2 years ago
x1ddos approved these changes 2 years ago
x1ddos left a comment
Owner

🎉

🎉
@ -430,0 +437,4 @@
const reply_to = localStorage.getItem('reply_to');
if (reply_to && writeInput.value === '') {
writeInput.addEventListener('transitionend', (event) => {
if (!reply_to || reply_to === localStorage.getItem('reply_to') && !writeInput.style.height) { // should prob use some class or data-attr instead of relying on height
x1ddos commented 2 years ago
Owner

the trick with css heigh is nice but +1 to using a class or an attr in the future. good as is for now imho.

the trick with css heigh is nice but +1 to using a class or an attr in the future. good as is for now imho.
offbyn merged commit 11fbc7aa7d into master 2 years ago
offbyn deleted branch feed-close-reply-form 2 years ago

Reviewers

x1ddos approved these changes 2 years ago
ci/woodpecker/pr/woodpecker Pipeline was successful
ci/woodpecker/push/woodpecker Pipeline was successful
The pull request has been merged as 11fbc7aa7d.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b feed-close-reply-form master
git pull origin feed-close-reply-form

Step 2:

Merge the changes and update on Gitea.
git checkout master
git merge --no-ff feed-close-reply-form
git push origin master
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: nostr/nostrweb#23
Loading…
There is no content yet.