the reply input never disappears #16

Closed
opened 2 years ago by x1ddos · 10 comments
x1ddos commented 2 years ago
Owner

i clicked on the reply icon, changed my mind and clicked away but the reply input didn't disappear even after reload:

image

i'd expect it to go away after clicking elsewhere.

i clicked on the reply icon, changed my mind and clicked away but the reply input didn't disappear even after reload: ![image](/attachments/613f6c98-ee7d-4ae6-9cf2-b3c107a8c384) i'd expect it to go away after clicking elsewhere.
offbyn was assigned by x1ddos 2 years ago
offbyn commented 2 years ago
Owner

yeah there is currently no way to remove it, would you expect that it hides when the replyto form looses focus?

alternative: the star icon could toggle visibility of the the input field.

yeah there is currently no way to remove it, would you expect that it hides when the replyto form looses focus? alternative: the star icon could toggle visibility of the the input field.
offbyn commented 2 years ago
Owner

Actually that it remembers the event that the user was replying to is a feature :)
is that annoying?

btw does the text in the input field stay when you reload?

Actually that it remembers the event that the user was replying to is a feature :) is that annoying? btw does the text in the input field stay when you reload?
x1ddos commented 2 years ago
Poster
Owner

maybe add a X cross to close manually? wouldn't dare to touch the star icon, that's a different thing, isn't it.

maybe add a `X` cross to close manually? wouldn't dare to touch the star icon, that's a different thing, isn't it.
x1ddos commented 2 years ago
Poster
Owner

Actually that it remembers the event that the user was replying to is a feature :)
is that annoying?

yeah, that's pretty cool but i'd like to be able to close it one way or another if i changed my mind and don't want to reply anymore :)

btw does the text in the input field stay when you reload?

yes! it is pretty amazing, i like it as a feature.

> Actually that it remembers the event that the user was replying to is a feature :) is that annoying? yeah, that's pretty cool but i'd like to be able to close it one way or another if i changed my mind and don't want to reply anymore :) > btw does the text in the input field stay when you reload? yes! it is pretty amazing, i like it as a feature.
x1ddos commented 2 years ago
Poster
Owner

would you expect that it hides when the replyto form looses focus?

probably not on focus lost - i could accidentally click/tap away. maybe the X would be ideal.

> would you expect that it hides when the replyto form looses focus? probably not on focus lost - i could accidentally click/tap away. maybe the `X` would be ideal.
offbyn commented 2 years ago
Owner

i like it as a feature.

The code only injects the input field, but that the text is remembered is a browser feature, there is no code that rembers the text itself.

> i like it as a feature. The code only injects the input field, but that the text is remembered is a browser feature, there is no code that rembers the text itself.
x1ddos commented 2 years ago
Poster
Owner

i like it as a feature.

The code only injects the input field, but that the text is remembered is a browser feature, there is no code that rembers the text itself.

hehe. i guess you've got a free feature, at least on firefox.

> > i like it as a feature. > > The code only injects the input field, but that the text is remembered is a browser feature, there is no code that rembers the text itself. hehe. i guess you've got a free feature, at least on firefox.
offbyn commented 2 years ago
Owner

probably not on focus lost

I agree, however I wanted to try an approach that only closes on focus if the text field is empty also toggling the reply icon closes it.

please have a look #23

> probably not on focus lost I agree, however I wanted to try an approach that only closes on focus if the text field is empty also toggling the reply icon closes it. please have a look https://git.qcode.ch/nostr/nostrweb/pulls/23
x1ddos commented 2 years ago
Poster
Owner

hm.. didn't auto-close #23 🤔

hm.. didn't auto-close https://git.qcode.ch/nostr/nostrweb/pulls/23 🤔
x1ddos closed this issue 2 years ago
x1ddos added this to the mvp project 2 years ago
offbyn commented 2 years ago
Owner

hm.. didn't auto-close #23 🤔

next time I try "closes" instead of fixes, see https://github.com/go-gitea/gitea/pull/8866

> hm.. didn't auto-close #23 🤔 next time I try "closes" instead of fixes, see https://github.com/go-gitea/gitea/pull/8866
x1ddos added the
bug
label 2 years ago
x1ddos added this to the mvp milestone 2 years ago
Sign in to join this conversation.
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: nostr/nostrweb#16
Loading…
There is no content yet.