nostr
/
nostrweb
3
1
Fork 1
Code Issues 24 Pull Requests 3 Projects 1 Releases 27 Activity

Labels Milestones

subscribe-with-prefix #75

Merged
offbyn merged 1 commits from subscribe-with-prefix into master 10 months ago
Conversation 1 Commits 1 Files Changed 4
offbyn commented 10 months ago
Owner

fixes #69

fixes #69
offbyn added 2 commits 10 months ago
ci/woodpecker/push/woodpecker Pipeline was successful Details
ci/woodpecker/pr/woodpecker Pipeline was successful Details
cce0bd9115
feed: subscribe to pow events 
if difficulty-filter is set the subscription of the global feed
can filter only ids with 0-prefix to save bandwidth.

as there may not be many pow events within the last 24h, the
date range is now only enabled if there is no diffculty-filter
set so that the feed is not empty.

if this works as expected it could also only subscripe to
reactions and profile info with pow ids.
offbyn force-pushed subscribe-with-prefix from cce0bd9115 to b4bb503bdd 10 months ago
offbyn requested review from x1ddos 10 months ago
x1ddos reviewed 10 months ago
x1ddos left a comment
Owner

if this works as expected it could also only subscripe to reactions and profile info with pow ids.

do it now in this PR? so it's all in a single change.

also, don't you want to apply the same filter for future events? here:

// subscribe to future notes, reactions and profile updates
sub({ ...
> if this works as expected it could also only subscripe to reactions and profile info with pow ids. do it now in this PR? so it's all in a single change. also, don't you want to apply the same filter for future events? here: ```js // subscribe to future notes, reactions and profile updates sub({ ... ```
src/subscriptions.ts Outdated
@ -13,6 +14,7 @@ export const sub24hFeed = (onEvent: SubCallback) => {
const now = Math.floor(Date.now() * 0.001);
const pubkeys = new Set<string>();
const notes = new Set<string>();
const prefix = Math.floor(config.filterDifficulty * 0.25);
x1ddos commented 10 months ago
Owner

consider using division instead of multiplying. i find this easier to understand:

const prefix = Math.floor(config.filterDifficulty / 4);

because there are 4 bits in each '0' character.

consider using division instead of multiplying. i find this easier to understand: ```js const prefix = Math.floor(config.filterDifficulty / 4); ``` because there are 4 bits in each `'0'` character.
👍 1
offbyn commented 10 months ago
Poster
Owner

makes sense

makes sense
x1ddos commented 10 months ago
Owner

fixes #75

#75 is this PR :)
maybe you meant #69?

> fixes #75 #75 is this PR :) maybe you meant https://git.qcode.ch/nostr/nostrweb/issues/69?
👍 1
offbyn force-pushed subscribe-with-prefix from b4bb503bdd to e83e083e3d 10 months ago
offbyn force-pushed subscribe-with-prefix from e83e083e3d to 5734736458 10 months ago
offbyn force-pushed subscribe-with-prefix from 5734736458 to 4a8025cfe9 10 months ago
offbyn force-pushed subscribe-with-prefix from 4a8025cfe9 to 5e61dcef0c 10 months ago
offbyn merged commit 5e61dcef0c into master 10 months ago
offbyn deleted branch subscribe-with-prefix 10 months ago
x1ddos approved these changes 10 months ago

Reviewers

x1ddos approved these changes 10 months ago
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
ci/woodpecker/push/woodpecker Pipeline was successful
Details
The pull request has been merged as 5e61dcef0c.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b subscribe-with-prefix master
git pull origin subscribe-with-prefix

Step 2:

Merge the changes and update on Gitea.
git checkout master
git merge --no-ff subscribe-with-prefix
git push origin master
Sign in to join this conversation.
Reviewers
Request review
No reviewers
x1ddos
Labels
Apply labels
Clear labels
  
bug
   
duplicate
   
feature
   
halp!
   
invalid
   
wontfix
No Label
bug
duplicate
feature
halp!
invalid
wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Set Project
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: nostr/nostrweb#75
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'subscribe-with-prefix'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes