profile: update profile images #42

Textnotes often miss profile pictures of authors because they
are rendered when received even without knowing the pic yet.

Update profile pic of already rendered textnotes with the picture
of the first kind 0 event that has a valid picture, should now
render missing profile pics.

Textnotes often miss profile pictures of authors because they are rendered when received even without knowing the pic yet. Update profile pic of already rendered textnotes with the picture of the first kind 0 event that has a valid picture, should now render missing profile pics.

lgtm

sometime in the future, consider using a hashmap (object?) in getMetadata. instead of this:

const user = userList.find(user => user.pubkey === evt.pubkey);

do something like this:

const user = userMap[evt.pubkey];

it's a linear search O(N) vs theoretically O(1) object value lookup by key: http://jsben.ch/Y9jDP

as the userlist grows it'll be slower and slower.

then, could it make sense to store userMap in localStorage or indexeddb? so on next page reload you already have all previously seen metadata.

sometime in the future, consider using a hashmap (object?) in `getMetadata`. instead of this: ```js const user = userList.find(user => user.pubkey === evt.pubkey); ``` do something like this: ```js const user = userMap[evt.pubkey]; ``` it's a linear search O(N) vs theoretically O(1) object value lookup by key: http://jsben.ch/Y9jDP as the userlist grows it'll be slower and slower. --- then, could it make sense to store `userMap` in localStorage or indexeddb? so on next page reload you already have all previously seen metadata.

then, could it make sense to store userMap in localStorage or indexeddb? so on next page reload you already have all previously seen metadata.

userMap object should be fasted, but I am not sure how many contacts a client should keep.

Object in localStorage need to be stringified. so can't query from localStorage diretly, (unless each user would have it's own localstorage key, but that feels messy/wrong).

I wanted to use indexdb anyway for received events. but not sure yet.

maybe one advantage of userList array could be that it is sorted on access and could forget oldest accessed users after 1000 or so newer users.

> then, could it make sense to store userMap in localStorage or indexeddb? so on next page reload you already have all previously seen metadata. userMap object should be fasted, but I am not sure how many contacts a client should keep. Object in localStorage need to be stringified. so can't query from localStorage diretly, (unless each user would have it's own localstorage key, but that feels messy/wrong). I wanted to use indexdb anyway for received events. but not sure yet. maybe one advantage of userList array could be that it is sorted on access and could forget oldest accessed users after 1000 or so newer users.

superseded by #45

superseded by https://git.qcode.ch/nostr/nostrweb/pulls/45

Labels Milestones

profile: update profile images #42

Reviewers

Step 1:

Step 2: