Labels Milestones

keys: fix key validation #18

Merged

offbyn merged 1 commits from fix-key-validation into master 2 years ago

Conversation 2 Commits 1 Files Changed 1

offbyn commented 2 years ago

Owner

Pub and private key settings only showed errors if both values were
truthy, but it did not validate if one input was falsy, in which
case it only showed the last error.

Removed truthy check as it is not needed.

Part of #14

Pub and private key settings only showed errors if both values were truthy, but it did not validate if one input was falsy, in which case it only showed the last error. Removed truthy check as it is not needed. Part of https://git.qcode.ch/nostr/nostrweb/issues/14

x1ddos was assigned by offbyn 2 years ago

offbyn added 1 commit 2 years ago

35b570b05f

keys: fix key validation ...

Pub and private key settings only showed errors if both values were
truthy, but it did not validate if one input was falsy, in which
case it only showed the last error.

Removed truthy check as it is not needed.

offbyn requested review from x1ddos 2 years ago

x1ddos was unassigned by offbyn 2 years ago

x1ddos commented 2 years ago

Owner

lgtm!

lgtm!

x1ddos approved these changes 2 years ago

x1ddos left a comment

Owner

ah, here's where i should put lgtm :)

ah, here's where i should put lgtm :)

offbyn force-pushed fix-key-validation from 35b570b05f to 6a4266526d 2 years ago

offbyn commented 2 years ago

Poster

Owner

rebased

rebased

offbyn merged commit 6a4266526d into master 2 years ago

offbyn deleted branch fix-key-validation 2 years ago

Reviewers

x1ddos approved these changes 2 years ago

ci/woodpecker/pr/woodpecker Pipeline was successful

Details

ci/woodpecker/push/woodpecker Pipeline was successful

Details

The pull request has been merged as 6a4266526d.

You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.

git checkout -b fix-key-validation master

git pull origin fix-key-validation

Step 2:

Merge the changes and update on Gitea.

git checkout master

git merge --no-ff fix-key-validation

git push origin master

Sign in to join this conversation.

Reviewers

Request review

No reviewers

x1ddos

Labels

Apply labels

Clear labels

  

bug

  

duplicate

  

feature

  

halp!

  

invalid

  

wontfix

No Label

bug

duplicate

feature

halp!

invalid

wontfix

Milestone

Set milestone

Clear milestone

No items

No Milestone

Projects

Set Project

Clear projects

No project

Assignees

Assign users

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: nostr/nostrweb#18

Write Preview

Loading…

Cancel

Save

There is no content yet.