nostr
/
nostrweb
3
1
Fork 1
Code Issues 24 Pull Requests 3 Projects 1 Releases 27 Activity

Labels Milestones

keys: fix key validation #18

Merged
offbyn merged 1 commits from fix-key-validation into master
Conversation 2 Commits 1 Files Changed 1
offbyn commented
Owner

Pub and private key settings only showed errors if both values were
truthy, but it did not validate if one input was falsy, in which
case it only showed the last error.

Removed truthy check as it is not needed.

Part of

Pub and private key settings only showed errors if both values were truthy, but it did not validate if one input was falsy, in which case it only showed the last error. Removed truthy check as it is not needed. Part of https://git.qcode.ch/nostr/nostrweb/issues/14
x1ddos was assigned by offbyn
offbyn added 1 commit
35b570b05f
keys: fix key validation 
Pub and private key settings only showed errors if both values were
truthy, but it did not validate if one input was falsy, in which
case it only showed the last error.

Removed truthy check as it is not needed.
offbyn requested review from x1ddos
x1ddos was unassigned by offbyn
x1ddos commented
Owner

lgtm!

lgtm!
x1ddos approved these changes
x1ddos left a comment
Owner

ah, here's where i should put lgtm :)

ah, here's where i should put lgtm :)
offbyn force-pushed fix-key-validation from 35b570b05f to 6a4266526d
offbyn commented
Poster
Owner

rebased

rebased
offbyn merged commit 6a4266526d into master 2 years ago
offbyn deleted branch fix-key-validation

Reviewers

x1ddos approved these changes
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
ci/woodpecker/push/woodpecker Pipeline was successful
Details
The pull request has been merged as 6a4266526d.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b fix-key-validation master
git pull origin fix-key-validation

Step 2:

Merge the changes and update on Gitea.
git checkout master
git merge --no-ff fix-key-validation
git push origin master
Sign in to join this conversation.
No reviewers
x1ddos
No Label
bug
duplicate
feature
halp!
invalid
wontfix
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: nostr/nostrweb#18
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'fix-key-validation'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes