keys: fix key validation
ci/woodpecker/push/woodpecker Pipeline was successful Details
ci/woodpecker/pr/woodpecker Pipeline was successful Details

Pub and private key settings only showed errors if both values were
truthy, but it did not validate if one input was falsy, in which
case it only showed the last error.

Removed truthy check as it is not needed.
OFF0 2 years ago
parent a7a2acfc0c
commit 35b570b05f
Signed by: offbyn
GPG Key ID: 94A2F643C51F37FA

@ -541,7 +541,6 @@ importBtn.addEventListener('click', () => {
settingsForm.addEventListener('input', () => validKeys(privateKeyInput.value, pubKeyInput.value)); settingsForm.addEventListener('input', () => validKeys(privateKeyInput.value, pubKeyInput.value));
function validKeys(privatekey, pubkey) { function validKeys(privatekey, pubkey) {
if (pubkey && privatekey) {
try { try {
if (getPublicKey(privatekey) === pubkey) { if (getPublicKey(privatekey) === pubkey) {
statusMessage.hidden = true; statusMessage.hidden = true;
@ -554,7 +553,6 @@ function validKeys(privatekey, pubkey) {
} catch (e) { } catch (e) {
statusMessage.textContent = `not a valid private-key: ${e.message || e}`; statusMessage.textContent = `not a valid private-key: ${e.message || e}`;
} }
}
statusMessage.hidden = false; statusMessage.hidden = false;
importBtn.setAttribute('disabled', true); importBtn.setAttribute('disabled', true);
return false; return false;

Loading…
Cancel
Save