9166 Commits (ba0a0bc9c268fd49c0e584785dbb80b8c9376cee)

Author SHA1 Message Date
yflory 28b0371937 Merge branch 'ooapps' into exportSheet 3 years ago
yflory 2718eab7c4 Merge branch 'exportForm' into exportSheet 3 years ago
yflory 07b31dc84d Merge branch 'testtheme' into exportSheet 3 years ago
yflory 0718e0fc1b Fix OpenDocument and PDF export in new OO apps 3 years ago
yflory db5d2cbfc8 Support OO bin format in the convert app 3 years ago
yflory 0642eeb2a7 Add missing versions 3 years ago
yflory 55890011a4 Merge branch 'exportForm' of github.com:xwiki-labs/cryptpad into exportForm 3 years ago
yflory bef8f131d9 Fix forms results with conditional sections 3 years ago
yflory fab629bf6d Merge branch 'staging' of github.com:xwiki-labs/cryptpad into staging 3 years ago
yflory 04e298dd46 Fix forms results with conditional sections (#799) 3 years ago
ansuz ce8f108437 apply our usual button styles to the calendar export dropdown 3 years ago
ansuz baf9ab0c93 Merge branch 'staging' into dapsi-demo-update 3 years ago
ansuz 7ae5654b83 guard against type errors in contextual chat while in no-drive mode 3 years ago
ansuz 3e9b00077b allow ods and odp export directly from OnlyOffice 3 years ago
ansuz a9e9ee6c7a guard against typeError when importing sheets 3 years ago
David Benque f092575104 Adjust "export to spreadsheet" forms UI 3 years ago
yflory aaed6b7d77 Apply form results to new sheet 3 years ago
yflory 3f1480a847 Merge branch 'exportSheet' into exportForm 3 years ago
yflory 86aad06545 Export form in sheets 3 years ago
yflory ca95af082d Fix scrambled data in sheets on reconnect 3 years ago
yflory 4c915f9e5a Don't show the upload button until we're ready to draw files in the file picker 3 years ago
yflory 0881936971 OnlyOffice slides improvements 3 years ago
ansuz eb3cdf2f78 Merge tag '4.11.0' into dapsi-demo-update 3 years ago
ansuz d9d3cdf092 minor UX fixes for demo purposes 3 years ago
yflory df440b19df Smaller theme patches in OO slides 3 years ago
yflory 21d6057c1f New OO build for smaller theme patch 3 years ago
ansuz 55537bc6cb Merge branch 'main' into soon 3 years ago
Weblate 5414fe14de Translated using Weblate (Spanish)
Currently translated at 47.4% (675 of 1424 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/es/

Translated using Weblate (Spanish)

Currently translated at 46.0% (656 of 1424 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/es/

Translated using Weblate (Spanish)

Currently translated at 46.0% (656 of 1424 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/es/
3 years ago
yflory b896870632 New OO checkpoints 3 years ago
ansuz 8390c5b244 disable autocomplete for upload alt text 3 years ago
yflory dde1b7ecad Test ooslide theme 3 years ago
Weblate 95d600e3c6 Translated using Weblate (Japanese)
Currently translated at 99.3% (1415 of 1424 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/ja/
3 years ago
Weblate 624c9344cc Translated using Weblate (Japanese)
Currently translated at 99.2% (1413 of 1424 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/ja/
3 years ago
ansuz 4b91f01b78 Merge branch 'staging' into soon 3 years ago
Weblate ce8344aa45 Translated using Weblate (Japanese)
Currently translated at 99.1% (1412 of 1424 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/ja/
3 years ago
Weblate 0699e21a51 Translated using Weblate (German)
Currently translated at 100.0% (1424 of 1424 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/de/
3 years ago
yflory eee79e5553 Fix UI issues in forms when disconnected 3 years ago
yflory 8d46e8b5bd Remove debugging logs 3 years ago
yflory 022be6d1e0 Merge branch 'staging' of github.com:xwiki-labs/cryptpad into staging 3 years ago
Weblate 62b111df5a Translated using Weblate (German)
Currently translated at 98.0% (1396 of 1424 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/de/
3 years ago
Weblate aa30ec2b03 Translated using Weblate (French)
Currently translated at 100.0% (1424 of 1424 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/fr/
3 years ago
yflory 90631569cd lint compliance 3 years ago
yflory c30962d5bd Add missing color 3 years ago
yflory 463cb3252c Remove hardcoded text 3 years ago
yflory 704c50fae3 Fix colors in forms 3 years ago
yflory 527bcda1b0 Forms colortheme 3 years ago
ansuz 8101276b51 finally stop polyfilling promises in 2021 3 years ago
yflory 6e332c2f8d Merge branch 'staging' into formColor 3 years ago
ansuz 344f87884c Merge branch 'soon' into staging 3 years ago
Weblate c072a39932 Translated using Weblate (Spanish)
Currently translated at 44.3% (632 of 1424 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/es/
3 years ago
ansuz ae7e5e0636 remove more XXX notes, add stricter team invite link content validation 3 years ago
David Benqué 897b0bb5b6 Use the same color for timeline and bar charts on Form response page 3 years ago
David Benqué b55e3cac52 Fix wrong "Preview" key being used in Form editor 3 years ago
ansuz 38370328dd lint compliance 3 years ago
ansuz 10433aab35 Merge branch 'soon' into staging 3 years ago
ansuz 1a1213d45e remove old notes 3 years ago
ansuz f2f6136208 add 'invalid' styles to link creation modal 3 years ago
David Benqué f2153614ac Fix clickable area of logo on participant view 3 years ago
ansuz c89f4f555b more hardcoded translations 3 years ago
Weblate c6dc3fbc03 Translated using Weblate (English)
Currently translated at 100.0% (1424 of 1424 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/
3 years ago
Weblate e8502cee0c Translated using Weblate (French)
Currently translated at 100.0% (1424 of 1424 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/fr/
3 years ago
ansuz 3738ae9b99 remove hardcoded translations and invalid XXX notes 3 years ago
yflory 01c96d668f Merge branch 'merge2' of github.com:xwiki-labs/cryptpad into merge2 3 years ago
yflory e9de9bc9aa Add icons in the share modal 3 years ago
David Benqué a61c831748 Fix margin at the bottom of Required alert 3 years ago
David Benqué f566692441 Merge remote-tracking branch 'origin/merge2' into merge2 3 years ago
David Benqué 3722d260d0 Hide background for grid sub-questions responses 3 years ago
yflory ff70abae11 Improve UI 3 years ago
yflory 77d3f037cd Add title to response page 3 years ago
yflory 7472f8cc0e Remove translation XXX 3 years ago
yflory 39049b71c2 Fix condition dropdown when the selected question is modified 3 years ago
yflory 0af9047b64 Fix conditional sections 3 years ago
yflory 602c2f2616 Update responses style 3 years ago
yflory b897584729 Merge branch 'forms2' into merge2 3 years ago
yflory 07a669fed0 Merge branch 'forms2' of github.com:xwiki-labs/cryptpad into forms2 3 years ago
yflory 1fa916d88c Merge branch 'staging' into merge2 3 years ago
yflory c141b77efc Fix report app 3 years ago
David Benqué 62c59d68de Merge remote-tracking branch 'origin/forms2' into forms2 3 years ago
David Benqué 4072b0451e Fix condition button margin for small screens 3 years ago
yflory 899d0b7d13 Forms V2 3 years ago
yflory 0d4a834d42 Fix response page 3 years ago
David Benqué f2a1577eca Edit list of emoji for Guest avatars 3 years ago
ansuz f657a09137 Merge branch 'soon' into staging 3 years ago
Weblate 29c63b52ba Translated using Weblate (German)
Currently translated at 98.1% (1396 of 1423 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/de/
3 years ago
Weblate db0fb7d8a4 Translated using Weblate (Japanese)
Currently translated at 99.0% (1410 of 1423 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/ja/

Translated using Weblate (Japanese)

Currently translated at 98.5% (1402 of 1423 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/ja/
3 years ago
Weblate 55571111ad Translated using Weblate (English)
Currently translated at 100.0% (1424 of 1424 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1424 of 1424 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/
3 years ago
Weblate 7f3dbc606a Translated using Weblate (French)
Currently translated at 100.0% (1424 of 1424 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/fr/

Translated using Weblate (French)

Currently translated at 100.0% (1423 of 1423 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/fr/
3 years ago
ansuz f6eb6d5ca6 remove some hardcoded translations 3 years ago
ansuz 7077ec0740 Merge branch 'soon' into staging 3 years ago
ansuz bd3d87bb65 Merge branch 'main' into soon 3 years ago
yflory aad654e184 Fix calendar .ics import (#784) 3 years ago
ansuz 86ff13a4ef factor debugging data generation from support ticket transmission
and fix two incorrectly set width/height properties which overwrote 'appVersion'
3 years ago
yflory f28987bce5 Prepare for forms migration 3 years ago
yflory 9f2f488c2e Add missing uid 3 years ago
yflory 1229b8d4d5 Migrate opts.values format 3 years ago
yflory fc58780792 Prepare forms for future update 3 years ago
yflory 0139695697 Prepare forms for future update 3 years ago
yflory 6b4afa3d31 Fix syntax error 3 years ago
yflory b5fd885035 Merge branch 'forms2_DB_conflicts' into forms2 3 years ago
Weblate a5c55f1f49 Translated using Weblate (Japanese)
Currently translated at 98.9% (1390 of 1405 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/ja/

Translated using Weblate (Japanese)

Currently translated at 99.8% (1384 of 1386 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/ja/

Translated using Weblate (Japanese)

Currently translated at 99.8% (1383 of 1385 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/ja/
3 years ago
Weblate 7cf52a1c1a Translated using Weblate (English)
Currently translated at 100.0% (1423 of 1423 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1422 of 1422 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1421 of 1421 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1420 of 1420 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1419 of 1419 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1418 of 1418 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1417 of 1417 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1416 of 1416 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1415 of 1415 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1414 of 1414 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1413 of 1413 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1412 of 1412 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1411 of 1411 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1410 of 1410 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1409 of 1409 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1408 of 1408 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1407 of 1407 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1406 of 1406 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1406 of 1406 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1405 of 1405 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1405 of 1405 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1404 of 1404 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1404 of 1404 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1403 of 1403 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1402 of 1402 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1401 of 1401 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1400 of 1400 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1399 of 1399 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1398 of 1398 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1397 of 1397 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1396 of 1396 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1395 of 1395 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1394 of 1394 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1393 of 1393 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1392 of 1392 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1391 of 1391 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1390 of 1390 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1389 of 1389 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1388 of 1388 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1387 of 1387 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1386 of 1386 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1385 of 1385 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/

Translated using Weblate (English)

Currently translated at 100.0% (1384 of 1384 strings)

Translation: CryptPad/App
Translate-URL: http://weblate.cryptpad.fr/projects/cryptpad/app/en/
3 years ago
David Benqué 68c4232eb3 Changes related to translation strings 3 years ago
David Benqué a82481c36d Remove background from form result table for grid questions 3 years ago
yflory cbbf7df7ee Fix scroll position with flatpickr displayed 3 years ago
yflory ec50d9dc6f Improve condition creation in forms 3 years ago
ansuz a2ad37a8ad stop supporting IE
1. stop polyfilling promises
2. use named defines for chainpad-listmap and its dependencies while we're at it

use 'bower update' for things to work
3 years ago
ansuz e3eb009826 Merge branch 'soon' into staging 3 years ago
David Benqué 43d43bdcd6 Clean up translations for required questions 3 years ago
yflory 480f8e0b56 Merge branch 'forms2' of github.com:xwiki-labs/cryptpad into forms2 3 years ago
yflory 9770d03479 Disable 'sortable' when editing poll time options 3 years ago
yflory 6680293ef1 Update response page 3 years ago
yflory 538122d1b6 Fix submit/update button showing the wrong text 3 years ago
yflory 581988240a Redirect to submit page when updating responses 3 years ago
David Benqué e3ac524aad Mark temporary text with XXX 3 years ago
yflory 8f3a1bf93e Fix forms issues with sections 3 years ago
David Benqué 2d5f6fb883 Temporary text for toolbar collapse/expand button 3 years ago
David Benqué 68a3a19bf0 Use Tags instead of Tools in Kanban toolbar 3 years ago
David Benqué d2db3a5c5a Review use of primary, secondary, default buttons 3 years ago
David Benqué 37430f5294 Remove margin on icon-only button to remove a condition 3 years ago
David Benqué 24a21bab8d Add conditional section icon 3 years ago
yflory b964af4da2 Add try..catch in forms main.js 3 years ago
yflory 442afe14a4 Improve quick poll template 3 years ago
yflory e9a4416820 Fix text overflow in forms 3 years ago
yflory 5f22b00ba5 Fix forms editor responsive UI 3 years ago
yflory eb1d8478d6 Remove Conditional section text in edit mode 3 years ago
yflory 600cca564d Fix button icons 3 years ago
yflory 651dfee26c Merge branch 'condition' of github.com:xwiki-labs/cryptpad into condition 3 years ago
yflory 3f8150d50c Merge branch 'forms2' into condition 3 years ago
David Benqué e53261bd2d Improve condition editor UI layout 3 years ago
yflory 9051a5e65d Merge branch 'forms2' into formColor 3 years ago
yflory bbd449855f Cancel adding a closing date 3 years ago
yflory cd65bea28c Add 'Answer as ...' in forms 3 years ago
yflory 2ebe2b955c Move submit message in the submit page 3 years ago
yflory 513c2d51fc Update logo redirect in forms 3 years ago
yflory 478e95e24c Fix forms charts UI 3 years ago
yflory 15de4c64fe Merge branch 'forms2' of github.com:xwiki-labs/cryptpad into forms2 3 years ago
yflory ab79f32055 Fix forms issues 3 years ago
David Benqué 27a0a6a0ba Merge remote-tracking branch 'origin/forms2' into forms2 3 years ago
David Benqué cfa4a2708d Truncate response chart option values + add full option as tooltip 3 years ago
yflory 15eeaa75f6 Add logo to the submit page 3 years ago
yflory e0b49c7b71 Merge branch 'forms2' of github.com:xwiki-labs/cryptpad into forms2 3 years ago
yflory bcd4d88f81 Fix reordering questions in forms 3 years ago
yflory a9f131f051 Fix reordering questions in forms 3 years ago
David Benqué 258ccd4e60 Use default button for Responses/Editor 3 years ago
David Benqué 7f244d532f Style required question submit error 3 years ago
yflory a6794c5cee Improve condition selector in forms 3 years ago
yflory ef0e1c8eaf Merge branch 'forms2' into condition 3 years ago
yflory 415ee6018b Add number of form responses in the button 3 years ago
yflory c43d7e319b Merge branch 'forms2' of github.com:xwiki-labs/cryptpad into forms2 3 years ago
yflory d2b24e666d Forms V2 fixes 3 years ago