downgrade severity of several XXX notes

pull/1/head
ansuz 4 years ago
parent 395b432b60
commit d509fd8b8f

@ -59,7 +59,7 @@
} }
& > p:not(.cp-modal-form) { & > p:not(.cp-modal-form) {
text-align: left; // XXX needs testing text-align: left;
margin-right: 30px; margin-right: 30px;
} }

@ -36,7 +36,7 @@ Workers.initialize = function (Env, config, _cb) {
}; };
const countWorkerTasks = function (/* index */) { const countWorkerTasks = function (/* index */) {
return 0; // XXX this disables all queueing until it can be proven correct return 0; // FIXME this disables all queueing until it can be proven correct
//return Object.keys(workers[index].tasks || {}).length; //return Object.keys(workers[index].tasks || {}).length;
}; };

@ -1783,9 +1783,9 @@ define([
}); });
if (sharedF && manager.isPathIn(newPath, [TRASH])) { if (sharedF && manager.isPathIn(newPath, [TRASH])) {
// XXX create a key here? // TODO create a key here?
// You can't move to YOUR trash documents stored in a shared folder // You can't move to YOUR trash documents stored in a shared folder
// XXX or keep deletePaths: trigger the "Remove from cryptdrive" modal // TODO or keep deletePaths: trigger the "Remove from cryptdrive" modal
return void UI.warn(Messages.error); return void UI.warn(Messages.error);
//return void deletePaths(null, movedPaths); //return void deletePaths(null, movedPaths);
} }

@ -480,7 +480,7 @@ define([
// Make sure we have not been kicked from the roster // Make sure we have not been kicked from the roster
var state = roster.getState(); var state = roster.getState();
var me = Util.find(ctx, ['store', 'proxy', 'curvePublic']); var me = Util.find(ctx, ['store', 'proxy', 'curvePublic']);
// XXX FIXME roster history temporarily corrupted, don't leave the team // FIXME roster history temporarily corrupted, don't leave the team
if (!state.members || !Object.keys(state.members).length) { if (!state.members || !Object.keys(state.members).length) {
lm.stop(); lm.stop();
roster.stop(); roster.stop();
@ -488,6 +488,7 @@ define([
cb({error: 'EINVAL'}); cb({error: 'EINVAL'});
waitFor.abort(); waitFor.abort();
console.error(JSON.stringify(state)); console.error(JSON.stringify(state));
Feedback.send("ROSTER_CORRUPTED");
return; return;
} }
if (!state.members[me]) { if (!state.members[me]) {

@ -690,7 +690,7 @@ define([
}); });
ctx.sframeChan.on('EV_NEW_VERSION', function () { ctx.sframeChan.on('EV_NEW_VERSION', function () {
// XXX lock the UI and do the same in non-framework apps // TODO lock the UI and do the same in non-framework apps
var $err = $('<div>').append(Messages.newVersionError); var $err = $('<div>').append(Messages.newVersionError);
$err.find('a').click(function () { $err.find('a').click(function () {
funcs.gotoURL(); funcs.gotoURL();

@ -490,8 +490,7 @@ define([
}, function(obj) { }, function(obj) {
UI.removeLoadingScreen(); UI.removeLoadingScreen();
if (obj && obj.error) { if (obj && obj.error) {
// TODO // TODO more specific error message?
// XXX EEXISTS error message?
UI.alert(Messages.settings_changePasswordError); UI.alert(Messages.settings_changePasswordError);
} }
}); });

@ -421,7 +421,7 @@ define([
common.displayAvatar($(avatar), team.metadata.avatar, team.metadata.name); common.displayAvatar($(avatar), team.metadata.avatar, team.metadata.name);
$(btn).click(function () { $(btn).click(function () {
if (team.error) { if (team.error) {
UI.warn(Messages.error); // XXX better error message - roster bug, can't load the team for now UI.warn(Messages.error); // FIXME better error message - roster bug, can't load the team for now
return; return;
} }
openTeam(common, id, team); openTeam(common, id, team);

Loading…
Cancel
Save