refactor two mostly-identical functions

www/common/cryptpad-common.js

@@ -148,20 +148,19 @@ define([
         send();
     };
 
-    common.setTabHref = function (href) {
+    (function () {
-        var ohc = window.onhashchange;
+        var bypassHashChange = function (key) {
-        window.onhashchange = function () {};
+            return function (value) {
-        window.location.href = href;
+                var ohc = window.onhashchange;
-        window.onhashchange = ohc;
+                window.onhashchange = function () {};
-        ohc({reset: true});
+                window.location[key] = value;
-    };
+                window.onhashchange = ohc;
-    common.setTabHash = function (hash) {
+                ohc({reset: true});
-        var ohc = window.onhashchange;
+            };
-        window.onhashchange = function () {};
+        };
-        window.location.hash = hash;
+        common.setTabHref = bypassHashChange('href');
-        window.onhashchange = ohc;
+        common.setTabHash = bypassHashChange('hash');
-        ohc({reset: true});
+    }());
-    };
 
     // RESTRICTED
     // Settings only