harden server further against bad channel ids

7 years ago · a28a59abf0
parent 06c971ec47
commit a28a59abf0
1 changed files with 2 additions and 2 deletions
--- a/rpc.js
+++ b/rpc.js
@ -28,8 +28,8 @@ var WARN = function (e, output) {
 };

 var isValidId = function (chan) {
-    return chan && chan.length && /^[a-fA-F0-9]/.test(chan) ||
-        [32, 48].indexOf(chan.length) !== -1;
+    return chan && chan.length && /^[a-fA-F0-9]/.test(chan) &&
+        [32, 48].indexOf(chan.length) > -1;
 };

 var uint8ArrayToHex = function (a) {