Autoload template picker to make it faster to appear when used

www/common/sframe-common-interface.js

@@ -587,11 +587,18 @@ define([
         var sframeChan = common.getSframeChannel();
         var focus;
 
+        var pickerCfg = {
+            types: [type],
+            where: ['template'],
+            hidden: true
+        };
         var onConfirm = function (yes) {
             if (!yes) {
                 if (focus) { focus.focus(); }
                 return;
             }
+            delete pickerCfg.hidden;
+            common.openFilePicker(pickerCfg);
             var first = true; // We can only pick a template once (for a new document)
             var fileDialogCfg = {
                 onSelect: function (data) {
@@ -608,15 +615,11 @@ define([
                 }
             };
             common.initFilePicker(fileDialogCfg);
-            var pickerCfg = {
-                types: [type],
-                where: ['template']
-            };
-            common.openFilePicker(pickerCfg);
         };
 
         sframeChan.query("Q_TEMPLATE_EXIST", type, function (err, data) {
             if (data) {
+                common.openFilePicker(pickerCfg);
                 focus = document.activeElement;
                 Cryptpad.confirm(Messages.useTemplate, onConfirm, {
                     ok: Messages.useTemplateOK,

www/common/sframe-common-outer.js

@@ -362,7 +362,8 @@ define([
 
             // File picker
             var FP = {};
-            var initFilePicker = function (types) {
+            var initFilePicker = function (cfg) {
+                if (!FP.$iframe) {
                     var config = {};
                     config.onFilePicked = function (data) {
                         sframeChan.event('EV_FILE_PICKED', data);
@@ -371,13 +372,16 @@ define([
                         FP.$iframe.hide();
                     };
                     config.onFileUpload = onFileUpload;
-                config.types = types;
-                if (!FP.$iframe) {
+                    config.types = cfg;
                     FP.$iframe = $('<iframe>', {id: 'sbox-filePicker-iframe'}).appendTo($('body'));
                     FP.picker = FilePicker.create(config);
                 } else {
                     FP.$iframe.show();
-                    FP.picker.refresh(types);
+                    FP.picker.refresh(cfg);
+                }
+                if (cfg.hidden) {
+                    FP.$iframe.hide();
+                    return;
                 }
                 FP.$iframe.focus();
             };