refine link name placeholder suggestion and provide a more descriptive error message

pull/1/head
ansuz 4 years ago
parent 45b58d622d
commit 32027f09d6

@ -2745,9 +2745,15 @@ define([
url = h('input#cp-app-drive-link-url', { type: 'url', autocomplete: 'off', placeholder: Messages.form_input_ph_url }), url = h('input#cp-app-drive-link-url', { type: 'url', autocomplete: 'off', placeholder: Messages.form_input_ph_url }),
warning, warning,
]); ]);
var protocolPattern = /https*:\/\//;
var fragmentPattern = /#.*$/;
var setNamePlaceholder = function (val) { var setNamePlaceholder = function (val) {
val = val.replace(/https*:\/\//, '').replace(/#.*$/, '').slice(0, 16); var temp = val.replace(protocolPattern, '').replace(fragmentPattern, '').trim().slice(0, 48);
name.setAttribute('placeholder', val) if (!protocolPattern.test(val) || !temp) {
temp = Messages.fm_link_name_placeholder;
}
name.setAttribute('placeholder', temp);
}; };
var $warning = $(warning).hide(); var $warning = $(warning).hide();
@ -2778,7 +2784,7 @@ define([
if (!n || !u) { return true; } if (!n || !u) { return true; }
if (!Util.isValidURL(u)) { if (!Util.isValidURL(u)) {
// XXX 4.10.0 add style for invalid input? input:invalid // XXX 4.10.0 add style for invalid input? input:invalid
UI.warn(Messages.error); UI.warn(Messages.fm_link_invalid);
return true; return true;
} }
manager.addLink(currentPath, { manager.addLink(currentPath, {

Loading…
Cancel
Save