remove some comments

pull/1/head
ansuz 5 years ago
parent c9f569b109
commit 204f6b3af1

@ -106,7 +106,7 @@ module.exports.create = function (cfg) {
* offsetByHash: * offsetByHash:
* a map containing message offsets by their hash * a map containing message offsets by their hash
* this is for every message in history, so it could be very large... * this is for every message in history, so it could be very large...
* XXX OFFSET * FIXME OFFSET
* except we remove offsets from the map if they occur before the oldest relevant checkpoint * except we remove offsets from the map if they occur before the oldest relevant checkpoint
* size: in bytes * size: in bytes
* metadata: * metadata:
@ -333,7 +333,7 @@ module.exports.create = function (cfg) {
if (isCp) { if (isCp) {
index.cpIndex = sliceCpIndex(index.cpIndex, index.line || 0); index.cpIndex = sliceCpIndex(index.cpIndex, index.line || 0);
for (let k in index.offsetByHash) { for (let k in index.offsetByHash) {
// XXX OFFSET // FIXME OFFSET
if (index.offsetByHash[k] < index.cpIndex[0]) { if (index.offsetByHash[k] < index.cpIndex[0]) {
delete index.offsetByHash[k]; delete index.offsetByHash[k];
} }
@ -513,7 +513,6 @@ module.exports.create = function (cfg) {
// QUESTION: does this mean mailboxes are causing the server to store too much stuff in memory? // QUESTION: does this mean mailboxes are causing the server to store too much stuff in memory?
if (lastKnownHash && typeof(lkh) !== "number") { if (lastKnownHash && typeof(lkh) !== "number") {
waitFor.abort(); waitFor.abort();
// XXX this smells bad
return void cb(new Error('EINVAL')); return void cb(new Error('EINVAL'));
} }
@ -542,7 +541,7 @@ module.exports.create = function (cfg) {
if (offset !== -1) { return; } if (offset !== -1) { return; }
// do a lookup from the index // do a lookup from the index
// XXX maybe we don't need this anymore? // FIXME maybe we don't need this anymore?
// otherwise we have a non-negative offset and we can start to read from there // otherwise we have a non-negative offset and we can start to read from there
store.readMessagesBin(channelName, 0, (msgObj, readMore, abort) => { store.readMessagesBin(channelName, 0, (msgObj, readMore, abort) => {
// tryParse return a parsed message or undefined // tryParse return a parsed message or undefined
@ -678,7 +677,6 @@ module.exports.create = function (cfg) {
// If it is, remove it from memory and broadcast a message to its members // If it is, remove it from memory and broadcast a message to its members
const onChannelMetadataChanged = function (ctx, channel) { const onChannelMetadataChanged = function (ctx, channel) {
// XXX lint compliance
channel = channel; channel = channel;
}; };
@ -832,7 +830,7 @@ module.exports.create = function (cfg) {
// otherwise maybe we need to check that the metadata log is empty as well // otherwise maybe we need to check that the metadata log is empty as well
store.writeMetadata(channelName, JSON.stringify(metadata), function (err) { store.writeMetadata(channelName, JSON.stringify(metadata), function (err) {
if (err) { if (err) {
// XXX tell the user that there was a channel error? // FIXME tell the user that there was a channel error?
return void Log.error('HK_WRITE_METADATA'); return void Log.error('HK_WRITE_METADATA');
} }
}); });

Loading…
Cancel
Save