Merge duplicated code between framework and whiteboard

www/common/common-ui-elements.js

@@ -2639,7 +2639,6 @@ define([
         });
     };
 
-    // XXX add txid
     UIElements.initFilePicker = function (common, cfg) {
         var onSelect = cfg.onSelect || $.noop;
         var sframeChan = common.getSframeChannel();

www/common/sframe-app-framework.js

@@ -525,18 +525,23 @@ define([
                 }
             });
             $embedButton = common.createButton('mediatag', true).click(function () {
-                common.openFilePicker({
+                var cfg = {
                     types: ['file'],
                     where: ['root']
-                });
+                };
+                if ($embedButton.data('filter')) {
+                    cfg.filter = $embedButton.data('filter');
+                }
+                common.openFilePicker(cfg);
             }).appendTo(toolbar.$rightside).hide();
         };
-        var setMediaTagEmbedder = function (mte) {
+        var setMediaTagEmbedder = function (mte, filter) {
             if (!common.isLoggedIn()) { return; }
             if (!mte || readOnly) {
                 $embedButton.hide();
                 return;
             }
+            if (filter) { $embedButton.data('filter', filter); }
             $embedButton.show();
             mediaTagEmbedder = mte;
         };

www/whiteboard/inner.js

@@ -399,34 +399,18 @@ define([
         }).appendTo($rightside);
 
         if (framework._.sfCommon.isLoggedIn()) {
-            var fileDialogCfg = {
+            framework.setMediaTagEmbedder(function ($mt) {
-                onSelect: function (data) {
+                framework._.sfCommon.displayMediatagImage($mt, function (err, $image) {
-                    if (data.type === 'file') {
-                        var mt = '<media-tag src="' + data.src + '" data-crypto-key="cryptpad:' + data.key + '"></media-tag>';
-                        framework._.sfCommon.displayMediatagImage($(mt), function (err, $image) {
                     // Convert src from blob URL to base64 data URL
-                            // XXX base64 is heavy...
                     Util.blobURLToImage($image.attr('src'), function (imgSrc) {
                         var img = new Image();
                         img.onload = function () { addImageToCanvas(img); };
                         img.src = imgSrc;
                     });
                 });
-                        return;
+            }, {
-                    }
-                }
-            };
-            framework._.sfCommon.initFilePicker(fileDialogCfg);
-            framework._.sfCommon.createButton('mediatag', true).click(function () {
-                var pickerCfg = {
-                    types: ['file'],
-                    where: ['root'],
-                    filter: {
                 fileType: ['image/']
-                    }
+            });
-                };
-                framework._.sfCommon.openFilePicker(pickerCfg);
-            }).appendTo($rightside);
 
             // Export to drive as PNG
             framework._.sfCommon.createButton('savetodrive', true, {}).click(function () {