broken preview image when incomplete URL #43

Open
opened 2 years ago by x1ddos · 1 comments
x1ddos commented 2 years ago
Owner

noticed this post today:

image

noxy returns the following for xethub.com/user/login:

{
  "type":"website",
   "title":"XetHub: fast, frictionless collaboration at scale",
   "descr":"XetHub is the data platform designed for fast, frictionless collaboration for everyone at every scale.",
   "images":["/assets/img/logo.png"]
}

the image is then set to undefined in dom:

image

i think it's because the /assets/... is just a path, not an absolute url.

@offbyn the question is, should nostrweb resolve url to https://xethub.com/assets/img/logo.png or noxy proxy?

noticed this post today: ![image](/attachments/46c4646e-b7db-4b72-a73a-27ea3d1ca31b) noxy returns the following for `xethub.com/user/login`: ```json { "type":"website", "title":"XetHub: fast, frictionless collaboration at scale", "descr":"XetHub is the data platform designed for fast, frictionless collaboration for everyone at every scale.", "images":["/assets/img/logo.png"] } ``` the image is then set to `undefined` in dom: ![image](/attachments/6531f926-8d12-4e29-8d03-338b741fc7f3) i think it's because the `/assets/...` is just a path, not an absolute url. @offbyn the question is, should nostrweb resolve url to https://xethub.com/assets/img/logo.png or noxy proxy?
x1ddos added the
bug
label 2 years ago
x1ddos added this to the mvp project 2 years ago
offbyn commented 2 years ago
Owner

nostrweb should definetly do it.

nostrweb should definetly do it.
offbyn self-assigned this 2 years ago
x1ddos added this to the mvp milestone 2 years ago
Sign in to join this conversation.
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: nostr/nostrweb#43
Loading…
There is no content yet.