From ad45ad3f83da875d8741501f109b9fb4d8b1f728 Mon Sep 17 00:00:00 2001
From: Tom Hacohen <tom@stosb.com>
Date: Fri, 22 Feb 2019 16:27:35 +0000
Subject: [PATCH] Update tslint and fix warnings.

---
 src/Journals/JournalEdit.tsx           |  4 ++--
 src/Journals/index.tsx                 |  2 +-
 src/Journals/journalView.tsx           |  4 ++--
 src/LoginGate.tsx                      |  4 ++--
 src/Pim/index.tsx                      | 10 +++++-----
 src/SideMenu/index.tsx                 |  2 +-
 src/SyncGate.tsx                       |  4 ++--
 src/components/Calendar.tsx            |  2 +-
 src/components/Contact.tsx             |  4 ++--
 src/components/ContactEdit.tsx         |  2 +-
 src/components/EncryptionLoginForm.tsx |  2 +-
 src/components/Event.tsx               |  2 +-
 src/components/EventEdit.tsx           |  2 +-
 src/components/Task.tsx                |  2 +-
 src/components/TaskEdit.tsx            |  2 +-
 tslint.json                            |  3 +++
 16 files changed, 27 insertions(+), 24 deletions(-)

diff --git a/src/Journals/JournalEdit.tsx b/src/Journals/JournalEdit.tsx
index 7c89dd5..8d59e29 100644
--- a/src/Journals/JournalEdit.tsx
+++ b/src/Journals/JournalEdit.tsx
@@ -94,7 +94,7 @@ class JournalEdit extends React.PureComponent<PropsTypeInner> {
               </InputLabel>
               <Select
                 name="type"
-                required={true}
+                required
                 value={this.state.info.type}
                 onChange={this.handleInputChange}
               >
@@ -105,7 +105,7 @@ class JournalEdit extends React.PureComponent<PropsTypeInner> {
             </FormControl>
             <TextField
               name="displayName"
-              required={true}
+              required
               label="Display name of this collection"
               value={this.state.info.displayName}
               onChange={this.handleInputChange}
diff --git a/src/Journals/index.tsx b/src/Journals/index.tsx
index 7ef2ec7..e2a0076 100644
--- a/src/Journals/index.tsx
+++ b/src/Journals/index.tsx
@@ -37,7 +37,7 @@ class Journals extends React.PureComponent {
       <Switch>
         <Route
           path={routeResolver.getRoute('journals')}
-          exact={true}
+          exact
           render={({ history }) => (
             <>
               <JournalsList
diff --git a/src/Journals/journalView.tsx b/src/Journals/journalView.tsx
index 1495077..8a2d182 100644
--- a/src/Journals/journalView.tsx
+++ b/src/Journals/journalView.tsx
@@ -38,7 +38,7 @@ export function journalView(JournalList: any, JournalItem: any) {
         <Switch>
           <Route
             path={routeResolver.getRoute('journals._id')}
-            exact={true}
+            exact
             render={() => (
               <JournalList entries={objValues(items)} onItemClick={this.itemClicked} />
               )
@@ -46,7 +46,7 @@ export function journalView(JournalList: any, JournalItem: any) {
           />
           <Route
             path={routeResolver.getRoute('journals._id.items._id')}
-            exact={true}
+            exact
             render={({match}) => {
 
               return (
diff --git a/src/LoginGate.tsx b/src/LoginGate.tsx
index 53fbd29..ade9bbf 100644
--- a/src/LoginGate.tsx
+++ b/src/LoginGate.tsx
@@ -54,9 +54,9 @@ class LoginGate extends React.Component {
             error={this.props.credentials.error}
             loading={this.props.credentials.fetching}
           />
-          <hr style={style.divider}/>
+          <hr style={style.divider} />
           <ExternalLink style={style.isSafe} href="https://www.etesync.com/faq/#signed-pages">
-            <img src={SignedPagesBadge}/>
+            <img src={SignedPagesBadge} />
           </ExternalLink>
           <ul>
             <li><ExternalLink style={style.isSafe} href={C.homePage}>
diff --git a/src/Pim/index.tsx b/src/Pim/index.tsx
index 4ded54b..5e4fc9c 100644
--- a/src/Pim/index.tsx
+++ b/src/Pim/index.tsx
@@ -133,7 +133,7 @@ const CollectionRoutes = withStyles(styles)(withRouter(
         <Switch>
           <Route
             path={routeResolver.getRoute(props.routePrefix + '.new')}
-            exact={true}
+            exact
             render={({match}) => (
               <Container style={{maxWidth: '30rem'}}>
                 <ComponentEdit
@@ -146,7 +146,7 @@ const CollectionRoutes = withStyles(styles)(withRouter(
           />
           <Route
             path={routeResolver.getRoute(props.routePrefix + '._id.edit')}
-            exact={true}
+            exact
             render={({match}) => (
               <Container style={{maxWidth: '30rem'}}>
                 {(match.params.itemUid in props.items) &&
@@ -164,7 +164,7 @@ const CollectionRoutes = withStyles(styles)(withRouter(
           />
           <Route
             path={routeResolver.getRoute(props.routePrefix + '._id.log')}
-            exact={true}
+            exact
             render={({match}) => (
               <Container>
                 <ItemChangeLog
@@ -177,7 +177,7 @@ const CollectionRoutes = withStyles(styles)(withRouter(
           />
           <Route
             path={routeResolver.getRoute(props.routePrefix + '._id')}
-            exact={true}
+            exact
             render={({match, history}) => (
               <Container>
                 <div style={{textAlign: 'right', marginBottom: 15}}>
@@ -316,7 +316,7 @@ class Pim extends React.PureComponent {
       <Switch>
         <Route
           path={routeResolver.getRoute('pim')}
-          exact={true}
+          exact
           render={({history}) => (
             <PimMain
               contacts={objValues(addressBookItems)}
diff --git a/src/SideMenu/index.tsx b/src/SideMenu/index.tsx
index 6472ba6..af1f928 100644
--- a/src/SideMenu/index.tsx
+++ b/src/SideMenu/index.tsx
@@ -68,7 +68,7 @@ class SideMenu extends React.PureComponent<PropsTypeInner> {
               this.props.history.push(routeResolver.getRoute('settings'));
             }}
           />
-          <ListItem primaryText="Log Out" leftIcon={<LogoutIcon/>}  onClick={this.logout} />
+          <ListItem primaryText="Log Out" leftIcon={<LogoutIcon />}  onClick={this.logout} />
         </React.Fragment>
       );
     }
diff --git a/src/SyncGate.tsx b/src/SyncGate.tsx
index 80ebca4..e1df568 100644
--- a/src/SyncGate.tsx
+++ b/src/SyncGate.tsx
@@ -195,7 +195,7 @@ class SyncGate extends React.PureComponent<PropsTypeInner> {
       <Switch>
         <Route
           path={routeResolver.getRoute('home')}
-          exact={true}
+          exact
           render={({match}) => (
             <Redirect to={routeResolver.getRoute('pim')} />
           )}
@@ -229,7 +229,7 @@ class SyncGate extends React.PureComponent<PropsTypeInner> {
         />
         <Route
           path={routeResolver.getRoute('settings')}
-          exact={true}
+          exact
           render={({history}) => (
             <Settings
               history={history}
diff --git a/src/components/Calendar.tsx b/src/components/Calendar.tsx
index 7f0d46d..06b9dd6 100644
--- a/src/components/Calendar.tsx
+++ b/src/components/Calendar.tsx
@@ -76,7 +76,7 @@ class Calendar extends React.PureComponent<PropsType> {
           defaultDate={new Date()}
           localizer={calendarLocalizer}
           events={entries}
-          selectable={true}
+          selectable
           onSelectEvent={this.props.onItemClick as any}
           onSelectSlot={this.slotClicked as any}
           formats={{agendaHeaderFormat: agendaHeaderFormat as any}}
diff --git a/src/components/Contact.tsx b/src/components/Contact.tsx
index 64760f3..b3399f4 100644
--- a/src/components/Contact.tsx
+++ b/src/components/Contact.tsx
@@ -117,7 +117,7 @@ class Contact extends React.PureComponent {
         return (
           <ListItem
             key={idx}
-            insetChildren={true}
+            insetChildren
             primaryText={val}
             secondaryText={prop.name}
           />
@@ -134,7 +134,7 @@ class Contact extends React.PureComponent {
               {items}
             </List>
             <List>
-              <Divider inset={true} />
+              <Divider inset />
             </List>
           </React.Fragment>
         );
diff --git a/src/components/ContactEdit.tsx b/src/components/ContactEdit.tsx
index da5db66..e0309b3 100644
--- a/src/components/ContactEdit.tsx
+++ b/src/components/ContactEdit.tsx
@@ -470,7 +470,7 @@ class ContactEdit extends React.PureComponent<PropsType> {
 
           <TextField
             name="note"
-            multiline={true}
+            multiline
             placeholder="Note"
             style={styles.fullWidth}
             value={this.state.note}
diff --git a/src/components/EncryptionLoginForm.tsx b/src/components/EncryptionLoginForm.tsx
index 442fce9..3c2e4b2 100644
--- a/src/components/EncryptionLoginForm.tsx
+++ b/src/components/EncryptionLoginForm.tsx
@@ -73,7 +73,7 @@ class EncryptionLoginForm extends React.PureComponent {
         <form style={styles.form} onSubmit={this.generateEncryption}>
           <TextField
             type="password"
-            autoFocus={true}
+            autoFocus
             error={!!this.state.errors.errorEncryptionPassword}
             helperText={this.state.errors.errorEncryptionPassword}
             label="Encryption Password"
diff --git a/src/components/Event.tsx b/src/components/Event.tsx
index 6e12e6a..6942deb 100644
--- a/src/components/Event.tsx
+++ b/src/components/Event.tsx
@@ -28,7 +28,7 @@ class Event extends React.PureComponent {
       <React.Fragment>
         <PimItemHeader text={this.props.item.summary} backgroundColor={this.props.item.color}>
           <div>{formatDateRange(this.props.item.startDate, this.props.item.endDate)} {timezone && <small>({timezone})</small>}</div>
-          <br/>
+          <br />
           <div><u>{this.props.item.location}</u></div>
         </PimItemHeader>
         <div style={style.content}>
diff --git a/src/components/EventEdit.tsx b/src/components/EventEdit.tsx
index 204cbbd..97f1d25 100644
--- a/src/components/EventEdit.tsx
+++ b/src/components/EventEdit.tsx
@@ -297,7 +297,7 @@ class EventEdit extends React.PureComponent<PropsType> {
           <TextField
             name="description"
             placeholder="Add description"
-            multiline={true}
+            multiline
             style={styles.fullWidth}
             value={this.state.description}
             onChange={this.handleInputChange}
diff --git a/src/components/Task.tsx b/src/components/Task.tsx
index 80377f4..5ea84c8 100644
--- a/src/components/Task.tsx
+++ b/src/components/Task.tsx
@@ -35,7 +35,7 @@ class Task extends React.PureComponent {
           { item.dueDate &&
             <div>Due: {formatDate(item.dueDate)} {timezone && <small>({timezone})</small>}</div>
           }
-          <br/>
+          <br />
           <div><u>{this.props.item.location}</u></div>
         </PimItemHeader>
         <div style={style.content}>
diff --git a/src/components/TaskEdit.tsx b/src/components/TaskEdit.tsx
index b94a944..31340c5 100644
--- a/src/components/TaskEdit.tsx
+++ b/src/components/TaskEdit.tsx
@@ -301,7 +301,7 @@ class TaskEdit extends React.PureComponent<PropsType> {
           <TextField
             name="description"
             placeholder="Add description"
-            multiline={true}
+            multiline
             style={styles.fullWidth}
             value={this.state.description}
             onChange={this.handleInputChange}
diff --git a/tslint.json b/tslint.json
index 7648272..195a66e 100644
--- a/tslint.json
+++ b/tslint.json
@@ -4,10 +4,13 @@
       "no-console": [true, "error"],
       "interface-name": [true, "never-prefix"],
       "ordered-imports": false,
+      "jsx-boolean-value": [true, "never"],
       "jsx-curly-spacing": [true, "never"],
       "jsx-no-bind": [true, "allowArrowFunctions"],
       "jsx-no-lambda": [false],
       "jsx-no-multiline-js": false,
+      "jsx-space-before-trailing-slash": true,
+      "jsx-key": true,
       "max-classes-per-file": [false, 0],
       "max-line-length": false,
       "no-consecutive-blank-lines": false,