infra
/
etesync
2
0
Fork 0
Code Issues Pull Requests Packages Activity

Reducer: don't reset the store when fetching. 

There were a couple of bugs there:
1. The store was reset while fetching/error because the payload was
empty/error.
2. The error status wasn't reset after for successful fetches that
follow failed ones.
master
Tom Hacohen 2017-12-16 21:33:38 +00:00
parent b876a90a5a
commit 2aa92f15e7
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/store/reducers.ts
View File

@ -67,10 +67,17 @@ function credentialsIdentityReducer(state: CredentialsType = {value: null}, acti
function fetchTypeIdentityReducer(
state: Record<FetchType<any>> = fetchTypeRecord<any>()(), action: any, extend: boolean = false) {
if (action.error) {
return state.set('value', null).set('error', action.payload);
return state.set('error', action.payload);
} else {
const fetching = (action.payload === undefined) ? true : undefined;
const payload = (action.payload === undefined) ? null : action.payload;
state = state.set('error', undefined);
if (fetching) {
return state.set('fetching', fetching);
}
let value = state.get('value', null);
if (extend && (value !== null)) {
if (payload !== null) {
@ -81,7 +88,10 @@ function fetchTypeIdentityReducer(
} else {
value = null;
}
return state.set('value', value).set('fetching', fetching);
return state.merge({
value,
fetching,
});
}
}