From f7bada95edd9e8738447b1c9b2af3973be9c6ce2 Mon Sep 17 00:00:00 2001
From: ansuz <ansuz@transitiontech.ca>
Date: Fri, 26 Feb 2021 16:08:21 +0530
Subject: [PATCH] flag some duplicated code

---
 www/admin/inner.js               | 2 +-
 www/common/common-ui-elements.js | 4 ++--
 www/common/common-util.js        | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/www/admin/inner.js b/www/admin/inner.js
index 444ff6c05..f99b98fda 100644
--- a/www/admin/inner.js
+++ b/www/admin/inner.js
@@ -273,7 +273,7 @@ define([
         return $div;
     };
 
-    var getPrettySize = function (bytes) {
+    var getPrettySize = function (bytes) { // XXX duplicate of UIElements.prettySize ?
         var unit = Util.magnitudeOfBytes(bytes);
         var value = unit === 'GB' ? Util.bytesToGigabytes(bytes) : Util.bytesToMegabytes(bytes);
         return unit === 'GB' ? Messages._getKey('formattedGB', [value])
diff --git a/www/common/common-ui-elements.js b/www/common/common-ui-elements.js
index c7c28bc4a..975810a88 100644
--- a/www/common/common-ui-elements.js
+++ b/www/common/common-ui-elements.js
@@ -35,9 +35,9 @@ define([
 
     UIElements.prettySize = function (bytes) {
         var kB = Util.bytesToKilobytes(bytes);
-        if (kB < 1024) { return kB + Messages.KB; }
+        if (kB < 1024) { return kB + Messages.KB; } // XXX replace with Msg.formattedKB ?
         var mB = Util.bytesToMegabytes(bytes);
-        return mB + Messages.MB;
+        return mB + Messages.MB; // XXX replace with Msg.formattedMB
     };
 
     UIElements.updateTags = function (common, hrefs) {
diff --git a/www/common/common-util.js b/www/common/common-util.js
index 1518cf0d8..1c2bc0222 100644
--- a/www/common/common-util.js
+++ b/www/common/common-util.js
@@ -272,7 +272,7 @@
         else if (bytes >= oneMegabyte) { return 'MB'; }
     };
 
-    Util.getPrettySize = function (bytes, Messages) {
+    Util.getPrettySize = function (bytes, Messages) { // XXX not used anywhere?
         var unit = Util.magnitudeOfBytes(bytes);
         if (unit === 'GB') {
             return Messages._getKey('formattedGB', [Util.bytesToGigabytes(bytes)]);