Fix the infinite spinner bug with the file manager store

customize.dist/fsStore.js

@@ -153,8 +153,15 @@ define([
             }
             onReady(f, rt.proxy, Cryptpad.storageKey);
         })
-        .on('disconnect', function () {
+        .on('disconnect', function (info) {
             //setEditable(false);
+            if (info.error) {
+                //Cryptpad.alert(Messages.websocketError);
+                if (typeof Cryptpad.storeError === "function") {
+                    Cryptpad.storeError();
+                }
+                return;
+            }
             Cryptpad.alert(Messages.common_connectionLost);
         });
 

customize.dist/translations/messages.js

@@ -21,6 +21,7 @@ define(function () {
     ].join('');
 
     out.common_connectionLost = 'Server Connection Lost';
+    out.websocketError = 'Unable to connect to the websocket server...';
 
     out.disconnected = 'Disconnected';
     out.synchronizing = 'Synchronizing';

www/code/main.js

@@ -42,6 +42,11 @@ define([
             secret.keys = secret.key;
         }
 
+        var onConnectError = function (info) {
+            module.spinner.hide();
+            Cryptpad.alert(Messages.websocketError);
+        };
+
         var andThen = function (CMeditor) {
             var CodeMirror = module.CodeMirror = CMeditor;
             CodeMirror.modeURL = "/bower_components/codemirror/mode/%N/%N.js";
@@ -687,10 +692,7 @@ define([
                 }
             };
 
-            var onError = config.onError = function (info) {
-                module.spinner.hide();
-                Cryptpad.alert(Messages.websocketError);
-            };
+            var onError = config.onError = onConnectError();
 
             var realtime = module.realtime = Realtime.start(config);
 
@@ -704,6 +706,11 @@ define([
                 // TODO handle error
                 andThen(CM);
             });
+            Cryptpad.onError(function (info) {
+                if (info && info.type === "store") {
+                    onConnectError();
+                }
+            });
         };
 
         var first = function () {

www/common/cryptpad-common.js

@@ -649,6 +649,19 @@ define([
         }, common);
     };
 
+    var errorHandlers = [];
+    common.onError = function (h) {
+        if (typeof h !== "function") { return; }
+        errorHandlers.push(h);
+    };
+    common.storeError = function () {
+        errorHandlers.forEach(function (h) {
+            if (typeof h === "function") {
+                h({type: "store"});
+            }
+        });
+    };
+
     /*
      *  Saving files
      */
@@ -877,9 +890,9 @@ define([
         var $link = $('link[href="/customize/alertify.css"]');
         if ($link.length) {
             return;
-            $link.attr('href', '');
+            /*$link.attr('href', '');
             $link.attr('href', '/customize/alertify.css');
-            return;
+            return;*/
         }
 
         href = href || '/customize/alertify.css';

www/pad/main.js

@@ -77,6 +77,11 @@ define([
         return hj;
     };
 
+    var onConnectError = function (info) {
+        module.spinner.hide();
+        Cryptpad.alert(Messages.websocketError);
+    };
+
     var andThen = function (Ckeditor) {
         var secret = Cryptpad.getSecrets();
         var readOnly = secret.keys && !secret.keys.editKeyStr;
@@ -691,10 +696,7 @@ define([
                 }
             };
 
-            var onError = realtimeOptions.onError = function (info) {
-                module.spinner.hide();
-                Cryptpad.alert(Messages.websocketError);
-            };
+            var onError = realtimeOptions.onError = onConnectError;
 
             var onLocal = realtimeOptions.onLocal = function () {
                 if (initializing) { return; }
@@ -741,6 +743,11 @@ define([
             // TODO handle error
             andThen(Ckeditor);
         });
+        Cryptpad.onError(function (info) {
+            if (info && info.type === "store") {
+                onConnectError();
+            }
+        });
     };
 
     var first = function () {

www/poll/test/main.js

@@ -662,6 +662,10 @@ define([
 
     var disconnect = function () {
         //setEditable(false); // TODO
+        if (info.error) {
+            Cryptpad.alert(Messages.websocketError);
+            return;
+        }
         //Cryptpad.alert(Messages.common_connectionLost); // TODO
     };
 

www/slide/main.js

@@ -59,6 +59,11 @@ define([
 
         var presentMode = Slide.isPresentURL();
 
+        var onConnectError = function (info) {
+            module.spinner.hide();
+            Cryptpad.alert(Messages.websocketError);
+        };
+
         var andThen = function (CMeditor) {
             var CodeMirror = module.CodeMirror = CMeditor;
             CodeMirror.modeURL = "/bower_components/codemirror/mode/%N/%N.js";
@@ -786,10 +791,7 @@ define([
                 }
             };
 
-            var onError = config.onError = function (info) {
-                module.spinner.hide();
-                Cryptpad.alert(Messages.websocketError);
-            };
+            var onError = config.onError = onConnectError;
 
             var realtime = module.realtime = Realtime.start(config);
 
@@ -803,6 +805,11 @@ define([
                 // TODO handle error
                 andThen(CM);
             });
+            Cryptpad.onError(function (info) {
+                if (info && info.type === "store") {
+                    onConnectError();
+                }
+            });
         };
 
         var first = function () {