From 5b3dcde28cb0a6f71bc09cc8ccb69939d206ec95 Mon Sep 17 00:00:00 2001
From: ansuz <ansuz@transitiontech.ca>
Date: Fri, 9 Jul 2021 16:43:17 +0530
Subject: [PATCH 1/4] disable cache usage for form results

---
 www/common/outer/cache-store.js | 2 +-
 www/form/main.js                | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/www/common/outer/cache-store.js b/www/common/outer/cache-store.js
index fdb1f7668..514e18ab7 100644
--- a/www/common/outer/cache-store.js
+++ b/www/common/outer/cache-store.js
@@ -97,7 +97,7 @@ define([
     var checkCheckpoints = function (array) {
         if (!Array.isArray(array)) { return; }
         // Keep the last 100 messages
-        if (array.length > 100) {
+        if (array.length > 100) { // XXX
             array.splice(0, array.length - 100);
         }
         // Remove every message before the first checkpoint
diff --git a/www/form/main.js b/www/form/main.js
index 9ccac3d00..3b2c160a4 100644
--- a/www/form/main.js
+++ b/www/form/main.js
@@ -176,7 +176,7 @@ define([
                         validateKey: keys.secondaryValidateKey,
                         owners: [myKeys.edPublic],
                         crypto: crypto,
-                        Cache: Utils.Cache
+                        //Cache: Utils.Cache // XXX
                     };
                     var results = {};
                     config.onError = function (info) {

From 90b6787fa814172823d84eadc64a568661fef894 Mon Sep 17 00:00:00 2001
From: ansuz <ansuz@transitiontech.ca>
Date: Fri, 9 Jul 2021 16:43:17 +0530
Subject: [PATCH 2/4] disable cache usage for form results

---
 www/common/outer/cache-store.js | 2 +-
 www/form/main.js                | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/www/common/outer/cache-store.js b/www/common/outer/cache-store.js
index fdb1f7668..514e18ab7 100644
--- a/www/common/outer/cache-store.js
+++ b/www/common/outer/cache-store.js
@@ -97,7 +97,7 @@ define([
     var checkCheckpoints = function (array) {
         if (!Array.isArray(array)) { return; }
         // Keep the last 100 messages
-        if (array.length > 100) {
+        if (array.length > 100) { // XXX
             array.splice(0, array.length - 100);
         }
         // Remove every message before the first checkpoint
diff --git a/www/form/main.js b/www/form/main.js
index 9ccac3d00..3b2c160a4 100644
--- a/www/form/main.js
+++ b/www/form/main.js
@@ -176,7 +176,7 @@ define([
                         validateKey: keys.secondaryValidateKey,
                         owners: [myKeys.edPublic],
                         crypto: crypto,
-                        Cache: Utils.Cache
+                        //Cache: Utils.Cache // XXX
                     };
                     var results = {};
                     config.onError = function (info) {

From 3f1b6ba74d7fc2129bb4cdf976fcdd2f17387667 Mon Sep 17 00:00:00 2001
From: ansuz <ansuz@transitiontech.ca>
Date: Thu, 8 Jul 2021 17:55:25 +0530
Subject: [PATCH 3/4] some minor fixes for anon drives

* don't show the collapse tree button in the toolbar
* display the bread crumb when viewing shared folders
---
 www/common/drive-ui.js | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/www/common/drive-ui.js b/www/common/drive-ui.js
index e079ad2b9..b2489c22b 100644
--- a/www/common/drive-ui.js
+++ b/www/common/drive-ui.js
@@ -2289,7 +2289,8 @@ define([
         var createTitle = function ($container, path, noStyle) {
             if (!path || path.length === 0) { return; }
             var isTrash = manager.isPathIn(path, [TRASH]);
-            if (APP.mobile() && !noStyle) { // noStyle means title in search result
+            // we assume that users viewing shared folders may want to see the "bread-crumb"
+            if (!APP.newSharedFolder && APP.mobile() && !noStyle) { // noStyle means title in search result
                 return $container;
             }
             var isVirtual = virtualCategories.indexOf(path[0]) !== -1;
@@ -3147,7 +3148,8 @@ define([
             if (APP.$burnThisDrive) {
                 APP.toolbar.$bottomR.append(APP.$burnThisDrive);
             }
-            collapseTreeButton();
+            // this button is not useful for unregistered users who do not have a tree worth looking at
+            if (APP.loggedIn) { collapseTreeButton(); }
             return $toolbar;
         };
 

From 32e79d323df4a7e7a114637be0e8054202ea3725 Mon Sep 17 00:00:00 2001
From: ansuz <ansuz@transitiontech.ca>
Date: Fri, 9 Jul 2021 18:53:27 +0530
Subject: [PATCH 4/4] add support for tabs in ckeditor

and leave a note about the challenges of accessibility here
---
 www/pad/inner.js | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/www/pad/inner.js b/www/pad/inner.js
index 304e9abe4..95e7c1bff 100644
--- a/www/pad/inner.js
+++ b/www/pad/inner.js
@@ -1326,6 +1326,11 @@ define([
                 }));
                 $(waitFor());
             }).nThen(function(waitFor) {
+                // TODO this breaks users' ability to tab out of the editor
+                // but that's a problem in other editors and nobody has complained so far
+                // so we'll include this as-is for now while we search for a good pattern
+                // addresses this issue more generally
+                Ckeditor.config.tabSpaces = 4;
                 Ckeditor.config.toolbarCanCollapse = true;
                 Ckeditor.config.language = Messages._getLanguage();
                 if (screen.height < 800) {