From d1885fbab6b029eac3f08f79063c8f63ef08d44a Mon Sep 17 00:00:00 2001
From: ansuz <ansuz@transitiontech.ca>
Date: Mon, 15 Feb 2016 15:42:08 +0100
Subject: [PATCH] better jshint compliance for common files

---
 www/common/hyperjson.js        |  2 +-
 www/common/rainbow.js          |  2 +-
 www/common/realtime-input.js   |  4 ++--
 www/common/sharejs_textarea.js |  6 ++++--
 www/common/treesome.js         | 15 +++++++++------
 5 files changed, 17 insertions(+), 12 deletions(-)

diff --git a/www/common/hyperjson.js b/www/common/hyperjson.js
index 991317a66..db6d3f20f 100644
--- a/www/common/hyperjson.js
+++ b/www/common/hyperjson.js
@@ -52,7 +52,7 @@ define([], function () {
         for(;i < el.attributes.length; i++){
           var attr = el.attributes[i];
           if(attr.name && attr.value){
-            if(attr.name == "style"){
+            if(attr.name === "style"){
               attributes.style = parseStyle(el);
             }
             else{
diff --git a/www/common/rainbow.js b/www/common/rainbow.js
index 843755cf2..6aa732c4e 100644
--- a/www/common/rainbow.js
+++ b/www/common/rainbow.js
@@ -6,7 +6,7 @@ define([], function () {
             t = [],
             rgb = [0,2,4];
 
-        while(i<n)t.push(i++);
+        while(i<n) { t.push(i++); }
 
         var colours = t.map(function (c, I) {
             return '#'+ rgb.map(function (j) {
diff --git a/www/common/realtime-input.js b/www/common/realtime-input.js
index ad0e03e71..05703e8e9 100644
--- a/www/common/realtime-input.js
+++ b/www/common/realtime-input.js
@@ -149,9 +149,9 @@ define([
         var doc = config.doc || null;
 
         // trying to deprecate onRemote, prefer loading it via the conf
-        onRemote = config.onRemote || null;
+        var onRemote = config.onRemote || null;
 
-        transformFunction = config.transformFunction || null;
+        var transformFunction = config.transformFunction || null;
 
         var socket = makeWebsocket(websocketUrl);
         // define this in case it gets called before the rest of our stuff is ready.
diff --git a/www/common/sharejs_textarea.js b/www/common/sharejs_textarea.js
index 89c761f3e..18282d682 100644
--- a/www/common/sharejs_textarea.js
+++ b/www/common/sharejs_textarea.js
@@ -52,7 +52,9 @@ define(function () {
  */
 var applyChange = function(ctx, oldval, newval) {
     // Strings are immutable and have reference equality. I think this test is O(1), so its worth doing.
-    if (oldval === newval) return;
+    if (oldval === newval) {
+        return;
+    }
 
     var commonStart = 0;
     while (oldval.charAt(commonStart) === newval.charAt(commonStart)) {
@@ -111,7 +113,7 @@ var attachTextarea = function(elem, ctx) {
         var scrollTop = elem.scrollTop;
         elem.value = newText;
         content = elem.value; // Not done on one line so the browser can do newline conversion.
-        if (elem.scrollTop !== scrollTop) elem.scrollTop = scrollTop;
+        if (elem.scrollTop !== scrollTop) { elem.scrollTop = scrollTop; }
 
         // Setting the selection moves the cursor. We'll just have to let your
         // cursor drift if the element isn't active, though usually users don't
diff --git a/www/common/treesome.js b/www/common/treesome.js
index 06201bf6d..0b4da52c8 100644
--- a/www/common/treesome.js
+++ b/www/common/treesome.js
@@ -161,7 +161,8 @@ define([], function () {
         var i = 0, success = false;
         // FIXME can't be trusted if element is not found.
         tree.some(ancestor, function (e, index) {
-            return (++i, e === el);
+            ++i;
+            return e === el;
         });
         return i;
     };
@@ -173,21 +174,23 @@ define([], function () {
                 // terminate
                 return true;
             } else {
-                return (++i === n) ?
-                ((el = e), true):
-                false;
+                if (++i === n) {
+                    el = e;
+                    return true;
+                } else {
+                    return false;
+                }
             }
         });
         return el;
     };
 
     tree.contains = function (el, ancestor) {
-        ancestor = ancestor || inner;
         return el && ancestor.contains && ancestor.contains(el);
     };
 
     tree.check = function (el, ancestor) {
-        return tree.nthFromEnd(Tree.distanceFromEnd(el, ancestor), ancestor) === el;
+        return tree.nthFromEnd(tree.distanceFromEnd(el, ancestor), ancestor) === el;
     };
 
     // TODO see if we can use this