From 11369e553d65db920d3cdfa145f89a2008bf5182 Mon Sep 17 00:00:00 2001 From: ansuz Date: Tue, 10 Mar 2020 09:18:36 -0400 Subject: [PATCH 1/2] downgrade an 'XXX' note to a 'TODO' --- www/common/sframe-common-file.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/common/sframe-common-file.js b/www/common/sframe-common-file.js index bca4fe233..0a9cf184f 100644 --- a/www/common/sframe-common-file.js +++ b/www/common/sframe-common-file.js @@ -158,7 +158,7 @@ define([ }); onError = function (e) { - // XXX if we included the max upload sizes in /api/config + // TODO if we included the max upload sizes in /api/config // then we could check if a file is too large without going to the server... queue.inProgress = false; queue.next(); From 45601068aef33569b84297a6b82085df7dd0c661 Mon Sep 17 00:00:00 2001 From: ansuz Date: Tue, 10 Mar 2020 09:19:35 -0400 Subject: [PATCH 2/2] lint compliance --- scripts/tests/test-rpc.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/scripts/tests/test-rpc.js b/scripts/tests/test-rpc.js index b5cc00465..ce432408c 100644 --- a/scripts/tests/test-rpc.js +++ b/scripts/tests/test-rpc.js @@ -718,12 +718,11 @@ nThen(function (w) { })); }).nThen(function (w) { oscar.roster.checkpoint(w(function (err) { - var hash = oscar.lastRosterCheckpointHash = oscar.roster.getLastCheckpointHash(); // FIXME bob should connect to this to avoid extra messages + oscar.lastRosterCheckpointHash = oscar.roster.getLastCheckpointHash(); // FIXME bob should connect to this to avoid extra messages if (!err) { return; } console.error("Checkpoint by an owner failed unexpectedly"); console.error(err); process.exit(1); - })); }).nThen(function (w) { alice.roster.remove([