From 1b97996ef8907726f12d3752faa4434df156d9ac Mon Sep 17 00:00:00 2001
From: ansuz <ansuz@transitiontech.ca>
Date: Thu, 7 Sep 2017 12:26:05 +0200
Subject: [PATCH 01/15] implement util.once

---
 www/common/common-util.js | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/www/common/common-util.js b/www/common/common-util.js
index 8cbde420c..e42a0249c 100644
--- a/www/common/common-util.js
+++ b/www/common/common-util.js
@@ -170,5 +170,15 @@ define([], function () {
         return parts[0];
     };
 
+    /* for wrapping async functions such that they can only be called once */
+    Util.once = function (f) {
+        var called;
+        return function () {
+            if (called) { return; }
+            called = true;
+            f.apply(this, Array.prototype.slice.call(arguments));
+        };
+    };
+
     return Util;
 });

From 15e24ebe4f331fd7770756fbcc0f32eb27f31638 Mon Sep 17 00:00:00 2001
From: ansuz <ansuz@transitiontech.ca>
Date: Thu, 7 Sep 2017 12:45:07 +0200
Subject: [PATCH 02/15] ui for hashtag picker

---
 bower.json                                    |   3 +-
 .../src/less2/include/alertify.less           |  15 +-
 .../src/less2/include/tokenfield.less         |  94 ++++++++++++
 www/common/common-interface.js                | 137 +++++++++++++++++-
 www/common/cryptpad-common.js                 |  16 ++
 5 files changed, 258 insertions(+), 7 deletions(-)
 create mode 100644 customize.dist/src/less2/include/tokenfield.less

diff --git a/bower.json b/bower.json
index 9c88d0033..cb8d01f07 100644
--- a/bower.json
+++ b/bower.json
@@ -41,6 +41,7 @@
     "bootstrap": "#v4.0.0-alpha.6",
     "diff-dom": "2.1.1",
     "nthen": "^0.1.5",
-    "open-sans-fontface": "^1.4.2"
+    "open-sans-fontface": "^1.4.2",
+    "bootstrap-tokenfield": "^0.12.1"
   }
 }
diff --git a/customize.dist/src/less2/include/alertify.less b/customize.dist/src/less2/include/alertify.less
index 8dd7fc0cb..f9f2c28b8 100644
--- a/customize.dist/src/less2/include/alertify.less
+++ b/customize.dist/src/less2/include/alertify.less
@@ -85,6 +85,20 @@
 
         .dialog {
             padding: 12px;
+/*
+            div.tokenfield {
+                .token {
+                    //border: 1px solid red;
+                    //color: red;
+                }
+
+                color: @colortheme_light-base;
+                background-color: @alertify-dialog-bg;
+
+                input[id$="tokenfield"][type="text"].token-input {
+                    background-color: @alertify-dialog-bg !important;
+                }
+            }*/
         }
 
         .dialog, .alert {
@@ -308,6 +322,5 @@
                 pointer-events: auto;
             }
         }
-
     }
 }
diff --git a/customize.dist/src/less2/include/tokenfield.less b/customize.dist/src/less2/include/tokenfield.less
new file mode 100644
index 000000000..2479e3330
--- /dev/null
+++ b/customize.dist/src/less2/include/tokenfield.less
@@ -0,0 +1,94 @@
+.tokenfield_main () {
+    .tokenfield {
+        .unselectable () {
+            -webkit-touch-callout: none;
+            -webkit-user-select: none;
+            -khtml-user-select: none;
+            -moz-user-select: none;
+            -ms-user-select: none;
+            user-select: none;
+        }
+
+        .unselectable();
+        height: auto;
+        min-height: 34px;
+        padding-bottom: 0px;
+        &.focus {
+            border-color: #66afe9;
+            outline: 0;
+            box-shadow: inset 0 1px 1px rgba(0, 0, 0, .075), 0 0 8px rgba(102, 175, 233, 0.6);
+        }
+        .token {
+            box-sizing: border-box;
+            border-radius: 3px;
+            display: inline-block;
+            border: 1px solid #d9d9d9;
+            background-color: #ededed;
+            white-space: nowrap;
+            margin: -1px 5px 5px 0;
+            vertical-align: center;
+            cursor: default;
+
+            color: #222;
+
+            &:hover {
+                border-color: #b9b9b9;
+            }
+            &.invalid {
+                background: none;
+                border: 1px solid transparent;
+                border-radius: 0;
+                border-bottom: 1px dotted #d9534f;
+            }
+            &.invalid.active {
+                background: #ededed;
+                border: 1px solid #ededed;
+                border-radius: 3px;
+            }
+            .token-label {
+                display: inline-block;
+                overflow: hidden;
+                text-overflow: ellipsis;
+                padding-left: 4px;
+                vertical-align: center;
+            }
+            .close {
+                font-family: Arial;
+                display: inline-block;
+                line-height: 100%;
+                font-size: 1.1em;
+                margin-left: 5px;
+                float: none;
+                height: 100%;
+                vertical-align: center;
+                padding-right: 4px;
+            }
+            &.active {
+                border-color: #52a8ec;
+                border-color: rgba(82, 168, 236, 0.8);
+            }
+            &.duplicate {
+                border-color: #ebccd1;
+            }
+        }
+        .token-input {
+            background: none;
+            width: 0%; //60px;
+            min-width: 60px;
+            border: 0;
+            padding: 0;
+            margin-bottom: 6px;
+            box-shadow: none;
+            max-width: 100%;
+            &:focus {
+                border-color: transparent;
+                outline: 0;
+                box-shadow: none;
+            }
+        }
+        &.disabled {
+            cursor: not-allowed;
+            background-color: #eeeeee;
+        }
+    }
+}
diff --git a/www/common/common-interface.js b/www/common/common-interface.js
index 745a2b5aa..a8122dcc6 100644
--- a/www/common/common-interface.js
+++ b/www/common/common-interface.js
@@ -7,9 +7,10 @@ define([
     '/common/notify.js',
     '/common/visible.js',
     '/common/tippy.min.js',
+    '/common/hyperscript.js',
+    '/bower_components/bootstrap-tokenfield/dist/bootstrap-tokenfield.js',
     'css!/common/tippy.css',
-], function ($, Messages, Util, AppConfig, Alertify, Notify, Visible, Tippy) {
-
+], function ($, Messages, Util, AppConfig, Alertify, Notify, Visible, Tippy, h) {
     var UI = {};
 
     /*
@@ -20,11 +21,17 @@ define([
     // set notification timeout
     Alertify._$$alertify.delay = AppConfig.notificationTimeout || 5000;
 
-    var findCancelButton = UI.findCancelButton = function () {
+    var findCancelButton = UI.findCancelButton = function (root) {
+        if (root) {
+            return $(root).find('button.cancel').last();
+        }
         return $('button.cancel').last();
     };
 
-    var findOKButton = UI.findOKButton = function () {
+    var findOKButton = UI.findOKButton = function (root) {
+        if (root) {
+            return $(root).find('button.ok').last();
+        }
         return $('button.ok').last();
     };
 
@@ -33,7 +40,6 @@ define([
             switch (e.which) {
                 case 27: // cancel
                     if (typeof(no) === 'function') { no(e); }
-                    no();
                     break;
                 case 13: // enter
                     if (typeof(yes) === 'function') { yes(e); }
@@ -363,5 +369,126 @@ define([
         }
     };
 
+    UI.tokenField = function (target) {
+        var t = {
+            element: target || h('input'),
+        };
+        var $t = t.tokenfield = $(t.element).tokenfield();
+        t.getTokens = function () {
+            return $t.tokenfield('getTokens').map(function (token) {
+                return token.value;
+            });
+        };
+
+        t.preventDuplicates = function (cb) {
+            $t.on('tokenfield:createtoken', function (ev) {
+                var val;
+                if (t.getTokens().some(function (t) {
+                    if (t === ev.attrs.value) { return ((val = t)); }
+                })) {
+                    ev.preventDefault();
+                    if (typeof(cb) === 'function') { cb(val); }
+                }
+            });
+            return t;
+        };
+
+        t.setTokens = function (tokens) {
+            $t.tokenfield('setTokens',
+                tokens.map(function (token) {
+                    return {
+                        value: token,
+                        label: token,
+                    };
+                }));
+        };
+
+        t.focus = function () {
+            var $temp = $t.closest('.tokenfield').find('.token-input');
+            $temp.css('width', '20%');
+            $t.tokenfield('focusInput', $temp[0]);
+        };
+
+        return t;
+    };
+
+    var dialog = UI.dialog = {};
+    dialog.okButton = function () {
+        return h('button.ok', { tabindex: '2', }, Messages.okButton);
+    };
+
+    dialog.cancelButton = function () {
+        return h('button.cancel', { tabindex: '1'}, Messages.cancelButton);
+    };
+
+    dialog.message = function (text) {
+        return h('p.message', text);
+    };
+
+    dialog.textInput = function (opt) {
+        return h('input', opt || {
+            placeholder: '',
+            type: 'text',
+            'class': 'cp-text-input',
+        });
+    };
+
+    dialog.nav = function (content) {
+        return h('nav', content || [
+            dialog.cancelButton(),
+            dialog.okButton(),
+        ]);
+    };
+
+    dialog.frame = function (content) {
+        return h('div.alertify', [
+            h('div.dialog', [
+                h('div', content),
+            ])
+        ]);
+    };
+
+    dialog.tagPrompt = function (tags, cb) {
+        var input = dialog.textInput();
+
+        var tagger = dialog.frame([
+            dialog.message('make some tags'), // TODO translate
+            input,
+            dialog.nav(),
+        ]);
+
+        var field = UI.tokenField(input).preventDuplicates(function (val) {
+            UI.warn('Duplicate tag: ' + val); // TODO translate
+        });
+
+        var close = Util.once(function () {
+            var $t = $(tagger).fadeOut(150, function () { $t.remove(); });
+        });
+
+        var listener = listenForKeys(function () {}, function () {
+            close();
+            stopListening(listener);
+        });
+
+        var CB = Util.once(cb);
+        findOKButton(tagger).click(function () {
+            var tokens = field.getTokens();
+            close();
+            CB(tokens);
+        });
+        findCancelButton(tagger).click(function () {
+            close();
+            CB(null);
+        });
+
+        // :(
+        setTimeout(function () {
+            field.setTokens(tags);
+            field.focus();
+        });
+
+        return tagger;
+    };
+
     return UI;
 });
diff --git a/www/common/cryptpad-common.js b/www/common/cryptpad-common.js
index 8b32f12d3..cd817583b 100644
--- a/www/common/cryptpad-common.js
+++ b/www/common/cryptpad-common.js
@@ -81,6 +81,8 @@ define([
     common.addTooltips = UI.addTooltips;
     common.clearTooltips = UI.clearTooltips;
     common.importContent = UI.importContent;
+    common.tokenField = UI.tokenField;
+    common.dialog = UI.dialog;
 
     // import common utilities for export
     common.find = Util.find;
@@ -1380,6 +1382,20 @@ define([
                 })
                 .click(prepareFeedback(type));
                 break;
+            case 'hashtag':
+                button = $('<button>', {
+                    'class': 'fa fa-hashtag',
+                })
+                .click(prepareFeedback(type))
+                .click(function () {
+                    // TODO fetch pad tags before presenting dialog to user
+                    var dialog = Cryptpad.dialog.tagPrompt([], function (tags) {
+                        if (!Array.isArray(tags)) { return; }
+                        console.error(tags);
+                        // TODO do something with the tags the user entered
+                    });
+                    document.body.appendChild(dialog);
+                });
             default:
                 button = $('<button>', {
                     'class': "fa fa-question",

From 263c2eb2c24f19adad6e3fc02febf8dba8f3d229 Mon Sep 17 00:00:00 2001
From: ansuz <ansuz@transitiontech.ca>
Date: Thu, 7 Sep 2017 14:17:43 +0200
Subject: [PATCH 03/15] fix overflowing title text

---
 customize.dist/src/less/toolbar.less | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/customize.dist/src/less/toolbar.less b/customize.dist/src/less/toolbar.less
index 9ff435277..96f0cbc03 100644
--- a/customize.dist/src/less/toolbar.less
+++ b/customize.dist/src/less/toolbar.less
@@ -630,7 +630,7 @@ body .cryptpad-toolbar {
         .title {
             font-size: 25px;
             vertical-align: middle;
-            line-height: 25px;
+            line-height: 48px; //25px;
             white-space: nowrap;
         }
         .pageTitle {

From 85003f7a2312b61f3b74da1d9f0d9ed4e09b0927 Mon Sep 17 00:00:00 2001
From: ansuz <ansuz@transitiontech.ca>
Date: Thu, 7 Sep 2017 14:21:54 +0200
Subject: [PATCH 04/15] lint compliance

---
 www/common/cryptpad-common.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/www/common/cryptpad-common.js b/www/common/cryptpad-common.js
index 0d491074b..502a1878d 100644
--- a/www/common/cryptpad-common.js
+++ b/www/common/cryptpad-common.js
@@ -1410,13 +1410,14 @@ define([
                 .click(prepareFeedback(type))
                 .click(function () {
                     // TODO fetch pad tags before presenting dialog to user
-                    var dialog = Cryptpad.dialog.tagPrompt([], function (tags) {
+                    var dialog = UI.dialog.tagPrompt([], function (tags) {
                         if (!Array.isArray(tags)) { return; }
                         console.error(tags);
                         // TODO do something with the tags the user entered
                     });
                     document.body.appendChild(dialog);
                 });
+                break;
             default:
                 button = $('<button>', {
                     'class': "fa fa-question",

From e8298f165ab9c5681b23346c11088bf9f085e4ae Mon Sep 17 00:00:00 2001
From: ansuz <ansuz@transitiontech.ca>
Date: Thu, 7 Sep 2017 16:35:24 +0200
Subject: [PATCH 05/15] only display first letter of name if user has no avatar

---
 www/common/cryptpad-common.js         | 4 ++--
 www/common/sframe-common-interface.js | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/www/common/cryptpad-common.js b/www/common/cryptpad-common.js
index 502a1878d..40dbee37a 100644
--- a/www/common/cryptpad-common.js
+++ b/www/common/cryptpad-common.js
@@ -1967,7 +1967,7 @@ define([
         };
         var $userAdmin = createDropdown(dropdownConfigUser);
 
-        var oldUrl;
+        var oldUrl = '';
         if (account && !config.static && store) {
             var $avatar = $userAdmin.find('.cp-dropdown-button-title');
             var updateButton = function (newName) {
@@ -1977,7 +1977,7 @@ define([
                 if (oldUrl === url) { return; }
                 oldUrl = url;
                 $avatar.html('');
-                common.displayAvatar($avatar, url, newName, function ($img) {
+                common.displayAvatar($avatar, url, newName || Messages.anonymous, function ($img) {
                     if ($img) {
                         $userAdmin.find('button').addClass('avatar');
                     }
diff --git a/www/common/sframe-common-interface.js b/www/common/sframe-common-interface.js
index 69060b3b1..0b38de654 100644
--- a/www/common/sframe-common-interface.js
+++ b/www/common/sframe-common-interface.js
@@ -374,7 +374,7 @@ define([
         var $displayName = $userAdmin.find('.'+displayNameCls);
 
         var $avatar = $userAdmin.find('.cp-dropdown-button-title');
-        var oldUrl;
+        var oldUrl = '';
         var updateButton = function () {
             var myData = metadataMgr.getUserData();
             if (!myData) { return; }
@@ -383,7 +383,7 @@ define([
             $displayName.text(newName || Messages.anonymous);
             if (accountName && oldUrl !== url) {
                 $avatar.html('');
-                UI.displayAvatar(Common, $avatar, url, newName, function ($img) {
+                UI.displayAvatar(Common, $avatar, url, newName || Messages.anonymous, function ($img) {
                     oldUrl = url;
                     if ($img) {
                         $userAdmin.find('button').addClass('cp-avatar');

From 352d504944b78e24da0f8ad23c36abcea2237e89 Mon Sep 17 00:00:00 2001
From: ansuz <ansuz@transitiontech.ca>
Date: Thu, 7 Sep 2017 16:39:20 +0200
Subject: [PATCH 06/15] avoid loading unnecessary files

---
 customize.dist/pages.js | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/customize.dist/pages.js b/customize.dist/pages.js
index 7deb07262..b26e036d0 100644
--- a/customize.dist/pages.js
+++ b/customize.dist/pages.js
@@ -1,11 +1,10 @@
 define([
     '/api/config',
     '/common/hyperscript.js',
-    '/common/cryptpad-common.js',
+    '/customize/messages.js',
     'jquery'
-], function (Config, h, Cryptpad, $) {
+], function (Config, h, Msg, $) {
     var Pages = {};
-    var Msg = Cryptpad.Messages;
     var urlArgs = Config.requireConf.urlArgs;
 
     var setHTML = function (e, html) {

From a6eb1444df897e499d575a77cf745df67009a392 Mon Sep 17 00:00:00 2001
From: ansuz <ansuz@transitiontech.ca>
Date: Thu, 7 Sep 2017 16:39:42 +0200
Subject: [PATCH 07/15] add loading screen markup to register and login

---
 customize.dist/pages.js | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/customize.dist/pages.js b/customize.dist/pages.js
index b26e036d0..ff5be71a6 100644
--- a/customize.dist/pages.js
+++ b/customize.dist/pages.js
@@ -437,7 +437,7 @@ define([
         ];
     };
 
-    var loadingScreen = function () {
+    var loadingScreen = Pages.loadingScreen = function () {
         return h('div#loading', 
             h('div.loadingContainer', [
                 h('img.cryptofist', {
@@ -450,6 +450,12 @@ define([
         );
     };
 
+    var hiddenLoader = function () {
+        var loader = loadingScreen();
+        loader.style.display = 'none';
+        return loader;
+    };
+
     Pages['/user/'] = Pages['/user/index.html'] = function () {
         return h('div#container');
     };
@@ -525,6 +531,7 @@ define([
             ]),
 
             infopageFooter(),
+            hiddenLoader(),
         ])];
     };
 
@@ -558,6 +565,7 @@ define([
                 ]),
             ]),
             infopageFooter(),
+            hiddenLoader(),
         ])];
     };
 

From fab6264ce6c0a27a242a460c0217ee9a216bc6e1 Mon Sep 17 00:00:00 2001
From: ansuz <ansuz@transitiontech.ca>
Date: Thu, 7 Sep 2017 16:41:11 +0200
Subject: [PATCH 08/15] use loading screen from pages.js

---
 www/common/common-interface.js | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/www/common/common-interface.js b/www/common/common-interface.js
index a8122dcc6..466c1aec2 100644
--- a/www/common/common-interface.js
+++ b/www/common/common-interface.js
@@ -7,10 +7,11 @@ define([
     '/common/notify.js',
     '/common/visible.js',
     '/common/tippy.min.js',
+    '/customize/pages.js',
     '/common/hyperscript.js',
     '/bower_components/bootstrap-tokenfield/dist/bootstrap-tokenfield.js',
     'css!/common/tippy.css',
-], function ($, Messages, Util, AppConfig, Alertify, Notify, Visible, Tippy, h) {
+], function ($, Messages, Util, AppConfig, Alertify, Notify, Visible, Tippy, Pages, h) {
     var UI = {};
 
     /*
@@ -171,7 +172,7 @@ define([
      */
     UI.spinner = function (parent) {
         var $target = $('<span>', {
-            'class': 'fa fa-spinner fa-pulse fa-4x fa-fw'
+            'class': 'fa fa-circle-o-notch fa-spin fa-4x fa-fw',
         }).hide();
 
         $(parent).append($target);
@@ -212,16 +213,15 @@ define([
             }
             $container = $loading.find('.loadingContainer');
         } else {
-            $loading = $('<div>', {id: LOADING});
-            $container = $('<div>', {'class': 'loadingContainer'});
-            if (!hideLogo) {
-                $container.append('<img class="cryptofist" src="/customize/cryptofist_small.png" />');
+            $loading = $(Pages.loadingScreen());
+            $container = $loading.find('.loadingContainer');
+            if (hideLogo) {
+                $loading.find('img').hide();
+            } else {
+                $loading.find('img').show();
             }
-            var $spinner = $('<div>', {'class': 'spinnerContainer'});
-            UI.spinner($spinner).show();
-            var $text = $('<p>').text(loadingText || Messages.loading);
-            $container.append($spinner).append($text);
-            $loading.append($container);
+            var $spinner = $loading.find('.spinnerContainer');
+            $spinner.show();
             $('body').append($loading);
         }
         if (Messages.tips && !hideTips) {

From 1958bca98491118a22abdcee8faacedaf4a4392f Mon Sep 17 00:00:00 2001
From: ansuz <ansuz@transitiontech.ca>
Date: Thu, 7 Sep 2017 16:48:17 +0200
Subject: [PATCH 09/15] restore hashing screen in login and register

---
 www/login/main.js    | 10 ++++++++--
 www/register/main.js | 10 ++++++++--
 2 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/www/login/main.js b/www/login/main.js
index 7d0a21036..ac4baf860 100644
--- a/www/login/main.js
+++ b/www/login/main.js
@@ -1,7 +1,10 @@
 define([
     'jquery',
     '/common/cryptpad-common.js',
-    '/common/login.js'
+    '/common/login.js',
+
+    'css!/bower_components/components-font-awesome/css/font-awesome.min.css',
+    'less!/customize/src/less/loading.less',
 ], function ($, Cryptpad, Login) {
     $(function () {
         var $main = $('#mainBlock');
@@ -72,7 +75,10 @@ define([
 
             // setTimeout 100ms to remove the keyboard on mobile devices before the loading screen pops up
             window.setTimeout(function () {
-                Cryptpad.addLoadingScreen({loadingText: Messages.login_hashing});
+                Cryptpad.addLoadingScreen({
+                    loadingText: Messages.login_hashing,
+                    hideTips: true,
+                });
                 // We need a setTimeout(cb, 0) otherwise the loading screen is only displayed after hashing the password
                 window.setTimeout(function () {
                     loginReady(function () {
diff --git a/www/register/main.js b/www/register/main.js
index f01a4ef8d..ce7c53242 100644
--- a/www/register/main.js
+++ b/www/register/main.js
@@ -4,6 +4,9 @@ define([
     '/common/cryptpad-common.js',
     '/common/test.js',
     '/common/credential.js', // preloaded for login.js
+
+    'css!/bower_components/components-font-awesome/css/font-awesome.min.css',
+    'less!/customize/src/less/loading.less',
 ], function ($, Login, Cryptpad, Test) {
     var Messages = Cryptpad.Messages;
 
@@ -128,7 +131,10 @@ define([
                 registering = true;
                 // setTimeout 100ms to remove the keyboard on mobile devices before the loading screen pops up
                 window.setTimeout(function () {
-                    Cryptpad.addLoadingScreen({loadingText: Messages.login_hashing});
+                    Cryptpad.addLoadingScreen({
+                        loadingText: Messages.login_hashing,
+                        hideTips: true,
+                    });
                     // We need a setTimeout(cb, 0) otherwise the loading screen is only displayed after hashing the password
                     window.setTimeout(function () {
                         Login.loginOrRegister(uname, passwd, true, function (err, result) {
@@ -193,7 +199,7 @@ define([
                             logMeIn(result);
                         });
                     }, 0);
-                }, 100);
+                }, 200);
             }, {
                 ok: Messages.register_writtenPassword,
                 cancel: Messages.register_cancel,

From ef30b0bc425cd64ec539bc1bd99c68acaf6d9d90 Mon Sep 17 00:00:00 2001
From: ansuz <ansuz@transitiontech.ca>
Date: Thu, 7 Sep 2017 16:50:06 +0200
Subject: [PATCH 10/15] contribute to z-index arms race

---
 customize.dist/src/less/loading.less | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/customize.dist/src/less/loading.less b/customize.dist/src/less/loading.less
index a9442d3cb..555b02ad8 100644
--- a/customize.dist/src/less/loading.less
+++ b/customize.dist/src/less/loading.less
@@ -3,7 +3,7 @@
 
 #loading {
     position: fixed;
-    z-index: 9999;
+    z-index: 9999999;
     top: 0px;
     bottom: 0px;
     left: 0px;

From bca9ba66cb180c58b3bc9c0765c83ecf2f207e4f Mon Sep 17 00:00:00 2001
From: ansuz <ansuz@transitiontech.ca>
Date: Thu, 7 Sep 2017 17:43:58 +0200
Subject: [PATCH 11/15] enforce a configurable minimum password length when
 registering

---
 customize.dist/application_config.js    |  2 ++
 customize.dist/translations/messages.js |  2 ++
 www/common/credential.js                |  7 +++++++
 www/common/login.js                     |  1 +
 www/register/main.js                    | 15 +++++++++++++--
 5 files changed, 25 insertions(+), 2 deletions(-)

diff --git a/customize.dist/application_config.js b/customize.dist/application_config.js
index 77962d8c4..e2ea77a02 100644
--- a/customize.dist/application_config.js
+++ b/customize.dist/application_config.js
@@ -49,6 +49,8 @@ define(function() {
         users.
     */
     config.loginSalt = '';
+    config.minimum_password_length = 8;
+
     config.badStateTimeout = 30000;
 
     config.applicationsIcon = {
diff --git a/customize.dist/translations/messages.js b/customize.dist/translations/messages.js
index cdc13df2b..b72d58ce0 100644
--- a/customize.dist/translations/messages.js
+++ b/customize.dist/translations/messages.js
@@ -409,6 +409,8 @@ define(function () {
     out.register_importRecent = "Import pad history (Recommended)";
     out.register_acceptTerms = "I accept <a href='/terms.html' tabindex='-1'>the terms of service</a>";
     out.register_passwordsDontMatch = "Passwords do not match!";
+    out.register_passwordTooShort = "Passwords must be at least {0} characters long.";
+
     out.register_mustAcceptTerms = "You must accept the terms of service.";
     out.register_mustRememberPass = "We cannot reset your password if you forget it. It's very important that you remember it! Please check the checkbox to confirm.";
 
diff --git a/www/common/credential.js b/www/common/credential.js
index 432cc0511..ffab595c1 100644
--- a/www/common/credential.js
+++ b/www/common/credential.js
@@ -5,6 +5,13 @@ define([
     var Cred = {};
     var Scrypt = window.scrypt;
 
+    Cred.MINIMUM_PASSWORD_LENGTH = typeof(AppConfig.minimum_password_length) === 'number'?
+        AppConfig.minimum_password_length: 8;
+
+    Cred.isLongEnoughPassword = function (passwd) {
+        return passwd.length >= Cred.MINIMUM_PASSWORD_LENGTH;
+    };
+
     var isString = Cred.isString = function (x) {
         return typeof(x) === 'string';
     };
diff --git a/www/common/login.js b/www/common/login.js
index fdb58c1d5..ceda207c6 100644
--- a/www/common/login.js
+++ b/www/common/login.js
@@ -88,6 +88,7 @@ define([
         // validate inputs
         if (!Cred.isValidUsername(uname)) { return void cb('INVAL_USER'); }
         if (!Cred.isValidPassword(passwd)) { return void cb('INVAL_PASS'); }
+        if (!Cred.isLongEnoughPassword(passwd)) { return void cb('PASS_TOO_SHORT'); }
 
         Cred.deriveFromPassphrase(uname, passwd, 128, function (bytes) {
             // results...
diff --git a/www/register/main.js b/www/register/main.js
index ce7c53242..86d0d9b14 100644
--- a/www/register/main.js
+++ b/www/register/main.js
@@ -7,7 +7,7 @@ define([
 
     'css!/bower_components/components-font-awesome/css/font-awesome.min.css',
     'less!/customize/src/less/loading.less',
-], function ($, Login, Cryptpad, Test) {
+], function ($, Login, Cryptpad, Test, Cred) {
     var Messages = Cryptpad.Messages;
 
     $(function () {
@@ -138,7 +138,8 @@ define([
                     // We need a setTimeout(cb, 0) otherwise the loading screen is only displayed after hashing the password
                     window.setTimeout(function () {
                         Login.loginOrRegister(uname, passwd, true, function (err, result) {
-                            var proxy = result.proxy;
+                            var proxy;
+                            if (result) { proxy = result.proxy; }
 
                             if (err) {
                                 switch (err) {
@@ -163,6 +164,16 @@ define([
                                             });
                                         });
                                         break;
+                                    case 'PASS_TOO_SHORT':
+                                        Cryptpad.removeLoadingScreen(function () {
+                                            var warning = Messages._getKey('register_passwordTooShort', [
+                                                Cred.MINIMUM_PASSWORD_LENGTH
+                                            ]);
+                                            Cryptpad.alert(warning, function () {
+                                                registering = false;
+                                            });
+                                        });
+                                        break;
                                     case 'ALREADY_REGISTERED':
                                         // logMeIn should reset registering = false
                                         Cryptpad.removeLoadingScreen(function () {

From 809b56625d38be05063f8264b6fa950acef77aa3 Mon Sep 17 00:00:00 2001
From: ansuz <ansuz@transitiontech.ca>
Date: Thu, 7 Sep 2017 18:54:58 +0200
Subject: [PATCH 12/15] refactor ui elements

---
 .../src/less2/include/alertify.less           |   6 +
 www/common/common-interface.js                | 287 ++++++++++--------
 www/common/toolbar2.js                        |  24 +-
 3 files changed, 162 insertions(+), 155 deletions(-)

diff --git a/customize.dist/src/less2/include/alertify.less b/customize.dist/src/less2/include/alertify.less
index f9f2c28b8..16688f179 100644
--- a/customize.dist/src/less2/include/alertify.less
+++ b/customize.dist/src/less2/include/alertify.less
@@ -65,6 +65,12 @@
         height: 100%;
         z-index: 99999;
 
+        .message {
+            h1, h2, h3, h4, h5, h6 {
+                color: @alertify-fg;
+            }
+        }
+
         h1, h2, h3 {
             margin-top: 0;
         }
diff --git a/www/common/common-interface.js b/www/common/common-interface.js
index 466c1aec2..609317ea3 100644
--- a/www/common/common-interface.js
+++ b/www/common/common-interface.js
@@ -56,21 +56,161 @@ define([
         $(window).off('keyup', handler);
     };
 
-    UI.alert = function (msg, cb, force) {
-        cb = cb || function () {};
-        if (force !== true) { msg = Util.fixHTML(msg); }
-        var close = function () {
-            findOKButton().click();
+    var dialog = UI.dialog = {};
+
+    dialog.selectable = function (value) {
+        var input = h('input', {
+            type: 'text',
+            readonly: 'readonly',
+        });
+        $(input).val(value).click(function () {
+            input.select();
+        });
+        return input;
+    };
+
+    dialog.okButton = function () {
+        return h('button.ok', { tabindex: '2', }, Messages.okButton);
+    };
+
+    dialog.cancelButton = function () {
+        return h('button.cancel', { tabindex: '1'}, Messages.cancelButton);
+    };
+
+    dialog.message = function (text) {
+        return h('p.message', text);
+    };
+
+    dialog.textInput = function (opt) {
+        return h('input', opt || {
+            placeholder: '',
+            type: 'text',
+            'class': 'cp-text-input',
+        });
+    };
+
+    dialog.nav = function (content) {
+        return h('nav', content || [
+            dialog.cancelButton(),
+            dialog.okButton(),
+        ]);
+    };
+
+    dialog.frame = function (content) {
+        return h('div.alertify', [
+            h('div.dialog', [
+                h('div', content),
+            ])
+        ]);
+    };
+
+    UI.tokenField = function (target) {
+        var t = {
+            element: target || h('input'),
         };
-        var keyHandler = listenForKeys(close, close);
-        Alertify
-            .okBtn(Messages.okButton || 'OK')
-            .alert(msg, function (ev) {
-                cb(ev);
-                stopListening(keyHandler);
+        var $t = t.tokenfield = $(t.element).tokenfield();
+        t.getTokens = function () {
+            return $t.tokenfield('getTokens').map(function (token) {
+                return token.value;
             });
-        window.setTimeout(function () {
-            findOKButton().focus();
+        };
+
+        t.preventDuplicates = function (cb) {
+            $t.on('tokenfield:createtoken', function (ev) {
+                var val;
+                if (t.getTokens().some(function (t) {
+                    if (t === ev.attrs.value) { return ((val = t)); }
+                })) {
+                    ev.preventDefault();
+                    if (typeof(cb) === 'function') { cb(val); }
+                }
+            });
+            return t;
+        };
+
+        t.setTokens = function (tokens) {
+            $t.tokenfield('setTokens',
+                tokens.map(function (token) {
+                    return {
+                        value: token,
+                        label: token,
+                    };
+                }));
+        };
+
+        t.focus = function () {
+            var $temp = $t.closest('.tokenfield').find('.token-input');
+            $temp.css('width', '20%');
+            $t.tokenfield('focusInput', $temp[0]);
+        };
+
+        return t;
+    };
+
+    dialog.tagPrompt = function (tags, cb) {
+        var input = dialog.textInput();
+
+        var tagger = dialog.frame([
+            dialog.message('make some tags'), // TODO translate
+            input,
+            dialog.nav(),
+        ]);
+
+        var field = UI.tokenField(input).preventDuplicates(function (val) {
+            UI.warn('Duplicate tag: ' + val); // TODO translate
+        });
+
+        var close = Util.once(function () {
+            var $t = $(tagger).fadeOut(150, function () { $t.remove(); });
+        });
+
+        var listener = listenForKeys(function () {}, function () {
+            close();
+            stopListening(listener);
+        });
+
+        var CB = Util.once(cb);
+        findOKButton(tagger).click(function () {
+            var tokens = field.getTokens();
+            close();
+            CB(tokens);
+        });
+        findCancelButton(tagger).click(function () {
+            close();
+            CB(null);
+        });
+
+        // :(
+        setTimeout(function () {
+            field.setTokens(tags);
+            field.focus();
+        });
+
+        return tagger;
+    };
+
+    UI.alert = function (msg, cb, force) {
+        cb = cb || function () {};
+        if (typeof(msg) === 'string' && force !== true) {
+            msg = Util.fixHTML(msg);
+        }
+        var ok = dialog.okButton();
+        var frame = dialog.frame([
+            dialog.message(msg),
+            dialog.nav(ok),
+        ]);
+
+        var listener;
+        var close = Util.once(function () {
+            $(frame).fadeOut(150, function () { $(this).remove(); });
+            stopListening(listener);
+        });
+        listener = listenForKeys(close, close);
+        var $ok = $(ok).click(close);
+
+        document.body.appendChild(frame);
+        setTimeout(function () {
+            $ok.focus();
             if (typeof(UI.notify) === 'function') {
                 UI.notify();
             }
@@ -369,126 +509,5 @@ define([
         }
     };
 
-    UI.tokenField = function (target) {
-        var t = {
-            element: target || h('input'),
-        };
-        var $t = t.tokenfield = $(t.element).tokenfield();
-        t.getTokens = function () {
-            return $t.tokenfield('getTokens').map(function (token) {
-                return token.value;
-            });
-        };
-
-        t.preventDuplicates = function (cb) {
-            $t.on('tokenfield:createtoken', function (ev) {
-                var val;
-                if (t.getTokens().some(function (t) {
-                    if (t === ev.attrs.value) { return ((val = t)); }
-                })) {
-                    ev.preventDefault();
-                    if (typeof(cb) === 'function') { cb(val); }
-                }
-            });
-            return t;
-        };
-
-        t.setTokens = function (tokens) {
-            $t.tokenfield('setTokens',
-                tokens.map(function (token) {
-                    return {
-                        value: token,
-                        label: token,
-                    };
-                }));
-        };
-
-        t.focus = function () {
-            var $temp = $t.closest('.tokenfield').find('.token-input');
-            $temp.css('width', '20%');
-            $t.tokenfield('focusInput', $temp[0]);
-        };
-
-        return t;
-    };
-
-    var dialog = UI.dialog = {};
-    dialog.okButton = function () {
-        return h('button.ok', { tabindex: '2', }, Messages.okButton);
-    };
-
-    dialog.cancelButton = function () {
-        return h('button.cancel', { tabindex: '1'}, Messages.cancelButton);
-    };
-
-    dialog.message = function (text) {
-        return h('p.message', text);
-    };
-
-    dialog.textInput = function (opt) {
-        return h('input', opt || {
-            placeholder: '',
-            type: 'text',
-            'class': 'cp-text-input',
-        });
-    };
-
-    dialog.nav = function (content) {
-        return h('nav', content || [
-            dialog.cancelButton(),
-            dialog.okButton(),
-        ]);
-    };
-
-    dialog.frame = function (content) {
-        return h('div.alertify', [
-            h('div.dialog', [
-                h('div', content),
-            ])
-        ]);
-    };
-
-    dialog.tagPrompt = function (tags, cb) {
-        var input = dialog.textInput();
-
-        var tagger = dialog.frame([
-            dialog.message('make some tags'), // TODO translate
-            input,
-            dialog.nav(),
-        ]);
-
-        var field = UI.tokenField(input).preventDuplicates(function (val) {
-            UI.warn('Duplicate tag: ' + val); // TODO translate
-        });
-
-        var close = Util.once(function () {
-            var $t = $(tagger).fadeOut(150, function () { $t.remove(); });
-        });
-
-        var listener = listenForKeys(function () {}, function () {
-            close();
-            stopListening(listener);
-        });
-
-        var CB = Util.once(cb);
-        findOKButton(tagger).click(function () {
-            var tokens = field.getTokens();
-            close();
-            CB(tokens);
-        });
-        findCancelButton(tagger).click(function () {
-            close();
-            CB(null);
-        });
-
-        // :(
-        setTimeout(function () {
-            field.setTokens(tags);
-            field.focus();
-        });
-
-        return tagger;
-    };
-
     return UI;
 });
diff --git a/www/common/toolbar2.js b/www/common/toolbar2.js
index e49a490ab..c79a9c233 100644
--- a/www/common/toolbar2.js
+++ b/www/common/toolbar2.js
@@ -516,29 +516,11 @@ define([
             $('<h3>').text(Messages.fileEmbedTitle).appendTo($content);
             var $script = $('<p>').text(Messages.fileEmbedScript).appendTo($content);
             $('<br>').appendTo($script);
-            var scriptId = uid();
-            $('<input>', {
-                type: 'text',
-                id: scriptId,
-                readonly: 'readonly',
-                value: Cryptpad.getMediatagScript(),
-            }).appendTo($script);
+            $script.append(Cryptpad.dialog.selectable(Cryptpad.getMediatagScript()));
             var $tag = $('<p>').text(Messages.fileEmbedTag).appendTo($content);
             $('<br>').appendTo($tag);
-            var tagId = uid();
-            $('<input>', {
-                type:'text',
-                id: tagId,
-                readonly:'readonly',
-                value:Cryptpad.getMediatagFromHref(url),
-            }).appendTo($tag);
-            Cryptpad.alert($content.html(), null, true);
-            $('#'+scriptId).click(function () {
-                this.select();
-            });
-            $('#'+tagId).click(function () {
-                this.select();
-            });
+            $tag.append(Cryptpad.dialog.selectable(Cryptpad.getMediatagFromHref(url)));
+            Cryptpad.alert($content[0], null, true);
         });
 
         toolbar.$leftside.append($shareBlock);

From fe2454ba31855a25afc851816f5b3b53911d478f Mon Sep 17 00:00:00 2001
From: Caleb James DeLisle <cjd@cjdns.fr>
Date: Fri, 8 Sep 2017 10:39:45 +0200
Subject: [PATCH 13/15] add the ability to filter for old pads using
 pinneddata.js

---
 pinneddata.js | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/pinneddata.js b/pinneddata.js
index 2ecf8605d..0c45228fd 100644
--- a/pinneddata.js
+++ b/pinneddata.js
@@ -117,8 +117,17 @@ nThen((waitFor) => {
     });
 }).nThen(() => {
     if (process.argv.indexOf('--unpinned') > -1) {
+        const ot = process.argv.indexOf('--olderthan');
+        let before = 0;
+        if (ot > -1) {
+            before = new Date(process.argv[ot+1]);
+            if (isNaN(before)) {
+                throw new Error('--olderthan error [' + process.argv[ot+1] + '] not a valid date');
+            }
+        }
         Object.keys(dsFileStats).forEach((f) => {
             if (!(f in pinned)) {
+                if ((+dsFileStats[f].mtime) >= before) { return; }
                 console.log("./datastore/" + f.slice(0,2) + "/" + f + ".ndjson " +
                     dsFileStats[f].size + " " + (+dsFileStats[f].mtime));
             }

From 684a12ce2ed090ebeb046179acbe0c7afd022c64 Mon Sep 17 00:00:00 2001
From: Caleb James DeLisle <cjd@cjdns.fr>
Date: Fri, 8 Sep 2017 11:35:45 +0200
Subject: [PATCH 14/15] Update pinneddata to work on blobs too

---
 pinneddata.js | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/pinneddata.js b/pinneddata.js
index 0c45228fd..d7848c7df 100644
--- a/pinneddata.js
+++ b/pinneddata.js
@@ -81,6 +81,7 @@ nThen((waitFor) => {
         sema.take((returnAfter) => {
             Fs.stat(f, waitFor(returnAfter((err, st) => {
                 if (err) { throw err; }
+                st.filename = f;
                 dsFileStats[f.replace(/^.*\/([^\/\.]*)(\.ndjson)?$/, (all, a) => (a))] = st;
             })));
         });
@@ -118,18 +119,27 @@ nThen((waitFor) => {
 }).nThen(() => {
     if (process.argv.indexOf('--unpinned') > -1) {
         const ot = process.argv.indexOf('--olderthan');
-        let before = 0;
+        let before = Infinity;
         if (ot > -1) {
             before = new Date(process.argv[ot+1]);
             if (isNaN(before)) {
                 throw new Error('--olderthan error [' + process.argv[ot+1] + '] not a valid date');
             }
         }
+        const bot = process.argv.indexOf('--blobsolderthan');
+        let blobsbefore = before;
+        if (bot > -1) {
+            blobsbefore = new Date(process.argv[bot+1]);
+            if (isNaN(blobsbefore)) {
+                throw new Error('--blobsolderthan error [' + process.argv[bot+1] + '] not a valid date');
+            }
+        }
         Object.keys(dsFileStats).forEach((f) => {
             if (!(f in pinned)) {
-                if ((+dsFileStats[f].mtime) >= before) { return; }
-                console.log("./datastore/" + f.slice(0,2) + "/" + f + ".ndjson " +
-                    dsFileStats[f].size + " " + (+dsFileStats[f].mtime));
+                const isBlob = dsFileStats[f].filename.indexOf('.ndjson') === -1;
+                if ((+dsFileStats[f].mtime) >= ((isBlob) ? blobsbefore : before)) { return; }
+                console.log(dsFileStats[f].filename + " " + dsFileStats[f].size + " " +
+                    (+dsFileStats[f].mtime));
             }
         });
     } else {

From fc069dac4840029008273dc937f08a0127d900ae Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Fri, 8 Sep 2017 16:21:12 +0200
Subject: [PATCH 15/15] Ask the user before loading the template picker

---
 customize.dist/translations/messages.fr.js |  1 +
 customize.dist/translations/messages.js    |  1 +
 www/common/sframe-common-interface.js      | 48 +++++++++++++---------
 www/common/sframe-common-outer.js          |  4 ++
 www/common/sframe-protocol.js              |  2 +
 5 files changed, 37 insertions(+), 19 deletions(-)

diff --git a/customize.dist/translations/messages.fr.js b/customize.dist/translations/messages.fr.js
index 35beb1f02..ad40a7989 100644
--- a/customize.dist/translations/messages.fr.js
+++ b/customize.dist/translations/messages.fr.js
@@ -129,6 +129,7 @@ define(function () {
     out.saveTemplatePrompt = "Choisir un titre pour ce modèle";
     out.templateSaved = "Modèle enregistré !";
     out.selectTemplate = "Sélectionner un modèle ou appuyer sur Échap";
+    out.useTemplate = "Vous posséder des modèles pour ce type de pad, souhaitez-vous en utiliser un?";
 
     out.previewButtonTitle = "Afficher ou cacher la prévisualisation de Markdown";
 
diff --git a/customize.dist/translations/messages.js b/customize.dist/translations/messages.js
index b72d58ce0..5415ae147 100644
--- a/customize.dist/translations/messages.js
+++ b/customize.dist/translations/messages.js
@@ -131,6 +131,7 @@ define(function () {
     out.saveTemplatePrompt = "Choose a title for the template";
     out.templateSaved = "Template saved!";
     out.selectTemplate = "Select a template or press escape";
+    out.useTemplate = "You have available templates for that type of pad. Do you want to use one?";
 
     out.previewButtonTitle = "Display or hide the Markdown preview mode";
 
diff --git a/www/common/sframe-common-interface.js b/www/common/sframe-common-interface.js
index 0b38de654..649e55916 100644
--- a/www/common/sframe-common-interface.js
+++ b/www/common/sframe-common-interface.js
@@ -442,27 +442,37 @@ define([
     UI.openTemplatePicker = function (common) {
         var metadataMgr = common.getMetadataMgr();
         var type = metadataMgr.getMetadataLazy().type;
-        var first = true; // We can only pick a template once (for a new document)
-        var fileDialogCfg = {
-            onSelect: function (data) {
-                if (data.type === type && first) {
-                    Cryptpad.addLoadingScreen({hideTips: true});
-                    var sframeChan = common.getSframeChannel();
-                    sframeChan.query('Q_TEMPLATE_USE', data.href, function () {
-                        first = false;
-                        Cryptpad.removeLoadingScreen();
-                        common.feedback('TEMPLATE_USED');
-                    });
-                    return;
+        var sframeChan = common.getSframeChannel();
+
+        var onConfirm = function (yes) {
+            if (!yes) { return; }
+            var first = true; // We can only pick a template once (for a new document)
+            var fileDialogCfg = {
+                onSelect: function (data) {
+                    if (data.type === type && first) {
+                        Cryptpad.addLoadingScreen({hideTips: true});
+                        sframeChan.query('Q_TEMPLATE_USE', data.href, function () {
+                            first = false;
+                            Cryptpad.removeLoadingScreen();
+                            common.feedback('TEMPLATE_USED');
+                        });
+                        return;
+                    }
                 }
-            }
-        };
-        common.initFilePicker(common, fileDialogCfg);
-        var pickerCfg = {
-            types: [type],
-            where: ['template']
+            };
+            common.initFilePicker(fileDialogCfg);
+            var pickerCfg = {
+                types: [type],
+                where: ['template']
+            };
+            common.openFilePicker(pickerCfg);
         };
-        common.openFilePicker(common, pickerCfg);
+
+        sframeChan.query("Q_TEMPLATE_EXIST", type, function (err, data) {
+            if (data) {
+                Cryptpad.confirm(Messages.useTemplate, onConfirm);
+            }
+        });
     };
 
     return UI;
diff --git a/www/common/sframe-common-outer.js b/www/common/sframe-common-outer.js
index df4259dff..79bc868f7 100644
--- a/www/common/sframe-common-outer.js
+++ b/www/common/sframe-common-outer.js
@@ -297,6 +297,10 @@ define([
             sframeChan.on('Q_TEMPLATE_USE', function (href, cb) {
                 Cryptpad.useTemplate(href, Cryptget, cb);
             });
+            sframeChan.on('Q_TEMPLATE_EXIST', function (type, cb) {
+                var hasTemplate = Cryptpad.listTemplates(type).length > 0;
+                cb(hasTemplate);
+            });
 
             CpNfOuter.start({
                 sframeChan: sframeChan,
diff --git a/www/common/sframe-protocol.js b/www/common/sframe-protocol.js
index 9c79b1495..d27a0a77a 100644
--- a/www/common/sframe-protocol.js
+++ b/www/common/sframe-protocol.js
@@ -104,6 +104,8 @@ define({
 
     // Template picked, replace the content of the pad
     'Q_TEMPLATE_USE': true,
+    // Check if we have template(s) for the selected pad type
+    'Q_TEMPLATE_EXIST': true,
 
     // File upload queries and events
     'Q_UPLOAD_FILE': true,