a bit of cleanup, bug fixes, and lint compliance

www/common/common-hash.js

@@ -477,7 +477,7 @@ Version 1
     // XXX consider putting Block functions in /common/outer/login-block.js
     Hash.createBlockHash = function (href, key) {
         if (typeof(href) !== 'string') { return; }
-        if (!key instanceof Uint8Array) { return; }
+        if (!(key instanceof Uint8Array)) { return; }
 
         // TODO verify inputs
         try { return href + '#' + Nacl.util.encodeBase64(key); }

www/common/common-util.js

@@ -139,7 +139,6 @@ define([], function () {
 
     // given a path, asynchronously return an arraybuffer
     Util.fetch = function (src, cb) {
-        var done = false;
         var CB = Util.once(cb);
 
         var xhr = new XMLHttpRequest();

www/common/cryptpad-common.js

@@ -897,7 +897,6 @@ define([
 
         }).nThen(function (waitFor) {
             var blockHash = LocalStore.getBlockHash();
-
             if (blockHash) {
                 console.log(blockHash);
                 var parsed = Hash.parseBlockHash(blockHash);
@@ -922,9 +921,6 @@ define([
                         return void console.error("failed to decrypt or decode block content");
                     }
                 }));
-            } else {
-                // XXX debugging
-                console.error("NO BLOCK HASH");
             }
         }).nThen(function (waitFor) {
             // XXX debugging

www/common/outer/local-store.js

@@ -63,7 +63,7 @@ define([
     };
 
     LocalStore.setBlockHash = function (hash) {
-        LocalStorage[Constants.blockHashKey] = hash;
+        localStorage[Constants.blockHashKey] = hash;
     };
 
     LocalStore.getAccountName = function () {

www/settings/inner.js

@@ -411,13 +411,13 @@ define([
                 cb (obj);
             });
         };
-
+/*
         var removeBlock = function (data, cb) {
             sframeChan.query('Q_REMOVE_LOGIN_BLOCK', data, function (err, obj) {
                 if (err || obj.error) { return void cb ({error: err || obj.error}); }
                 cb (obj);
             });
-        };
+        };*/
 
 
         // XXX
@@ -437,9 +437,10 @@ define([
                 console.log(Block.getBlockHash(keys));
 
                 return;
+                /*
                 removeBlock(Block.remove(keys), function (err, obj) {
                     console.log(err, obj);
-                });
+                });*/
             });
         }