From bbf7ed3827cf42d68ff978d497a48d30ed06c690 Mon Sep 17 00:00:00 2001
From: ansuz <ansuz@transitiontech.ca>
Date: Fri, 8 Sep 2017 12:24:20 +0200
Subject: [PATCH] refactor drive to use dialog.selectable()

fix class on alertify-like boxes
---
 www/common/common-interface.js | 39 ++++++++++++++++++++++++++++------
 www/drive/main.js              | 29 +++++++++++--------------
 2 files changed, 44 insertions(+), 24 deletions(-)

diff --git a/www/common/common-interface.js b/www/common/common-interface.js
index 609317ea3..87a24df5c 100644
--- a/www/common/common-interface.js
+++ b/www/common/common-interface.js
@@ -58,11 +58,28 @@ define([
 
     var dialog = UI.dialog = {};
 
-    dialog.selectable = function (value) {
-        var input = h('input', {
+    var merge = function (a, b) {
+        var c = {};
+        if (a) {
+            Object.keys(a).forEach(function (k) {
+                c[k] = a[k];
+            });
+        }
+        if (b) {
+            Object.keys(b).forEach(function (k) {
+                c[k] = b[k];
+            });
+        }
+        return c;
+    };
+
+    dialog.selectable = function (value, opt) {
+        var attrs = merge({
             type: 'text',
             readonly: 'readonly',
-        });
+        }, opt);
+
+        var input = h('input', attrs);
         $(input).val(value).click(function () {
             input.select();
         });
@@ -78,7 +95,7 @@ define([
     };
 
     dialog.message = function (text) {
-        return h('p.message', text);
+        return h('p.msg', text);
     };
 
     dialog.textInput = function (opt) {
@@ -191,12 +208,20 @@ define([
 
     UI.alert = function (msg, cb, force) {
         cb = cb || function () {};
-        if (typeof(msg) === 'string' && force !== true) {
-            msg = Util.fixHTML(msg);
+
+        var message;
+        if (typeof(msg) === 'string') {
+            // sanitize
+            if (!force) { msg = Util.fixHTML(msg); }
+            message = dialog.message();
+            message.innerHTML = msg;
+        } else {
+            message = dialog.message(msg);
         }
+
         var ok = dialog.okButton();
         var frame = dialog.frame([
-            dialog.message(msg),
+            message,
             dialog.nav(ok),
         ]);
 
diff --git a/www/drive/main.js b/www/drive/main.js
index b0d90b01b..90c5854f3 100644
--- a/www/drive/main.js
+++ b/www/drive/main.js
@@ -2339,9 +2339,9 @@ define([
             $('<br>').appendTo($d);
             if (!ro) {
                 $('<label>', {'for': 'propLink'}).text(Messages.editShare).appendTo($d);
-                $('<input>', {'id': 'propLink', 'readonly': 'readonly', 'value': base + data.href})
-                .click(function () { $(this).select(); })
-                .appendTo($d);
+                $d.append(Cryptpad.dialog.selectable(base + data.href, {
+                    id: 'propLink',
+                }));
             }
 
             var parsed = Cryptpad.parsePadUrl(data.href);
@@ -2349,9 +2349,9 @@ define([
                 var roLink = ro ? base + data.href : getReadOnlyUrl(el);
                 if (roLink) {
                     $('<label>', {'for': 'propROLink'}).text(Messages.viewShare).appendTo($d);
-                    $('<input>', {'id': 'propROLink', 'readonly': 'readonly', 'value': roLink})
-                    .click(function () { $(this).select(); })
-                    .appendTo($d);
+                    $d.append(Cryptpad.dialog.selectable(roLink, {
+                        id: 'propROLink',
+                    }));
                 }
             }
 
@@ -2369,20 +2369,17 @@ define([
                         return void cb(void 0, $d);
                     }
                     var KB = Cryptpad.bytesToKilobytes(bytes);
+
+                    var formatted = Messages._getKey('formattedKB', [KB]);
                     $('<br>').appendTo($d);
 
                     $('<label>', {
                         'for': 'size'
                     }).text(Messages.fc_sizeInKilobytes).appendTo($d);
 
-                    $('<input>', {
+                    $d.append(Cryptpad.dialog.selectable(formatted, {
                         id: 'size',
-                        readonly: 'readonly',
-                        value: KB + 'KB',
-                    })
-                    .click(function () { $(this).select(); })
-                    .appendTo($d);
-
+                    }));
                     cb(void 0, $d);
                 });
             } else {
@@ -2438,8 +2435,7 @@ define([
                 var el = filesOp.find(paths[0].path);
                 getProperties(el, function (e, $prop) {
                     if (e) { return void logError(e); }
-                    Cryptpad.alert('', undefined, true);
-                    $('.alertify .msg').html("").append($prop);
+                    Cryptpad.alert($prop[0], undefined, true);
                 });
             }
             module.hideMenu();
@@ -2490,8 +2486,7 @@ define([
                 var el = filesOp.find(paths[0].path);
                 getProperties(el, function (e, $prop) {
                     if (e) { return void logError(e); }
-                    Cryptpad.alert('', undefined, true);
-                    $('.alertify .msg').html("").append($prop);
+                    Cryptpad.alert($prop[0], undefined, true);
                 });
             }
             module.hideMenu();