From b3e225cb3b94ee32c4a9856af3263bbb866c3d8c Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Wed, 12 Jul 2017 14:30:28 +0200
Subject: [PATCH] Replace spinner by text and fix mobile UI

---
 customize.dist/src/less/toolbar.less       |  93 +++++++----
 customize.dist/translations/messages.fr.js |   1 +
 customize.dist/translations/messages.js    |   1 +
 www/common/toolbar2.js                     | 170 ++++-----------------
 www/drive/file.less                        |   6 +
 www/drive/main.js                          |   2 +-
 6 files changed, 104 insertions(+), 169 deletions(-)

diff --git a/customize.dist/src/less/toolbar.less b/customize.dist/src/less/toolbar.less
index 58fece5a2..85207d245 100644
--- a/customize.dist/src/less/toolbar.less
+++ b/customize.dist/src/less/toolbar.less
@@ -302,8 +302,8 @@ body .cryptpad-toolbar {
     z-index: 9001;
 
     .dropdown-bar {
-        height: 100%;
-        display: inline-block;
+        //height: 100%;
+        //display: inline-block;
         button {
             height: 100%;
             border-radius: 0;
@@ -620,6 +620,32 @@ body .cryptpad-toolbar {
     }
 }
 
+.app-slide {
+    @media screen and (max-width: @media-medium-screen) {
+        .cryptpad-toolbar-leftside {
+            flex-flow: row wrap;
+            width: 175px;
+            height: auto;
+            .cryptpad-spinner { order: 0; }
+        }
+        .cryptpad-toolbar-rightside {
+            height: 2*@toolbar-line-height;
+        }
+    }
+    @media screen and (max-width: 320px) {
+        .cryptpad-toolbar-leftside {
+            flex-flow: row wrap;
+            width: 175px;
+            height: auto;
+            padding-top: @toolbar-line-height;
+            .cryptpad-spinner { order: 0; }
+        }
+        .cryptpad-toolbar-rightside {
+            height: auto;
+        }
+    }
+}
+
 .cryptpad-toolbar-top {
     display: flex;
     flex-flow: row;
@@ -727,7 +753,6 @@ body .cryptpad-toolbar {
         &:hover {
             background-color: rgba(0,0,0,0.3);
         }
-        order: 2;
         text-align: center;
         font-size: 32px;
         margin-left: 10px;
@@ -785,10 +810,14 @@ body .cryptpad-toolbar {
     }
     .cryptpad-user {
         height: 100%;
-        display: inline-block;
+        display: inline-flex;
         order: 5;
         line-height: @toolbar-top-height;
         color: white;
+        .cryptpad-upgrade { order: 1; }
+        .cryptpad-new { order: 2; }
+        .cryptpad-user-dropdown { order: 3; }
+        .cryptpad-backup { order: 4; }
         &> * {
             display: inline-block;
             height: 100%;
@@ -837,6 +866,14 @@ body .cryptpad-toolbar {
                 }
             }
         }
+        p.accountData {
+            &> span {
+                font-weight: bold;
+                span {
+                    font-weight: normal;
+                }
+            }
+        }
         .cryptpad-backup {
             margin: 0;
             border-radius: 0;
@@ -848,12 +885,14 @@ body .cryptpad-toolbar {
     }
 }
 .cryptpad-toolbar-leftside {
-    height: @toolbar-line-height;
+    //height: @toolbar-line-height;
     &:empty {
         height: 0;
     }
     float: left;
-    margin-bottom: -1px;
+    display: inline-flex;
+    align-items: center;
+    //margin-bottom: -1px;
     .cryptpad-dropdown-users {
         pre {
             /* needed for ckeditor */
@@ -869,17 +908,22 @@ body .cryptpad-toolbar {
     .dropdown-bar-content {
         margin-top: -1px;
     }
-    .limit-container a {
-        height: 26px;
-        margin: 3px 0;
-        line-height: 26px;
-        padding: 0 5px;
-        box-sizing: border-box;
-        border: 1px solid transparent;
-        font-size: 14px;
-        &:hover {
-            text-decoration: none;
-        }
+
+    & > span {
+        height: @toolbar-line-height;
+    }
+
+    #userButtons { order: 1; }
+    .shareButton { order: 2; }
+    .cryptpad-spinner { order: 3; }
+
+    #userButtons button {
+        width: 125px;
+        text-align: center;
+    }
+    .shareButton button {
+        width: 50px;
+        text-align: center;
     }
 }
 .cryptpad-toolbar-rightside {
@@ -986,11 +1030,12 @@ body .cryptpad-toolbar {
     }
 }
 .cryptpad-spinner {
-    line-height: @toolbar-top-height;
+    line-height: @toolbar-line-height;
+    padding: 0 20px;
     &> span.fa {
         height: 20px;
         width: 20px;
-        margin: 8px;
+        //margin: 8px;
         line-height: 20px;
         font-size: 20px;
         text-align: center;
@@ -1001,16 +1046,6 @@ body .cryptpad-toolbar {
     font-weight: bold;
     text-transform: uppercase;
 }
-.cryptpad-user {
-    p.accountData {
-        &> span {
-            font-weight: bold;
-            span {
-                font-weight: normal;
-            }
-        }
-    }
-}
 .cryptpad-dropdown-share {
     a {
         .fa {
diff --git a/customize.dist/translations/messages.fr.js b/customize.dist/translations/messages.fr.js
index e4f69ec45..112a0dc0b 100644
--- a/customize.dist/translations/messages.fr.js
+++ b/customize.dist/translations/messages.fr.js
@@ -37,6 +37,7 @@ define(function () {
     out.disconnected = 'Déconnecté';
     out.synchronizing = 'Synchronisation';
     out.reconnecting = 'Reconnexion...';
+    out.typing = "Édition";
     out.lag = 'Latence';
     out.readonly = 'Lecture seule';
     out.anonymous = "Anonyme";
diff --git a/customize.dist/translations/messages.js b/customize.dist/translations/messages.js
index 27495077f..bbb6f22e1 100644
--- a/customize.dist/translations/messages.js
+++ b/customize.dist/translations/messages.js
@@ -41,6 +41,7 @@ define(function () {
     out.disconnected = 'Disconnected';
     out.synchronizing = 'Synchronizing';
     out.reconnecting = 'Reconnecting...';
+    out.typing = "Typing";
     out.lag = 'Lag';
     out.readonly = 'Read only';
     out.anonymous = "Anonymous";
diff --git a/www/common/toolbar2.js b/www/common/toolbar2.js
index 225f18fd2..d81a06624 100644
--- a/www/common/toolbar2.js
+++ b/www/common/toolbar2.js
@@ -29,12 +29,9 @@ define([
     // Top parts
     var USER_CLS = Bar.constants.userAdmin = "cryptpad-user";
     var SPINNER_CLS = Bar.constants.spinner = 'cryptpad-spinner';
-    var STATE_CLS = Bar.constants.state = 'cryptpad-state';
-    var LAG_CLS = Bar.constants.lag = 'cryptpad-lag';
     var LIMIT_CLS = Bar.constants.lag = 'cryptpad-limit';
     var TITLE_CLS = Bar.constants.title = "cryptpad-title";
     var NEWPAD_CLS = Bar.constants.newpad = "cryptpad-new";
-    var UPGRADE_CLS = Bar.constants.upgrade = "cryptpad-upgrade";
 
     // User admin menu
     var USERADMIN_CLS = Bar.constants.user = 'cryptpad-user-dropdown';
@@ -66,10 +63,6 @@ define([
         var $userContainer = $('<span>', {
             'class': USER_CLS
         }).appendTo($topContainer);
-        $('<button>', {'class': UPGRADE_CLS + ' buttonSuccess'}).hide().appendTo($userContainer);
-        $('<span>', {'class': SPINNER_CLS}).hide().appendTo($userContainer);
-        $('<span>', {'class': STATE_CLS}).hide().appendTo($userContainer);
-        $('<span>', {'class': LAG_CLS}).hide().appendTo($userContainer);
         $('<span>', {'class': LIMIT_CLS}).hide().appendTo($userContainer);
         $('<span>', {'class': NEWPAD_CLS + ' dropdown-bar'}).hide().appendTo($userContainer);
         $('<span>', {'class': USERADMIN_CLS + ' dropdown-bar'}).hide().appendTo($userContainer);
@@ -124,17 +117,6 @@ define([
 
     // Userlist elements
 
-    var checkSynchronizing = function (toolbar, config) {
-        if (!toolbar.state) { return; }
-        var userList = config.userList.list.users;
-        var userNetfluxId = config.userList.userNetfluxId;
-        var meIdx = userList.indexOf(userNetfluxId);
-        if (meIdx === -1) {
-            toolbar.state.text(Messages.synchronizing);
-            return;
-        }
-        toolbar.state.text('');
-    };
     var getOtherUsers = function(config) {
         var userList = config.userList.list.users;
         var userData = config.userList.data;
@@ -283,7 +265,6 @@ define([
                 var users = userList.users;
                 if (users.indexOf(config.userList.userNetfluxId) !== -1) {toolbar.connected = true;}
                 if (!toolbar.connected) { return; }
-                checkSynchronizing(toolbar, config);
                 if (config.userList.data) {
                     updateUserList(toolbar, config);
                 }
@@ -315,7 +296,6 @@ define([
         var $button = $('<button>').appendTo($container);
         $('<span>',{'class': 'buttonTitle'}).appendTo($button);
 
-        toolbar.$leftside.prepend($('<span>', {'class': 'separator'}));
         toolbar.$leftside.prepend($container);
 
         if (config.$contentContainer) {
@@ -446,6 +426,7 @@ define([
             var $shareBlock = Cryptpad.createDropdown(dropdownConfigShare);
             //$shareBlock.find('button').attr('id', 'shareButton');
             $shareBlock.find('.dropdown-bar-content').addClass(SHARE_CLS).addClass(EDITSHARE_CLS).addClass(VIEWSHARE_CLS);
+            $shareBlock.addClass('shareButton');
 
             if (hashes.editHash) {
                 $shareBlock.find('a.editShare').click(function () {
@@ -481,8 +462,8 @@ define([
             throw new Error("Unable to display the share button: hash required in the URL");
         }
         var $shareIcon = $('<span>', {'class': 'fa fa-share-alt'});
-        //var $span = $('<span>', {'class': 'large'}).append(' ' +Messages.shareButton);
-        var $button = $('<button>', {'title': Messages.shareButton}).append($shareIcon);//:.append($span);
+        var $button = $('<button>', {'title': Messages.shareButton}).append($shareIcon);
+        $button.addClass('shareButton');
         $button.click(function () {
             var url = window.location.href;
             var success = Cryptpad.Clipboard.copy(url);
@@ -607,6 +588,8 @@ define([
             'class': TITLE_CLS
         }).appendTo(toolbar.$top);
 
+        toolbar.$top.find('.filler').hide();
+
         var $hoverable = $('<span>', {'class': 'hoverable'}).appendTo($titleContainer);
 
         // Buttons
@@ -644,76 +627,28 @@ define([
         return $linkContainer;
     };
 
-    var checkLag = function (toolbar, config, $lagEl) {
-        var lag;
-        var $lag = $lagEl || toolbar.lag;
-        if (!$lag) { return; }
-        var getLag = config.network.getLag;
-        if(typeof getLag === "function") {
-            lag = getLag();
-        }
-        var title;
-        if (lag && toolbar.connected) {
-            $lag.attr('class', LAG_CLS);
-            toolbar.firstConnection = false;
-            title = Messages.lag + ' : ' + lag + ' ms\n';
-            if (lag > 30000) {
-                $lag.addClass('lag0');
-                title = Messages.redLight;
-            } else if (lag > 5000) {
-                $lag.addClass('lag1');
-                title += Messages.orangeLight;
-            } else if (lag > 1000) {
-                $lag.addClass('lag2');
-                title += Messages.orangeLight;
-            } else if (lag > 300) {
-                $lag.addClass('lag3');
-                title += Messages.greenLight;
-            } else {
-                $lag.addClass('lag4');
-                title += Messages.greenLight;
-            }
-        }
-        else if (!toolbar.firstConnection) {
-            $lag.attr('class', LAG_CLS);
-            $lag.addClass('dc');
-            title = Messages.redLight;
-        } else {
-            $lag.addClass('lag4');
-        }
-        if (title) {
-            $lag.attr('title', title);
-        }
-    };
-    var createLag = function (toolbar, config) {
-        var $a = toolbar.$userAdmin.find('.'+LAG_CLS).show();
-        var $container = $('<span>', {'class': 'bars'}).appendTo($a);
-        $('<span>', {'class': 'bar1'}).appendTo($container);
-        $('<span>', {'class': 'bar2'}).appendTo($container);
-        $('<span>', {'class': 'bar3'}).appendTo($container);
-        $('<span>', {'class': 'bar4'}).appendTo($container);
-        $('<span>', {'class': 'disconnected fa fa-exclamation-circle'}).appendTo($a);
-        if (config.network) {
-            checkLag(toolbar, config, $a);
-            setInterval(function () {
-                if (!toolbar.connected) { return; }
-                checkLag(toolbar, config);
-            }, 3000);
-        }
-        return $a;
-    };
-
+    var typing = -1;
     var kickSpinner = function (toolbar, config, local) {
         if (!toolbar.spinner) { return; }
         var $spin = toolbar.spinner;
-        $spin.find('.spin').show();
-        $spin.find('.synced').hide();
+
+        if (typing === -1) {
+            typing = 1;
+            $spin.text(Messages.typing);
+            $spin.interval = window.setInterval(function () {
+                var dots = Array(typing+1).join('.');
+                $spin.text(Messages.typing + dots);
+                typing++;
+                if (typing > 3) { typing = 0; }
+            }, 500);
+        }
         var onSynced = function () {
             if ($spin.timeout) { clearTimeout($spin.timeout); }
             $spin.timeout = setTimeout(function () {
-                $spin.find('.spin').hide();
-                $spin.find('.synced').show();
-            }, local ? 0 : SPINNER_DISAPPEAR_TIME);
+                window.clearInterval($spin.interval);
+                typing = -1;
+                $spin.text(Messages.saved);
+            }, /*local ? 0 :*/ SPINNER_DISAPPEAR_TIME);
         };
         if (Cryptpad) {
             Cryptpad.whenRealtimeSyncs(config.realtime, onSynced);
@@ -727,16 +662,9 @@ define([
         };
     };
     var createSpinner = function (toolbar, config) {
-        var $spin = toolbar.$userAdmin.find('.'+SPINNER_CLS).show();
-        $('<span>', {
-            id: uid(),
-            'class': 'spin fa fa-spinner fa-pulse',
-        }).appendTo($spin).hide();
-        $('<span>', {
-            id: uid(),
-            'class': 'synced fa fa-check',
-            title: Messages.synced
-        }).appendTo($spin);
+        var $spin = $('<span>', {'class': SPINNER_CLS}).appendTo(toolbar.$leftside);
+        $spin.text(Messages.synchronizing);
+
         if (config.realtime) {
             config.realtime.onPatch(ks(toolbar, config));
             config.realtime.onMessage(ks(toolbar, config, true));
@@ -744,10 +672,6 @@ define([
         return $spin;
     };
 
-    var createState = function (toolbar) {
-        return toolbar.$userAdmin.find('.'+STATE_CLS).text(Messages.synchronizing).show();
-    };
-
     var createLimit = function (toolbar) {
         if (!Config.enablePinning) { return; }
         var $limitIcon = $('<span>', {'class': 'fa fa-exclamation-triangle'});
@@ -853,34 +777,6 @@ define([
         return $userAdmin;
     };
 
-    var createUpgrade = function (/*toolbar*/) {
-        return; // TODO
-        /*if (ApiConfig.removeDonateButton) { return; }
-        if (Cryptpad.account.plan) { return; }
-
-        var text;
-        var feedback;
-        var url;
-        if (ApiConfig.allowSubscriptions && Cryptpad.isLoggedIn()) {
-            text = Messages.upgradeAccount;
-            feedback = "UPGRADE_ACCOUNT";
-            url = Cryptpad.upgradeURL;
-        } else {
-            text = Messages.supportCryptpad;
-            feedback = "SUPPORT_CRYPTPAD";
-            url = Cryptpad.donateURL;
-        }
-
-        var $upgrade = toolbar.$top.find('.' + UPGRADE_CLS).attr({
-            'title': Messages.supportCryptpad
-        }).text(text).show()
-        .click(function () {
-            Cryptpad.feedback(feedback);
-            window.open(url,'_blank');
-        });
-        return $upgrade;*/
-    };
-
     // Events
     var initClickEvents = function (toolbar, config) {
         var removeDropdowns =  function () {
@@ -1036,11 +932,11 @@ define([
         tb['fileshare'] = createFileShare;
         tb['title'] = createTitle;
         tb['pageTitle'] = createPageTitle;
-        tb['lag'] = createLag;
+        tb['lag'] = $.noop;
         tb['spinner'] = createSpinner;
-        tb['state'] = createState;
+        tb['state'] = $.noop;
         tb['limit'] = createLimit;
-        tb['upgrade'] = createUpgrade;
+        tb['upgrade'] = $.noop;
         tb['newpad'] = createNewPad;
         tb['useradmin'] = createUserAdmin;
 
@@ -1068,18 +964,14 @@ define([
 
         var failed = toolbar.failed = function () {
             toolbar.connected = false;
-            if (toolbar.state) {
-                toolbar.state.text(Messages.disconnected);
-            }
-            checkLag(toolbar, config);
+            toolbar.spinner.text(Messages.disconnected);
+            //checkLag(toolbar, config);
         };
         toolbar.reconnecting = function (userId) {
             if (config.userList) { config.userList.userNetfluxId = userId; }
             toolbar.connected = false;
-            if (toolbar.state) {
-                toolbar.state.text(Messages.reconnecting);
-            }
-            checkLag(toolbar, config);
+            toolbar.spinner.text(Messages.reconnecting);
+            //checkLag(toolbar, config);
         };
 
         // On log out, remove permanently the realtime elements of the toolbar
diff --git a/www/drive/file.less b/www/drive/file.less
index 0a0ca7151..676ac8f89 100644
--- a/www/drive/file.less
+++ b/www/drive/file.less
@@ -67,10 +67,16 @@ img.icon {
     flex-flow: row;
     @media screen and (max-width: @size-mobile) {
         display: block;
+        #driveToolbar {
+            .path .element {
+                display: none;
+            }
+        }
         #tree {
             resize: none;
             width: 100%;
             max-width: unset;
+            max-height: unset;
             border-bottom: 1px solid @toolbar-border-col;
             .category {
                 margin-top: 0.5em;
diff --git a/www/drive/main.js b/www/drive/main.js
index f8e518987..a097d67fe 100644
--- a/www/drive/main.js
+++ b/www/drive/main.js
@@ -2723,7 +2723,7 @@ define([
 
             var userList = APP.userList = info.userList;
             var config = {
-                displayed: ['useradmin', 'spinner', 'lag', 'state', 'limit', 'newpad', 'pageTitle'],
+                displayed: ['useradmin', 'limit', 'newpad', 'pageTitle'],
                 userList: {
                     list: userList,
                     userNetfluxId: info.myID