From ac153690f9055032678dc03082c9a2152158bfde Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?David=20Benqu=C3=A9?= <mail@davidbenque.com>
Date: Thu, 5 Nov 2020 11:59:15 +0000
Subject: [PATCH] Accessibility fixes

---
 customize.dist/pages.js                       |  4 +--
 customize.dist/pages/index.js                 | 11 +++++---
 customize.dist/pages/what-is-cryptpad.js      | 27 +++++++++++++------
 .../src/less2/include/infopages.less          |  4 +--
 4 files changed, 31 insertions(+), 15 deletions(-)

diff --git a/customize.dist/pages.js b/customize.dist/pages.js
index 1f0cc9211..0dd518089 100644
--- a/customize.dist/pages.js
+++ b/customize.dist/pages.js
@@ -18,11 +18,11 @@ define([
         var selected = Msg._languageUsed;
         var keys = Object.keys(languages).sort();
         keys.forEach(function (l) {
-            var attr = { value: l};
+            var attr = { value: l, role: 'option'};
             if (selected === l) { attr.selected = 'selected'; }
             options.push(h('option', attr, languages[l]));
         });
-        var select = h('select', {role: 'listbox', 'aria-label': 'language'}, options);
+        var select = h('select', {role: 'listbox', 'label': 'language'}, options);
         $(select).change(function () {
             Language.setLanguage($(select).val() || '', null, function () {
                 window.location.reload();
diff --git a/customize.dist/pages/index.js b/customize.dist/pages/index.js
index cd81d1b7c..926f8e006 100644
--- a/customize.dist/pages/index.js
+++ b/customize.dist/pages/index.js
@@ -59,7 +59,7 @@ define([
                 return h('a', [
                     attr,
                     h(s, [
-                        h('i.' + font + '.' + icon),
+                        h('i.' + font + '.' + icon, {'aria-hidden': 'true'}),
                         h('div.pad-button-text', [ x[1] ])
                     ])
                 ]);
@@ -127,7 +127,8 @@ define([
                 h('div.col-sm-6',
                     h('img.img-fluid', {
                         src:'/customize/images/shredder.png',
-                        alt:'illustration, a shredder destroys a sheet of paper and antoher one reconstructs it'
+                        alt:'',
+                        'aria-hidden': 'true'
                     })
                 ),
                 h('div.col-sm-6', [
@@ -165,7 +166,11 @@ define([
                 h('div.container.cp-container', [
                     h('div.row.cp-home-hero', [
                         h('div.cp-title.col-md-7', [
-                            h('img', { src: '/customize/CryptPad_logo.svg?' + urlArgs }),
+                            h('img', {
+                                src: '/customize/CryptPad_logo.svg?' + urlArgs,
+                                'aria-hidden': 'true',
+                                alt: ''
+                            }),
                             h('h1', 'CryptPad'),
                             UI.setHTML(h('span.tag-line'), Msg.main_catch_phrase)
                         ]),
diff --git a/customize.dist/pages/what-is-cryptpad.js b/customize.dist/pages/what-is-cryptpad.js
index 7cc5ca7da..1857d844d 100644
--- a/customize.dist/pages/what-is-cryptpad.js
+++ b/customize.dist/pages/what-is-cryptpad.js
@@ -34,7 +34,9 @@ define([
                     ]),
                     h('div.col-md-6', [
                         h('img', {
-                            src: '/customize/images/collaboration.png?' + urlArgs
+                            src: '/customize/images/collaboration.png?' + urlArgs,
+                            alt: '',
+                            'aria-hidden': 'true'
                         }),
                     ]),
                 ]),
@@ -45,7 +47,9 @@ define([
                     ]),
                     h('div.col-md-6.order-md-1', [
                         h('img', {
-                            src: '/customize/images/apps-preview.png?' + urlArgs
+                            src: '/customize/images/apps-preview.png?' + urlArgs,
+                            alt: '',
+                            'aria-hidden': 'true'
                         }),
                     ]),
                 ]),
@@ -56,7 +60,9 @@ define([
                     ]),
                     h('div.col-md-6', [
                         h('img.cp-shadow', {
-                            src: '/customize/images/drive-grid.png?' + urlArgs
+                            src: '/customize/images/drive-grid.png?' + urlArgs,
+                            alt: '',
+                            'aria-hidden': 'true'
                         }),
                     ]),
                 ]),
@@ -71,16 +77,20 @@ define([
                     ]),
                     h('div.col-md-6.order-md-1.small-logos', [
                         h('img', {
-                            src: '/customize/images/logo_ngi.png?' + urlArgs
+                            src: '/customize/images/logo_ngi.png?' + urlArgs,
+                            alt: 'Logo NGI Trust'
                         }),
                         h('img', {
-                            src: '/customize/images/logo_nlnet.svg?' + urlArgs
+                            src: '/customize/images/logo_nlnet.svg?' + urlArgs,
+                            alt: 'Logo NLNet Foundation'
                         }),
                         h('img', {
-                            src: '/customize/images/logo_bpifrance.svg?' + urlArgs
+                            src: '/customize/images/logo_bpifrance.svg?' + urlArgs,
+                            alt: 'Logo BPI France'
                         }),
                         h('img', {
-                            src: '/customize/images/logo_moss.jpg?' + urlArgs
+                            src: '/customize/images/logo_moss.jpg?' + urlArgs,
+                            alt: 'Logo Mozilla Open Source Support'
                         }),
                     ]),
                 ]),
@@ -91,7 +101,8 @@ define([
                     ]),
                     h('div.col-md-6.small-logos', [
                         h('img', {
-                            src: '/customize/images/logo_XWiki.svg?' + urlArgs
+                            src: '/customize/images/logo_XWiki.svg?' + urlArgs,
+                            alt: 'Logo XWiki'
                         }),
                     ]),
                 ]),
diff --git a/customize.dist/src/less2/include/infopages.less b/customize.dist/src/less2/include/infopages.less
index 712c882ce..3f0e219d8 100644
--- a/customize.dist/src/less2/include/infopages.less
+++ b/customize.dist/src/less2/include/infopages.less
@@ -84,8 +84,8 @@ body {
             padding: 10px 20px;
             border-radius: 0px;
             cursor: pointer;
-            &:hover {
-                background-color: lighten(@colortheme_logo-2, 3%);
+            &:hover, &:focus {
+                background-color: darken(@colortheme_logo-2, 5%);
             }
         }
         button.cp-secondary {