From a96e49d55a86653e9d47b853dc04d8e2c6168536 Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Wed, 15 Nov 2017 16:56:50 +0100
Subject: [PATCH] Fix filepicker creating a new netflux network when
 initialized

---
 www/common/sframe-common-outer.js  | 70 +++++++++++++++++-------------
 www/filepicker/app-filepicker.less |  1 +
 www/filepicker/inner.js            |  2 -
 www/filepicker/main.js             | 34 ++-------------
 4 files changed, 46 insertions(+), 61 deletions(-)

diff --git a/www/common/sframe-common-outer.js b/www/common/sframe-common-outer.js
index fcbb19d77..36d2fca78 100644
--- a/www/common/sframe-common-outer.js
+++ b/www/common/sframe-common-outer.js
@@ -15,6 +15,7 @@ define([
         var Cryptpad;
         var Crypto;
         var Cryptget;
+        var SFrameChannel;
         var sframeChan;
         var FilePicker;
         var Messenger;
@@ -37,12 +38,13 @@ define([
                 '/common/common-hash.js',
                 '/common/common-util.js',
                 '/common/common-realtime.js',
-            ], waitFor(function (_CpNfOuter, _Cryptpad, _Crypto, _Cryptget, SFrameChannel,
+            ], waitFor(function (_CpNfOuter, _Cryptpad, _Crypto, _Cryptget, _SFrameChannel,
             _FilePicker, _Messenger, _Messaging, _Notifier, _Hash, _Util, _Realtime) {
                 CpNfOuter = _CpNfOuter;
                 Cryptpad = _Cryptpad;
                 Crypto = _Crypto;
                 Cryptget = _Cryptget;
+                SFrameChannel = _SFrameChannel;
                 FilePicker = _FilePicker;
                 Messenger = _Messenger;
                 Messaging = _Messaging;
@@ -166,11 +168,40 @@ define([
                 sframeChan.event('EV_LOGOUT');
             });
 
-            sframeChan.on('Q_ANON_RPC_MESSAGE', function (data, cb) {
-                Cryptpad.anonRpcMsg(data.msg, data.content, function (err, response) {
-                    cb({error: err, response: response});
+            // Put in the following function the RPC queries that should also work in filepicker
+            var addCommonRpc = function (sframeChan) {
+                sframeChan.on('Q_ANON_RPC_MESSAGE', function (data, cb) {
+                    Cryptpad.anonRpcMsg(data.msg, data.content, function (err, response) {
+                        cb({error: err, response: response});
+                    });
                 });
-            });
+
+                sframeChan.on('Q_GET_PIN_LIMIT_STATUS', function (data, cb) {
+                    Cryptpad.isOverPinLimit(function (e, overLimit, limits) {
+                        cb({
+                            error: e,
+                            overLimit: overLimit,
+                            limits: limits
+                        });
+                    });
+                });
+
+                sframeChan.on('Q_THUMBNAIL_GET', function (data, cb) {
+                    Cryptpad.getThumbnail(data.key, function (e, data) {
+                        cb({
+                            error: e,
+                            data: data
+                        });
+                    });
+                });
+                sframeChan.on('Q_THUMBNAIL_SET', function (data, cb) {
+                    Cryptpad.setThumbnail(data.key, data.value, function (e) {
+                        cb({error:e});
+                    });
+                });
+
+            };
+            addCommonRpc(sframeChan);
 
             var currentTitle;
             var currentTabTitle;
@@ -221,16 +252,6 @@ define([
                 cb();
             });
 
-            sframeChan.on('Q_GET_PIN_LIMIT_STATUS', function (data, cb) {
-                Cryptpad.isOverPinLimit(function (e, overLimit, limits) {
-                    cb({
-                        error: e,
-                        overLimit: overLimit,
-                        limits: limits
-                    });
-                });
-            });
-
             sframeChan.on('Q_MOVE_TO_TRASH', function (data, cb) {
                 cb = cb || $.noop;
                 if (readOnly && hashes.editHash) {
@@ -320,20 +341,6 @@ define([
                 });
             });
 
-            sframeChan.on('Q_THUMBNAIL_GET', function (data, cb) {
-                Cryptpad.getThumbnail(data.key, function (e, data) {
-                    cb({
-                        error: e,
-                        data: data
-                    });
-                });
-            });
-            sframeChan.on('Q_THUMBNAIL_SET', function (data, cb) {
-                Cryptpad.setThumbnail(data.key, data.value, function (e) {
-                    cb({error:e});
-                });
-            });
-
             sframeChan.on('Q_SESSIONSTORAGE_PUT', function (data, cb) {
                 sessionStorage[data.key] = data.value;
                 cb();
@@ -405,6 +412,11 @@ define([
                     };
                     config.onFileUpload = onFileUpload;
                     config.types = cfg;
+                    config.addCommonRpc = addCommonRpc;
+                    config.modules = {
+                        Cryptpad: Cryptpad,
+                        SFrameChannel: SFrameChannel
+                    };
                     FP.$iframe = $('<iframe>', {id: 'sbox-filePicker-iframe'}).appendTo($('body'));
                     FP.picker = FilePicker.create(config);
                 } else {
diff --git a/www/filepicker/app-filepicker.less b/www/filepicker/app-filepicker.less
index a28ec8008..b148e5780 100644
--- a/www/filepicker/app-filepicker.less
+++ b/www/filepicker/app-filepicker.less
@@ -50,6 +50,7 @@
             img {
                 max-width: 100px;
                 max-height: 100px;
+                background: #fff;
             }
 
             .cp-filepicker-content-element-name {
diff --git a/www/filepicker/inner.js b/www/filepicker/inner.js
index 4b088249a..fb172b697 100644
--- a/www/filepicker/inner.js
+++ b/www/filepicker/inner.js
@@ -149,8 +149,6 @@ define([
             updateContainer();
         };
         sframeChan.on('EV_FILE_PICKER_REFRESH', function (newFilters) {
-            console.log(Sortify(filters));
-            console.log(Sortify(newFilters));
             if (Sortify(filters) !== Sortify(newFilters)) {
                 $body.html('');
                 filters = newFilters;
diff --git a/www/filepicker/main.js b/www/filepicker/main.js
index ef38c3970..df6ade62b 100644
--- a/www/filepicker/main.js
+++ b/www/filepicker/main.js
@@ -38,25 +38,13 @@ define([
             window.addEventListener('message', onMsg);
         }).nThen(function (/*waitFor*/) {
             var Cryptpad;
-            var Crypto;
-            var Cryptget;
 
             nThen(function (waitFor) {
-                // Load #2, the loading screen is up so grab whatever you need...
-                require([
-                    '/common/cryptpad-common.js',
-                    '/bower_components/chainpad-crypto/crypto.js',
-                    '/common/cryptget.js',
-                    '/common/sframe-channel.js',
-                ], waitFor(function (_Cryptpad, _Crypto, _Cryptget, SFrameChannel) {
-                    Cryptpad = _Cryptpad;
-                    Crypto = _Crypto;
-                    Cryptget = _Cryptget;
-                    SFrameChannel.create($('#sbox-filePicker-iframe')[0].contentWindow, waitFor(function (sfc) {
+                Cryptpad = config.modules.Cryptpad;
+                config.modules.SFrameChannel.create($('#sbox-filePicker-iframe')[0].contentWindow,
+                    waitFor(function (sfc) {
                         sframeChan = sfc;
                     }));
-                    Cryptpad.ready(waitFor());
-                }));
             }).nThen(function () {
                 var proxy = Cryptpad.getProxy();
                 var updateMeta = function () {
@@ -94,21 +82,7 @@ define([
                 sframeChan.onReg('EV_METADATA_UPDATE', updateMeta);
                 proxy.on('change', 'settings', updateMeta);
 
-                sframeChan.on('Q_ANON_RPC_MESSAGE', function (data, cb) {
-                    Cryptpad.anonRpcMsg(data.msg, data.content, function (err, response) {
-                        cb({error: err, response: response});
-                    });
-                });
-
-                sframeChan.on('Q_GET_PIN_LIMIT_STATUS', function (data, cb) {
-                    Cryptpad.isOverPinLimit(function (e, overLimit, limits) {
-                        cb({
-                            error: e,
-                            overLimit: overLimit,
-                            limits: limits
-                        });
-                    });
-                });
+                config.addCommonRpc(sframeChan);
 
                 sframeChan.on('Q_GET_FILES_LIST', function (types, cb) {
                     console.error("TODO: make sure Q_GET_FILES_LIST is only available from filepicker");