From 8e725f3d7c46f6720a78c081097cecb1181277a0 Mon Sep 17 00:00:00 2001
From: ansuz <ansuz@transitiontech.ca>
Date: Wed, 30 Jun 2021 17:20:03 +0530
Subject: [PATCH] stop returning the hash of all user pins after pinning

the client doesn't use it and it's CPU-intensive
---
 lib/commands/pin-rpc.js         | 12 +++++-------
 www/common/outer/async-store.js | 12 ++++++------
 2 files changed, 11 insertions(+), 13 deletions(-)

diff --git a/lib/commands/pin-rpc.js b/lib/commands/pin-rpc.js
index ff6bfdbac..af2c32c64 100644
--- a/lib/commands/pin-rpc.js
+++ b/lib/commands/pin-rpc.js
@@ -8,7 +8,7 @@ const nThen = require("nthen");
 //const escapeKeyCharacters = Util.escapeKeyCharacters;
 const unescapeKeyCharacters = Util.unescapeKeyCharacters;
 
-var sumChannelSizes = function (sizes) {
+var sumChannelSizes = function (sizes) { // FIXME this synchronous code could be done by a worker
     return Object.keys(sizes).map(function (id) { return sizes[id]; })
         .filter(function (x) {
             // only allow positive numbers
@@ -171,7 +171,7 @@ Pinning.pinChannel = function (Env, safeKey, channels, cb) {
 
         getMultipleFileSize(Env, toStore, function (e, sizes) {
             if (typeof(sizes) === 'undefined') { return void cb(e); }
-            var pinSize = sumChannelSizes(sizes);
+            var pinSize = sumChannelSizes(sizes); // FIXME don't do this in the main thread...
 
             getFreeSpace(Env, safeKey, function (e, free) {
                 if (typeof(free) === 'undefined') {
@@ -186,7 +186,7 @@ Pinning.pinChannel = function (Env, safeKey, channels, cb) {
                     toStore.forEach(function (channel) {
                         session.channels[channel] = true;
                     });
-                    getHash(Env, safeKey, cb);
+                    cb();
                 });
             });
         });
@@ -217,7 +217,7 @@ Pinning.unpinChannel = function (Env, safeKey, channels, cb) {
             toStore.forEach(function (channel) {
                 delete session.channels[channel];
             });
-            getHash(Env, safeKey, cb);
+            cb();
         });
     });
 };
@@ -270,9 +270,7 @@ Pinning.resetUserPins = function (Env, safeKey, channelList, cb) {
 
                 // update in-memory cache IFF the reset was allowed.
                 session.channels = pins;
-                getHash(Env, safeKey, function (e, hash) {
-                    cb(e, hash);
-                });
+                cb();
             });
         });
     });
diff --git a/www/common/outer/async-store.js b/www/common/outer/async-store.js
index 66e1967cd..9f779a0a8 100644
--- a/www/common/outer/async-store.js
+++ b/www/common/outer/async-store.js
@@ -274,9 +274,9 @@ define([
             }
 
             var pads = data.pads || data;
-            s.rpc.pin(pads, function (e, hash) {
+            s.rpc.pin(pads, function (e) {
                 if (e) { return void cb({error: e}); }
-                cb({hash: hash});
+                cb({});
             });
         };
 
@@ -289,9 +289,9 @@ define([
             if (!s.rpc) { return void cb({error: 'RPC_NOT_READY'}); }
 
             var pads = data.pads || data;
-            s.rpc.unpin(pads, function (e, hash) {
+            s.rpc.unpin(pads, function (e) {
                 if (e) { return void cb({error: e}); }
-                cb({hash: hash});
+                cb({});
             });
         };
 
@@ -394,9 +394,9 @@ define([
             if (!store.rpc) { return void cb({error: 'RPC_NOT_READY'}); }
 
             var list = getCanonicalChannelList(false);
-            store.rpc.reset(list, function (e, hash) {
+            store.rpc.reset(list, function (e) {
                 if (e) { return void cb(e); }
-                cb(null, hash);
+                cb(null);
             });
         };