From 275a3c80fcf7577d89bc93089c7ec91dc4cc537e Mon Sep 17 00:00:00 2001 From: ansuz Date: Thu, 10 Jan 2019 18:20:32 +0100 Subject: [PATCH 1/3] roll back to less 3.7.1 because newer versions break IE see https://github.com/less/less.js/issues/3321 --- bower.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bower.json b/bower.json index 27b1ea1f4..94c6af3a7 100644 --- a/bower.json +++ b/bower.json @@ -36,7 +36,7 @@ "alertifyjs": "1.0.11", "scrypt-async": "1.2.0", "require-css": "0.1.10", - "less": "^3.7.1", + "less": "3.7.1", "bootstrap": "^v4.0.0", "diff-dom": "2.1.1", "nthen": "^0.1.5", From 20959f84ae870c451021ff898fadb8d79581fe74 Mon Sep 17 00:00:00 2001 From: ansuz Date: Thu, 10 Jan 2019 18:21:39 +0100 Subject: [PATCH 2/3] return Boolean from our test for WebRTC support --- www/common/cryptpad-common.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/www/common/cryptpad-common.js b/www/common/cryptpad-common.js index 0b72dccbc..ab956ba74 100644 --- a/www/common/cryptpad-common.js +++ b/www/common/cryptpad-common.js @@ -1112,11 +1112,11 @@ define([ }; common.isWebRTCSupported = function () { - return navigator.getUserMedia || + return Boolean(navigator.getUserMedia || navigator.webkitGetUserMedia || navigator.mozGetUserMedia || navigator.msGetUserMedia || - window.RTCPeerConnection; + window.RTCPeerConnection); }; common.ready = (function () { From 6f89156415a9849da826ffb185f87bd328b25e6c Mon Sep 17 00:00:00 2001 From: ansuz Date: Fri, 11 Jan 2019 16:58:39 +0100 Subject: [PATCH 3/3] guard against calling an undefined function --- www/common/common-feedback.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/common/common-feedback.js b/www/common/common-feedback.js index f0b7d989b..d377bae5c 100644 --- a/www/common/common-feedback.js +++ b/www/common/common-feedback.js @@ -22,6 +22,7 @@ define([ http.send(); }; Feedback.send = function (action, force, cb) { + if (typeof(cb) !== 'function') { cb = function () {}; } if (AppConfig.disableFeedback) { return void cb(); } if (!action) { return void cb(); } if (force !== true) {