From ed5671a548986e26ec2f11e705913c580a58ea9f Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Mon, 2 Sep 2019 17:16:14 +0200
Subject: [PATCH 01/16] Don't write metadata updates to the log if it doesn't
 change the value

---
 lib/metadata.js | 19 ++++++++++++++++++-
 rpc.js          |  9 ++++++++-
 2 files changed, 26 insertions(+), 2 deletions(-)

diff --git a/lib/metadata.js b/lib/metadata.js
index 037024b57..bda0488dd 100644
--- a/lib/metadata.js
+++ b/lib/metadata.js
@@ -28,10 +28,14 @@ commands.ADD_OWNERS = function (meta, args) {
         throw new Error("METADATA_NONSENSE_OWNERS");
     }
 
+    var changed = false;
     args.forEach(function (owner) {
         if (meta.owners.indexOf(owner) >= 0) { return; }
         meta.owners.push(owner);
+        changed = true;
     });
+
+    return changed;
 };
 
 // ["RM_OWNERS", ["CrufexqXcY-z+eKJlEbNELVy5Sb7E-EAAEFI8GnEtZ0="], 1561623439989]
@@ -45,13 +49,17 @@ commands.RM_OWNERS = function (meta, args) {
         throw new Error("METADATA_NONSENSE_OWNERS");
     }
 
+    var changed = false;
     // remove owners one by one
     // we assume there are no duplicates
     args.forEach(function (owner) {
         var index = meta.owners.indexOf(owner);
         if (index < 0) { return; }
         meta.owners.splice(index, 1);
+        changed = true;
     });
+
+    return changed;
 };
 
 // ["ADD_PENDING_OWNERS", ["7eEqelGso3EBr5jHlei6av4r9w2B9XZiGGwA1EgZ-5I="], 1561623438989]
@@ -67,16 +75,20 @@ commands.ADD_PENDING_OWNERS = function (meta, args) {
         throw new Error("METADATA_NONSENSE_PENDING_OWNERS");
     }
 
+    var changed = false;
     // Add pending_owners array if it doesn't exist
     if (!meta.pending_owners) {
         meta.pending_owners = deduplicate(args);
-        return;
+        return true;
     }
     // or fill it
     args.forEach(function (owner) {
         if (meta.pending_owners.indexOf(owner) >= 0) { return; }
         meta.pending_owners.push(owner);
+        changed = true;
     });
+
+    return changed;
 };
 
 // ["RM_PENDING_OWNERS", ["CrufexqXcY-z+eKJlEbNELVy5Sb7E-EAAEFI8GnEtZ0="], 1561623439989]
@@ -90,13 +102,17 @@ commands.RM_PENDING_OWNERS = function (meta, args) {
         throw new Error("METADATA_NONSENSE_PENDING_OWNERS");
     }
 
+    var changed = false;
     // remove owners one by one
     // we assume there are no duplicates
     args.forEach(function (owner) {
         var index = meta.pending_owners.indexOf(owner);
         if (index < 0) { return; }
         meta.pending_owners.splice(index, 1);
+        changed = true;
     });
+
+    return changed;
 };
 
 // ["RESET_OWNERS", ["7eEqelGso3EBr5jHlei6av4r9w2B9XZiGGwA1EgZ-5I="], 1561623439989]
@@ -112,6 +128,7 @@ commands.RESET_OWNERS = function (meta, args) {
 
     // overwrite the existing owners with the new one
     meta.owners = deduplicate(args);
+    return true;
 };
 
 commands.UPDATE_EXPIRATION = function () {
diff --git a/rpc.js b/rpc.js
index 058215200..08a4edecf 100644
--- a/rpc.js
+++ b/rpc.js
@@ -340,6 +340,7 @@ var getMetadata = function (Env, channel, cb) {
         value: value
     }
 */
+// XXX global saferphore may cause issues here, a queue "per channel" is probably better
 var metadataSem = Saferphore.create(1);
 var setMetadata = function (Env, data, unsafeKey, cb) {
     var channel = data.channel;
@@ -382,13 +383,19 @@ var setMetadata = function (Env, data, unsafeKey, cb) {
 
             // Add the new metadata line
             var line = [command, data.value, +new Date()];
+            var changed = false;
             try {
-                Meta.handleCommand(metadata, line);
+                changed = Meta.handleCommand(metadata, line);
             } catch (e) {
                 g();
                 return void cb(e);
             }
 
+            // if your command is valid but it didn't result in any change to the metadata,
+            // call back now and don't write any "useless" line to the log
+            if (!changed) {
+                return void cb(void 0, metadata);
+            }
             Env.msgStore.writeMetadata(channel, JSON.stringify(line), function (e) {
                 g();
                 if (e) {

From d6b6b8f11f358dd9059516816d6f8d4f6bb4f693 Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Mon, 2 Sep 2019 17:42:30 +0200
Subject: [PATCH 02/16] Store the pad to the drive when accepting ownership

---
 www/common/common-ui-elements.js  | 20 ++++++++++++++++++++
 www/common/sframe-common-outer.js | 15 +++++++++++++++
 2 files changed, 35 insertions(+)

diff --git a/www/common/common-ui-elements.js b/www/common/common-ui-elements.js
index b37d71355..4f7373a7f 100644
--- a/www/common/common-ui-elements.js
+++ b/www/common/common-ui-elements.js
@@ -3068,6 +3068,7 @@ define([
     };
 
     var storePopupState = false;
+    var autoStoreModal = {};
     UIElements.displayStorePadPopup = function (common, data) {
         if (storePopupState) { return; }
         storePopupState = true;
@@ -3087,6 +3088,8 @@ define([
         var initialHide = data && data.autoStore && data.autoStore === -1;
         var modal = UI.cornerPopup(text, actions, footer, {hidden: initialHide});
 
+        autoStoreModal[priv.channel] = modal;
+
         $(modal.popup).find('.cp-corner-footer a').click(function (e) {
             e.preventDefault();
             common.openURL('/settings/');
@@ -3094,6 +3097,7 @@ define([
 
         $(hide).click(function () {
             UIElements.displayCrowdfunding(common);
+            delete autoStoreModal[priv.channel];
             modal.delete();
         });
         var waitingForStoringCb = false;
@@ -3109,6 +3113,7 @@ define([
                     }
                     return void UI.warn(Messages.autostore_error);
                 }
+                delete autoStoreModal[priv.channel];
                 modal.delete();
                 UIElements.displayCrowdfunding(common);
                 UI.log(Messages.autostore_saved);
@@ -3350,6 +3355,21 @@ define([
                     // Send notification to the sender
                     answer(true);
 
+                    var data = JSON.parse(JSON.stringify(msg.content));
+                    data.metadata = res;
+
+                    // Add the pad to your drive
+                    sframeChan.query('Q_ACCEPT_OWNERSHIP', data, function (err, res) {
+                        if (err || (res && res.error)) {
+                            return void console.error(err | res.error);
+                        }
+                        UI.log(Messages.saved);
+                        if (autoStoreModal[data.channel]) {
+                            autoStoreModal[data.channel].delete();
+                            delete autoStoreModal[data.channel];
+                        }
+                    });
+
                     // Remove yourself from the pending owners
                     sframeChan.query('Q_SET_PAD_METADATA', {
                         channel: msg.content.channel,
diff --git a/www/common/sframe-common-outer.js b/www/common/sframe-common-outer.js
index cc568553a..a8a00cd0b 100644
--- a/www/common/sframe-common-outer.js
+++ b/www/common/sframe-common-outer.js
@@ -476,6 +476,21 @@ define([
                 });
             });
 
+            sframeChan.on('Q_ACCEPT_OWNERSHIP', function (data, cb) {
+                var data = {
+                    password: data.password,
+                    href: data.href,
+                    channel: data.channel,
+                    title: data.title,
+                    owners: data.metadata.owners,
+                    expire: data.metadata.expire,
+                    forceSave: true
+                };
+                Cryptpad.setPadTitle(data, function (err) {
+                    cb({error: err});
+                });
+            });
+
             sframeChan.on('Q_IMPORT_MEDIATAG', function (obj, cb) {
                 var key = obj.key;
                 var channel = obj.channel;

From e76a62c2a587bdef797d6db9fbf00e84da47d7f2 Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Mon, 2 Sep 2019 17:45:55 +0200
Subject: [PATCH 03/16] Filter out pending_owners from the 'add owners' column

---
 www/common/common-ui-elements.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/www/common/common-ui-elements.js b/www/common/common-ui-elements.js
index 4f7373a7f..bc358cfcf 100644
--- a/www/common/common-ui-elements.js
+++ b/www/common/common-ui-elements.js
@@ -226,7 +226,8 @@ define([
         var drawAdd = function () {
             var _friends = JSON.parse(JSON.stringify(friends));
             Object.keys(_friends).forEach(function (curve) {
-                if (owners.indexOf(_friends[curve].edPublic) !== -1) {
+                if (owners.indexOf(_friends[curve].edPublic) !== -1 ||
+                    pending_owners.indexOf(_friends[curve].edPublic) !== -1) {
                     delete _friends[curve];
                 }
             });

From 772ecb7365f3b0c6519af7a1b3e1d54bca8f883f Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Mon, 2 Sep 2019 17:58:36 +0200
Subject: [PATCH 04/16] Make sure you always know yourself in the ownerhsip
 modal

---
 www/common/common-ui-elements.js | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/www/common/common-ui-elements.js b/www/common/common-ui-elements.js
index bc358cfcf..a8ea163b7 100644
--- a/www/common/common-ui-elements.js
+++ b/www/common/common-ui-elements.js
@@ -154,6 +154,12 @@ define([
                         return true;
                     }
                 });
+                if (ed === edPublic) {
+                    f = f || user;
+                    if (f.name) {
+                        f.displayName = f.name;
+                    }
+                }
                 _owners[ed] = f || {
                     displayName: 'Unknown user: '+ ed, // XXX
                     notifications: true,

From d190b8acd0c638fab659aeaa3b2d087135a423a0 Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Mon, 2 Sep 2019 18:19:56 +0200
Subject: [PATCH 05/16] Don't send user updates to friends via chat if you know
 their mailbox

---
 www/common/common-messaging.js       |  3 +++
 www/common/common-messenger.js       | 18 ++++++++++++------
 www/common/outer/mailbox-handlers.js |  3 +++
 3 files changed, 18 insertions(+), 6 deletions(-)

diff --git a/www/common/common-messaging.js b/www/common/common-messaging.js
index 3e673b1e9..8e27b3fd9 100644
--- a/www/common/common-messaging.js
+++ b/www/common/common-messaging.js
@@ -83,6 +83,9 @@ define([
             store.messenger.updateMyData();
         }
         var myData = createData(store.proxy);
+        if (store.proxy.friends) {
+            store.proxy.friends.me = myData;
+        }
         var todo = function (friend) {
             if (!friend || !friend.notifications) { return; }
             myData.channel = friend.channel;
diff --git a/www/common/common-messenger.js b/www/common/common-messenger.js
index 365c8be40..50195e20c 100644
--- a/www/common/common-messenger.js
+++ b/www/common/common-messenger.js
@@ -229,6 +229,11 @@ define([
             });
         };
 
+        messenger.onFriendUpdate = function (curve) {
+            var friend = getFriend(proxy, curve);
+            checkFriendData(curve, friend, friend.channel);
+        };
+
         // Id message allows us to map a netfluxId with a public curve key
         var onIdMessage = function (msg, sender) {
             var channel, parsed0;
@@ -373,12 +378,14 @@ define([
                  || mySyncData.profile !== myData.profile
                  || mySyncData.avatar !== myData.avatar) {
                 delete myData.channel;
-                Object.keys(channels).forEach(function (chan) {
-                    var channel = channels[chan];
+                Object.keys(friends).forEach(function (curve) {
+                    var friend = friends[curve];
+                    var chan = friend.channel;
+                    if (friend.notifications) { return; }
+                    if (!chan) { return; }
 
-                    if (!channel) {
-                        return void console.error('NO_SUCH_CHANNEL');
-                    }
+                    var channel = channels[chan];
+                    if (!channel) { return; }
                     if (channel.readOnly) { return; }
 
                     var msg = [Types.update, myData.curvePublic, +new Date(), myData];
@@ -396,7 +403,6 @@ define([
                     info: myData,
                     types: ['displayName', 'profile', 'avatar'],
                 });
-                friends.me = myData;
             }
         };
 
diff --git a/www/common/outer/mailbox-handlers.js b/www/common/outer/mailbox-handlers.js
index ed1d954b1..bc2d0b9ff 100644
--- a/www/common/outer/mailbox-handlers.js
+++ b/www/common/outer/mailbox-handlers.js
@@ -153,6 +153,9 @@ define([
         Object.keys(msg.content).forEach(function (key) {
             friend[key] = msg.content[key];
         });
+        if (ctx.store.messenger) {
+            ctx.store.messenger.onFriendUpdate(curve, friend);
+        }
         ctx.updateMetadata();
         cb(true);
     };

From 4708d59a656c527c612a41982ffeeae5b8f59bba Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Mon, 2 Sep 2019 18:46:52 +0200
Subject: [PATCH 06/16] Add notifications when removed from owners or
 pending_owners

---
 www/common/common-ui-elements.js     | 52 +++++++++++++++++++++-------
 www/common/notifications.js          | 18 ++++++++++
 www/common/outer/mailbox-handlers.js | 24 +++++++++++--
 www/common/sframe-common-outer.js    |  4 +--
 4 files changed, 82 insertions(+), 16 deletions(-)

diff --git a/www/common/common-ui-elements.js b/www/common/common-ui-elements.js
index a8ea163b7..4e576d35a 100644
--- a/www/common/common-ui-elements.js
+++ b/www/common/common-ui-elements.js
@@ -203,25 +203,53 @@ define([
                     if (ed === edPublic) { me = true; }
                     return ed;
                 }).filter(function (x) { return x; });
-                // Send the command
-                var send = function () {
+                NThen(function (waitFor) {
+                    var msg = me ?
+                      "Are you sure? You're going to give up on your rights, this can't be undone!" :
+                      "Are you sure?"; // XXX
+                    UI.confirm(msg, waitFor(function (yes) {
+                        if (!yes) {
+                            waitFor.abort();
+                            return;
+                        }
+                    }));
+                }).nThen(function (waitFor) {
+                    // Send the command
                     sframeChan.query('Q_SET_PAD_METADATA', {
                         channel: channel,
                         command: pending ? 'RM_PENDING_OWNERS' : 'RM_OWNERS',
                         value: toRemove
-                    }, function (err, res) {
+                    }, waitFor(function (err, res) {
                         err = err || (res && res.error);
-                        if (err) { return void UI.warn('ERROR' + err); } // XXX
-                        redrawAll();
+                        if (err) {
+                            waitFor.abort();
+                            return void UI.warn('ERROR' + err);
+                        } // XXX
                         UI.log('DONE'); // XXX
+                    }));
+                }).nThen(function (waitFor) {
+                    sel.forEach(function (el) {
+                        var friend = friends[$(el).attr('data-curve')];
+                        if (!friend) { return; }
+                        common.mailbox.sendTo("RM_OWNER", {
+                            channel: channel,
+                            title: data.title,
+                            pending: pending,
+                            user: {
+                                displayName: user.name,
+                                avatar: user.avatar,
+                                profile: user.profile,
+                                notifications: user.notifications,
+                                curvePublic: user.curvePublic,
+                                edPublic: priv.edPublic
+                            }
+                        }, {
+                            channel: friend.notifications,
+                            curvePublic: friend.curvePublic
+                        }, waitFor());
                     });
-                };
-                var msg = me ?
-                  "Are you sure? You're going to give up on your rights, this can't be undone!" :
-                  "Are you sure?"; // XXX
-                UI.confirm(msg, function (yes) {
-                    if (!yes) { return; }
-                    send();
+                }).nThen(function () {
+                    redrawAll();
                 });
             });
             $div.append(h('p', removeButton));
diff --git a/www/common/notifications.js b/www/common/notifications.js
index b06e8e3fc..ef64c303a 100644
--- a/www/common/notifications.js
+++ b/www/common/notifications.js
@@ -252,6 +252,24 @@ define([
         }
     };
 
+    handlers['RM_OWNER'] = function (common, data) {
+        var content = data.content;
+        var msg = content.msg;
+
+        // Display the notification
+        var name = Util.fixHTML(msg.content.user.displayName) || Messages.anonymous;
+        var title = Util.fixHTML(msg.content.title);
+        Messages.owner_removed = '{0} has removed your ownership of <b>{1}</b>'; // XXX
+        Messages.owner_removedPending = '{0} has removed your pending ownership of <b>{1}</b>'; // XXX
+        var key = 'owner_removed' + (msg.content.pending ? 'Pending' : '');
+        content.getFormatText = function () {
+            return Messages._getKey(key, [name, title]);
+        };
+        if (!content.archived) {
+            content.dismissHandler = defaultDismiss(common, data);
+        }
+    };
+
     // NOTE: don't forget to fixHTML everything returned by "getFormatText"
 
     return {
diff --git a/www/common/outer/mailbox-handlers.js b/www/common/outer/mailbox-handlers.js
index bc2d0b9ff..aa65d6cfd 100644
--- a/www/common/outer/mailbox-handlers.js
+++ b/www/common/outer/mailbox-handlers.js
@@ -267,7 +267,6 @@ define([
     handlers['ADD_OWNER'] = function (ctx, box, data, cb) {
         var msg = data.msg;
         var content = msg.content;
-console.log(msg);
 
         if (msg.author !== content.user.curvePublic) { return void cb(true); }
         if (!content.href || !content.title || !content.channel) {
@@ -278,7 +277,10 @@ console.log(msg);
         var channel = content.channel;
 
         if (addOwners[channel]) { return void cb(true); }
-        addOwners[channel] = true;
+        addOwners[channel] = {
+            type: box.type,
+            hash: data.hash
+        };
 
         cb(false);
     };
@@ -289,6 +291,24 @@ console.log(msg);
         }
     };
 
+    handlers['RM_OWNER'] = function (ctx, box, data, cb) {
+        var msg = data.msg;
+        var content = msg.content;
+
+        if (msg.author !== content.user.curvePublic) { return void cb(true); }
+        if (!content.channel) {
+            console.log('Remove invalid notification');
+            return void cb(true);
+        }
+
+        var channel = content.channel;
+
+        if (addOwners[channel] && content.pending) {
+            return void cb(false, addOwners[channel]);
+        }
+        cb(false);
+    };
+
     return {
         add: function (ctx, box, data, cb) {
             /**
diff --git a/www/common/sframe-common-outer.js b/www/common/sframe-common-outer.js
index a8a00cd0b..2a03392be 100644
--- a/www/common/sframe-common-outer.js
+++ b/www/common/sframe-common-outer.js
@@ -477,7 +477,7 @@ define([
             });
 
             sframeChan.on('Q_ACCEPT_OWNERSHIP', function (data, cb) {
-                var data = {
+                var _data = {
                     password: data.password,
                     href: data.href,
                     channel: data.channel,
@@ -486,7 +486,7 @@ define([
                     expire: data.metadata.expire,
                     forceSave: true
                 };
-                Cryptpad.setPadTitle(data, function (err) {
+                Cryptpad.setPadTitle(_data, function (err) {
                     cb({error: err});
                 });
             });

From 6e5fdc0b8e3522c559a1e2a0382f9c14ee0a50e6 Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Tue, 3 Sep 2019 10:55:48 +0200
Subject: [PATCH 07/16] Get all pad attributes at once

---
 www/common/common-ui-elements.js | 50 +++++---------------------------
 www/common/proxy-manager.js      | 28 +++++-------------
 2 files changed, 16 insertions(+), 62 deletions(-)

diff --git a/www/common/common-ui-elements.js b/www/common/common-ui-elements.js
index 4e576d35a..a02fb8851 100644
--- a/www/common/common-ui-elements.js
+++ b/www/common/common-ui-elements.js
@@ -71,56 +71,22 @@ define([
     var getPropertiesData = function (common, cb) {
         var data = {};
         NThen(function (waitFor) {
-            common.getPadAttribute('password', waitFor(function (err, val) {
-                data.password = val;
-            }));
-        }).nThen(function (waitFor) {
             var base = common.getMetadataMgr().getPrivateData().origin;
-            // XXX getFileData?
-            // XXX getPadMetadata
-            common.getPadAttribute('href', waitFor(function (err, val) {
-                if (!val) { return; }
-                data.href = base + val;
-            }));
-            common.getPadAttribute('roHref', waitFor(function (err, val) {
-                if (!val) { return; }
-                data.roHref = base + val;
-            }));
-            common.getPadAttribute('channel', waitFor(function (err, val) {
-                data.channel = val;
-            }));
-            common.getPadAttribute('rtChannel', waitFor(function (err, val) {
-                data.rtChannel = val;
-            }));
-            common.getPadAttribute('lastVersion', waitFor(function (err, val) {
-                data.lastVersion = val;
-            }));
-            common.getPadAttribute('atime', waitFor(function (err, val) {
-                data.atime = val;
-            }));
-            common.getPadAttribute('ctime', waitFor(function (err, val) {
-                data.ctime = val;
-            }));
-            common.getPadAttribute('title', waitFor(function (err, val) {
-                data.title = val;
-            }));
-            common.getPadAttribute('tags', waitFor(function (err, val) {
-                data.tags = val;
+            common.getPadAttribute('', waitFor(function (err, val) {
+                if (err || !val) {
+                    waitFor.abort();
+                    return void cb(err || 'EEMPTY');
+                }
+                Util.extend(data, val);
+                if (data.href) { data.href = base + data.href; }
+                if (data.roHref) { data.roHref = base + data.roHref; }
             }));
             common.getPadMetadata(null, waitFor(function (obj) {
-                console.log(obj);
                 if (obj && obj.error) { return; }
                 data.owners = obj.owners;
                 data.expire = obj.expire;
                 data.pending_owners = obj.pending_owners;
             }));
-            /*
-            common.getPadAttribute('owners', waitFor(function (err, val) {
-                data.owners = val;
-            }));
-            common.getPadAttribute('expire', waitFor(function (err, val) {
-                data.expire = val;
-            }));*/
         }).nThen(function () {
             cb(void 0, data);
         });
diff --git a/www/common/proxy-manager.js b/www/common/proxy-manager.js
index 4bed6a1a2..5cfae1a38 100644
--- a/www/common/proxy-manager.js
+++ b/www/common/proxy-manager.js
@@ -738,29 +738,17 @@ define([
             return void cb(null, Env.user.proxy[UserObject.SHARED_FOLDERS][sfId][data.attr]);
         }
         var datas = findHref(Env, data.href);
-        var nt = nThen;
         var res = {};
         datas.forEach(function (d) {
-            nt = nt(function (waitFor) {
-                var atime, value;
-                var w = waitFor();
-                nThen(function (waitFor2) {
-                    d.userObject.getPadAttribute(data.href, 'atime', waitFor2(function (err, v) {
-                        atime = v;
-                    }));
-                    d.userObject.getPadAttribute(data.href, data.attr, waitFor2(function (err, v) {
-                        value = v;
-                    }));
-                }).nThen(function () {
-                    if (!res.value || res.atime < atime) {
-                        res.atime = atime;
-                        res.value = value;
-                    }
-                    w();
-                });
-            }).nThen;
+            var atime = d.data.atime;
+
+            var value = attr ? d.data[attr] : JSON.parse(JSON.stringify(d.data));
+            if (!res.value || res.atime < atime) {
+                res.atime = atime;
+                res.value = value;
+            }
         });
-        nt(function () { cb(null, res.value); });
+        cb(null, res.value);
     };
 
     var getTagsList = function (Env) {

From d52e449f87bd3181d49e5df982921185aed35407 Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Tue, 3 Sep 2019 13:29:57 +0200
Subject: [PATCH 08/16] Fix setMetadata RPC saferphore

---
 lib/metadata.js | 2 +-
 rpc.js          | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/metadata.js b/lib/metadata.js
index bda0488dd..fb8628410 100644
--- a/lib/metadata.js
+++ b/lib/metadata.js
@@ -144,7 +144,7 @@ var handleCommand = Meta.handleCommand = function (meta, line) {
         throw new Error("METADATA_UNSUPPORTED_COMMAND");
     }
 
-    commands[command](meta, args);
+    return commands[command](meta, args);
 };
 Meta.commands = Object.keys(commands);
 
diff --git a/rpc.js b/rpc.js
index 08a4edecf..352165b0b 100644
--- a/rpc.js
+++ b/rpc.js
@@ -394,6 +394,7 @@ var setMetadata = function (Env, data, unsafeKey, cb) {
             // if your command is valid but it didn't result in any change to the metadata,
             // call back now and don't write any "useless" line to the log
             if (!changed) {
+                g();
                 return void cb(void 0, metadata);
             }
             Env.msgStore.writeMetadata(channel, JSON.stringify(line), function (e) {

From 32f1d1627fbdaa96122b7fd8b33903d5f12d3e43 Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Tue, 3 Sep 2019 13:30:35 +0200
Subject: [PATCH 09/16] Refresh properties modal when receiving metadata
 updates

---
 www/common/common-ui-elements.js            | 274 +++++++++++---------
 www/common/cryptpad-common.js               |   2 +
 www/common/outer/async-store.js             |   5 +-
 www/common/proxy-manager.js                 |   2 +-
 www/common/sframe-chainpad-netflux-outer.js |   4 +
 www/common/sframe-common-outer.js           |   1 -
 6 files changed, 160 insertions(+), 128 deletions(-)

diff --git a/www/common/common-ui-elements.js b/www/common/common-ui-elements.js
index a02fb8851..f4f5108e6 100644
--- a/www/common/common-ui-elements.js
+++ b/www/common/common-ui-elements.js
@@ -271,14 +271,12 @@ define([
                         }
                     }));
                 }).nThen(function (waitFor) {
-                    console.log('koko');
                     // Send the command
                     sframeChan.query('Q_SET_PAD_METADATA', {
                         channel: channel,
                         command: 'ADD_PENDING_OWNERS',
                         value: toAdd
                     }, waitFor(function (err, res) {
-                        console.error(arguments);
                         err = err || (res && res.error);
                         if (err) {
                             waitFor.abort();
@@ -286,8 +284,6 @@ define([
                         } // XXX
                     }));
                 }).nThen(function (waitFor) {
-                    console.log('okok');
-                    // TODO send notifications
                     sel.forEach(function (el) {
                         var friend = friends[$(el).attr('data-curve')];
                         if (!friend) { return; }
@@ -318,13 +314,17 @@ define([
             return $div2;
         };
 
+        var pending = false;
         redrawAll = function () {
-            $div1.empty();
-            $div2.empty();
+            if (pending) { return; }
+            pending = true;
             common.getPadMetadata(null, function (obj) {
+                pending = false;
                 if (obj && obj.error) { return; }
                 owners = obj.owners;
                 pending_owners = obj.pending_owners;
+                $div1.empty();
+                $div2.empty();
                 $div1.append(drawRemove(false)).append(drawRemove(true));
                 $div2.append(drawAdd());
             });
@@ -333,6 +333,15 @@ define([
         $div1.append(drawRemove(false)).append(drawRemove(true));
         $div2.append(drawAdd());
 
+        var handler = sframeChan.on('EV_RT_METADATA', function (md) {
+            if (!$div1.length) {
+                return void handler.stop();
+            }
+            owners = md.owners;
+            pending_owners = md.pending_owners;
+            redrawAll();
+        });
+
         // Create modal
         var link = h('div.cp-share-columns', [
             div1,
@@ -349,139 +358,158 @@ define([
         return UI.dialog.customModal(link, {buttons: linkButtons});
     };
     var getRightsProperties = function (common, data, cb) {
-        var $d = $('<div>');
-        if (!data) { return void cb(void 0, $d); }
+        var $div = $('<div>');
+        if (!data) { return void cb(void 0, $div); }
 
-        $('<label>', {'for': 'cp-app-prop-owners'}).text(Messages.creation_owners)
-            .appendTo($d);
-        var owners = Messages.creation_noOwner;
-        var priv = common.getMetadataMgr().getPrivateData();
-        var edPublic = priv.edPublic;
-        var owned = false;
-        if (data.owners && data.owners.length) {
-            if (data.owners.indexOf(edPublic) !== -1) {
-                owned = true;
-            }
-            var names = [];
-            var strangers = 0;
-            data.owners.forEach(function (ed) {
-                // If a friend is an owner, add their name to the list
-                // otherwise, increment the list of strangers
-                if (ed === edPublic) {
-                    names.push(Messages.yourself);
-                    return;
+        var draw = function () {
+            var $d = $('<div>');
+            $('<label>', {'for': 'cp-app-prop-owners'}).text(Messages.creation_owners)
+                .appendTo($d);
+            var owners = Messages.creation_noOwner;
+            var priv = common.getMetadataMgr().getPrivateData();
+            var edPublic = priv.edPublic;
+            var owned = false;
+            if (data.owners && data.owners.length) {
+                if (data.owners.indexOf(edPublic) !== -1) {
+                    owned = true;
                 }
-                if (!Object.keys(priv.friends || {}).some(function (c) {
-                    var friend = priv.friends[c] || {};
-                    if (friend.edPublic !== ed || c === 'me') { return; }
-                    names.push(friend.displayName);
-                    return true;
-                })) {
-                    strangers++;
+                var names = [];
+                var strangers = 0;
+                data.owners.forEach(function (ed) {
+                    // If a friend is an owner, add their name to the list
+                    // otherwise, increment the list of strangers
+                    if (ed === edPublic) {
+                        names.push(Messages.yourself);
+                        return;
+                    }
+                    if (!Object.keys(priv.friends || {}).some(function (c) {
+                        var friend = priv.friends[c] || {};
+                        if (friend.edPublic !== ed || c === 'me') { return; }
+                        names.push(friend.displayName);
+                        return true;
+                    })) {
+                        strangers++;
+                    }
+                });
+                if (strangers) {
+                    names.push(Messages._getKey('properties_unknownUser', [strangers]));
                 }
-            });
-            if (strangers) {
-                names.push(Messages._getKey('properties_unknownUser', [strangers]));
+                owners = names.join(', ');
             }
-            owners = names.join(', ');
-        }
-        $d.append(UI.dialog.selectable(owners, {
-            id: 'cp-app-prop-owners',
-        }));
-        if (owned) {
-            var manageOwners = h('button.no-margin', 'Manage owners'); // XXX
-            $(manageOwners).click(function () {
-                var modal = createOwnerModal(common, data);
-                UI.openCustomModal(modal, {
-                    wide: true,
+            $d.append(UI.dialog.selectable(owners, {
+                id: 'cp-app-prop-owners',
+            }));
+            if (owned) {
+                var manageOwners = h('button.no-margin', 'Manage owners'); // XXX
+                $(manageOwners).click(function () {
+                    var modal = createOwnerModal(common, data);
+                    UI.openCustomModal(modal, {
+                        wide: true,
+                    });
                 });
-            });
-            $d.append(h('p', manageOwners));
-        }
-
-        if (!data.noExpiration) {
-            var expire = Messages.creation_expireFalse;
-            if (data.expire && typeof (data.expire) === "number") {
-                expire = new Date(data.expire).toLocaleString();
+                $d.append(h('p', manageOwners));
             }
-            $('<label>', {'for': 'cp-app-prop-expire'}).text(Messages.creation_expiration)
-                .appendTo($d);
-            $d.append(UI.dialog.selectable(expire, {
-                id: 'cp-app-prop-expire',
-            }));
-        }
 
-        if (!data.noPassword) {
-            var hasPassword = data.password;
-            if (hasPassword) {
-                $('<label>', {'for': 'cp-app-prop-password'}).text(Messages.creation_passwordValue)
+            if (!data.noExpiration) {
+                var expire = Messages.creation_expireFalse;
+                if (data.expire && typeof (data.expire) === "number") {
+                    expire = new Date(data.expire).toLocaleString();
+                }
+                $('<label>', {'for': 'cp-app-prop-expire'}).text(Messages.creation_expiration)
                     .appendTo($d);
-                var password = UI.passwordInput({
-                    id: 'cp-app-prop-password',
-                    readonly: 'readonly'
-                });
-                var $pwInput = $(password).find('.cp-password-input');
-                $pwInput.val(data.password).click(function () {
-                    $pwInput[0].select();
-                });
-                $d.append(password);
+                $d.append(UI.dialog.selectable(expire, {
+                    id: 'cp-app-prop-expire',
+                }));
             }
 
-            var parsed = Hash.parsePadUrl(data.href || data.roHref);
-            if (!data.noEditPassword && owned && parsed.hashData.type === 'pad' && parsed.type !== "sheet") { // FIXME SHEET fix password change for sheets
-                var sframeChan = common.getSframeChannel();
-                var changePwTitle = Messages.properties_changePassword;
-                var changePwConfirm = Messages.properties_confirmChange;
-                if (!hasPassword) {
-                    changePwTitle = Messages.properties_addPassword;
-                    changePwConfirm = Messages.properties_confirmNew;
+            if (!data.noPassword) {
+                var hasPassword = data.password;
+                if (hasPassword) {
+                    $('<label>', {'for': 'cp-app-prop-password'}).text(Messages.creation_passwordValue)
+                        .appendTo($d);
+                    var password = UI.passwordInput({
+                        id: 'cp-app-prop-password',
+                        readonly: 'readonly'
+                    });
+                    var $pwInput = $(password).find('.cp-password-input');
+                    $pwInput.val(data.password).click(function () {
+                        $pwInput[0].select();
+                    });
+                    $d.append(password);
                 }
-                $('<label>', {'for': 'cp-app-prop-change-password'})
-                    .text(changePwTitle).appendTo($d);
-                var newPassword = UI.passwordInput({
-                    id: 'cp-app-prop-change-password',
-                    style: 'flex: 1;'
-                });
-                var passwordOk = h('button', Messages.properties_changePasswordButton);
-                var changePass = h('span.cp-password-container', [
-                    newPassword,
-                    passwordOk
-                ]);
-                $(passwordOk).click(function () {
-                    var newPass = $(newPassword).find('input').val();
-                    if (data.password === newPass ||
-                        (!data.password && !newPass)) {
-                        return void UI.alert(Messages.properties_passwordSame);
+
+                var parsed = Hash.parsePadUrl(data.href || data.roHref);
+                if (!data.noEditPassword && owned && parsed.hashData.type === 'pad' && parsed.type !== "sheet") { // FIXME SHEET fix password change for sheets
+                    var sframeChan = common.getSframeChannel();
+                    var changePwTitle = Messages.properties_changePassword;
+                    var changePwConfirm = Messages.properties_confirmChange;
+                    if (!hasPassword) {
+                        changePwTitle = Messages.properties_addPassword;
+                        changePwConfirm = Messages.properties_confirmNew;
                     }
-                    UI.confirm(changePwConfirm, function (yes) {
-                        if (!yes) { return; }
-                        sframeChan.query("Q_PAD_PASSWORD_CHANGE", {
-                            href: data.href || data.roHref,
-                            password: newPass
-                        }, function (err, data) {
-                            if (err || data.error) {
-                                return void UI.alert(Messages.properties_passwordError);
-                            }
-                            UI.findOKButton().click();
-                            // If we didn't have a password, we have to add the /p/
-                            // If we had a password and we changed it to a new one, we just have to reload
-                            // If we had a password and we removed it, we have to remove the /p/
-                            if (data.warning) {
-                                return void UI.alert(Messages.properties_passwordWarning, function () {
+                    $('<label>', {'for': 'cp-app-prop-change-password'})
+                        .text(changePwTitle).appendTo($d);
+                    var newPassword = UI.passwordInput({
+                        id: 'cp-app-prop-change-password',
+                        style: 'flex: 1;'
+                    });
+                    var passwordOk = h('button', Messages.properties_changePasswordButton);
+                    var changePass = h('span.cp-password-container', [
+                        newPassword,
+                        passwordOk
+                    ]);
+                    $(passwordOk).click(function () {
+                        var newPass = $(newPassword).find('input').val();
+                        if (data.password === newPass ||
+                            (!data.password && !newPass)) {
+                            return void UI.alert(Messages.properties_passwordSame);
+                        }
+                        UI.confirm(changePwConfirm, function (yes) {
+                            if (!yes) { return; }
+                            sframeChan.query("Q_PAD_PASSWORD_CHANGE", {
+                                href: data.href || data.roHref,
+                                password: newPass
+                            }, function (err, data) {
+                                if (err || data.error) {
+                                    return void UI.alert(Messages.properties_passwordError);
+                                }
+                                UI.findOKButton().click();
+                                // If we didn't have a password, we have to add the /p/
+                                // If we had a password and we changed it to a new one, we just have to reload
+                                // If we had a password and we removed it, we have to remove the /p/
+                                if (data.warning) {
+                                    return void UI.alert(Messages.properties_passwordWarning, function () {
+                                        common.gotoURL(hasPassword && newPass ? undefined : (data.href || data.roHref));
+                                    }, {force: true});
+                                }
+                                return void UI.alert(Messages.properties_passwordSuccess, function () {
                                     common.gotoURL(hasPassword && newPass ? undefined : (data.href || data.roHref));
-                                }, {force: true});
-                            }
-                            return void UI.alert(Messages.properties_passwordSuccess, function () {
-                                common.gotoURL(hasPassword && newPass ? undefined : (data.href || data.roHref));
-                            }, {force: true});
+                                }, {force: true});
+                            });
                         });
                     });
-                });
-                $d.append(changePass);
+                    $d.append(changePass);
+                }
             }
-        }
+            return $d;
+        };
+
+        var sframeChan = common.getSframeChannel();
+        var handler = sframeChan.on('EV_RT_METADATA', function (md) {
+            if (!$div.length) {
+                handler.stop();
+                return;
+            }
+            md = JSON.parse(JSON.stringify(md));
+            data.owners = md.owners;
+            data.expire = md.expire;
+            data.pending_owners = md.pending_owners;
+            $div.empty();
+            $div.append(draw());
+        });
+        $div.append(draw());
 
-        cb(void 0, $d);
+        cb(void 0, $div);
     };
     var getPadProperties = function (common, data, cb) {
         var $d = $('<div>');
@@ -568,6 +596,8 @@ define([
         } else {
             cb(void 0, $d);
         }
+
+
     };
     UIElements.getProperties = function (common, data, cb) {
         var c1;
diff --git a/www/common/cryptpad-common.js b/www/common/cryptpad-common.js
index 56e5edcae..9d5a32e23 100644
--- a/www/common/cryptpad-common.js
+++ b/www/common/cryptpad-common.js
@@ -757,6 +757,7 @@ define([
     pad.onDisconnectEvent = Util.mkEvent();
     pad.onConnectEvent = Util.mkEvent();
     pad.onErrorEvent = Util.mkEvent();
+    pad.onMetadataEvent = Util.mkEvent();
 
     pad.getPadMetadata = function (data, cb) {
         postMessage('GET_PAD_METADATA', data, cb);
@@ -1208,6 +1209,7 @@ define([
         PAD_DISCONNECT: common.padRpc.onDisconnectEvent.fire,
         PAD_CONNECT: common.padRpc.onConnectEvent.fire,
         PAD_ERROR: common.padRpc.onErrorEvent.fire,
+        PAD_METADATA: common.padRpc.onMetadataEvent.fire,
         // Drive
         DRIVE_LOG: common.drive.onLog.fire,
         DRIVE_CHANGE: common.drive.onChange.fire,
diff --git a/www/common/outer/async-store.js b/www/common/outer/async-store.js
index a293de8e4..36954bcf5 100644
--- a/www/common/outer/async-store.js
+++ b/www/common/outer/async-store.js
@@ -1205,7 +1205,6 @@ define([
                     }
                 },
                 onMetadataUpdate: function (metadata) {
-                    console.log('onMetadataUpdate', metadata);
                     channel.data = metadata || {};
                     var allData = store.manager.findChannel(data.channel);
                     allData.forEach(function (obj) {
@@ -1214,7 +1213,7 @@ define([
                             obj.data.expire = +metadata.expire;
                         }
                     });
-                    //channel.bcast("PAD_METADATA", metadata);
+                    channel.bcast("PAD_METADATA", metadata);
                 },
                 crypto: {
                     // The encryption and decryption is done in the outer window.
@@ -1374,7 +1373,6 @@ define([
         };
 
         Store.getPadMetadata = function (clientId, data, cb) {
-            console.log(data);
             if (!data.channel) { return void cb({ error: 'ENOTFOUND'}); }
             var channel = channels[data.channel];
             if (!channel) { return void cb({ error: 'ENOTFOUND' }); }
@@ -1397,7 +1395,6 @@ define([
             cb(channel.data || {});
         };
         Store.setPadMetadata = function (clientId, data, cb) {
-            console.log(data);
             if (!data.channel) { return void cb({ error: 'ENOTFOUND'}); }
             if (!data.command) { return void cb({ error: 'EINVAL' }); }
             store.rpc.setMetadata(data, function (err, res) {
diff --git a/www/common/proxy-manager.js b/www/common/proxy-manager.js
index 5cfae1a38..9ef3a9563 100644
--- a/www/common/proxy-manager.js
+++ b/www/common/proxy-manager.js
@@ -742,7 +742,7 @@ define([
         datas.forEach(function (d) {
             var atime = d.data.atime;
 
-            var value = attr ? d.data[attr] : JSON.parse(JSON.stringify(d.data));
+            var value = data.attr ? d.data[data.attr] : JSON.parse(JSON.stringify(d.data));
             if (!res.value || res.atime < atime) {
                 res.atime = atime;
                 res.value = value;
diff --git a/www/common/sframe-chainpad-netflux-outer.js b/www/common/sframe-chainpad-netflux-outer.js
index 9dbfb1816..9e3b957fc 100644
--- a/www/common/sframe-chainpad-netflux-outer.js
+++ b/www/common/sframe-chainpad-netflux-outer.js
@@ -118,6 +118,10 @@ define([], function () {
             onOpen(data);
         });
 
+        padRpc.onMetadataEvent.reg(function (data) {
+            sframeChan.event('EV_RT_METADATA', data);
+        });
+
         padRpc.onErrorEvent.reg(function (err) {
             sframeChan.event('EV_RT_ERROR', err);
         });
diff --git a/www/common/sframe-common-outer.js b/www/common/sframe-common-outer.js
index 2a03392be..ba6a7d481 100644
--- a/www/common/sframe-common-outer.js
+++ b/www/common/sframe-common-outer.js
@@ -1025,7 +1025,6 @@ define([
                         channel: secret.channel
                     };
                 }
-                console.log(data);
                 Cryptpad.getPadMetadata(data, cb);
             });
             sframeChan.on('Q_SET_PAD_METADATA', function (data, cb) {

From c4dcfc9ccfaa99b91a1e4611eeea0c6cd4108e8d Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Tue, 3 Sep 2019 13:45:32 +0200
Subject: [PATCH 10/16] Fix redraw ownership modal in drive

---
 www/common/common-ui-elements.js | 8 ++++++--
 www/drive/inner.js               | 1 -
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/www/common/common-ui-elements.js b/www/common/common-ui-elements.js
index f4f5108e6..3683f567a 100644
--- a/www/common/common-ui-elements.js
+++ b/www/common/common-ui-elements.js
@@ -111,7 +111,7 @@ define([
         // Remove owner column
         var drawRemove = function (pending) {
             var _owners = {};
-            var o = pending ? pending_owners : owners;
+            var o = (pending ? pending_owners : owners) || [];
             o.forEach(function (ed) {
                 var f;
                 Object.keys(friends).some(function (c) {
@@ -189,6 +189,7 @@ define([
                         err = err || (res && res.error);
                         if (err) {
                             waitFor.abort();
+                            redrawAll();
                             return void UI.warn('ERROR' + err);
                         } // XXX
                         UI.log('DONE'); // XXX
@@ -280,6 +281,7 @@ define([
                         err = err || (res && res.error);
                         if (err) {
                             waitFor.abort();
+                            redrawAll();
                             return void UI.warn('ERROR' + err);
                         } // XXX
                     }));
@@ -318,7 +320,9 @@ define([
         redrawAll = function () {
             if (pending) { return; }
             pending = true;
-            common.getPadMetadata(null, function (obj) {
+            common.getPadMetadata({
+                channel: data.channel
+            }, function (obj) {
                 pending = false;
                 if (obj && obj.error) { return; }
                 owners = obj.owners;
diff --git a/www/drive/inner.js b/www/drive/inner.js
index 138d01f3d..1eb411023 100644
--- a/www/drive/inner.js
+++ b/www/drive/inner.js
@@ -3719,7 +3719,6 @@ define([
                 sframeChan.query('Q_GET_PAD_METADATA', {
                     channel: data.channel
                 }, function (err, val) {
-                    console.log(arguments);
                     if (!err && !(val && val.error)) {
                         data.owners = val.owners;
                         data.expire = val.expire;

From 4027672678c88b3dfd17a8a201b86f968bf3f607 Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Tue, 3 Sep 2019 15:11:23 +0200
Subject: [PATCH 11/16] Store the mailbox of all the owners

---
 lib/metadata.js                   | 41 +++++++++++++++++++++++++++++++
 www/common/common-ui-elements.js  | 33 +++++++++++++------------
 www/common/sframe-common-outer.js | 37 +++++++++++++++++++++++++---
 3 files changed, 92 insertions(+), 19 deletions(-)

diff --git a/lib/metadata.js b/lib/metadata.js
index fb8628410..63ab31819 100644
--- a/lib/metadata.js
+++ b/lib/metadata.js
@@ -55,6 +55,13 @@ commands.RM_OWNERS = function (meta, args) {
     args.forEach(function (owner) {
         var index = meta.owners.indexOf(owner);
         if (index < 0) { return; }
+        if (meta.mailbox) {
+            if (typeof(meta.mailbox) === "string") {
+                delete meta.mailbox;
+            } else {
+                delete meta.mailbox[owner];
+            }
+        }
         meta.owners.splice(index, 1);
         changed = true;
     });
@@ -131,6 +138,40 @@ commands.RESET_OWNERS = function (meta, args) {
     return true;
 };
 
+// ["ADD_MAILBOX", {"7eEqelGso3EBr5jHlei6av4r9w2B9XZiGGwA1EgZ-5I=": mailbox, ...}, 1561623439989]
+commands.ADD_MAILBOX = function (meta, args) {
+    // expect a new array, even if it's empty
+    if (!args || typeof(args) !== "object") {
+        throw new Error('METADATA_INVALID_MAILBOX');
+    }
+    // assume there are owners to start
+    if (!Array.isArray(meta.owners)) {
+        throw new Error("METADATA_NONSENSE_OWNERS");
+    }
+
+    var changed = false;
+
+    // For each mailbox we try to add, check if the associated edPublic is an owner
+    // If they are, add or replace the mailbox
+    Object.keys(args).forEach(function (edPublic) {
+        if (meta.owners.indexOf(edPublic) === -1) { return; }
+
+        if (typeof(meta.mailbox) === "string") {
+            var str = meta.mailbox;
+            meta.mailbox = {};
+            meta.mailbox[meta.owners[0]] = str;
+        }
+
+        // Make sure mailbox is defined
+        if (!meta.mailbox) { meta.mailbox = {}; }
+
+        meta.mailbox[edPublic] = args[edPublic];
+        changed = true;
+    });
+
+    return changed;
+};
+
 commands.UPDATE_EXPIRATION = function () {
     throw new Error("E_NOT_IMPLEMENTED");
 };
diff --git a/www/common/common-ui-elements.js b/www/common/common-ui-elements.js
index 3683f567a..293931a60 100644
--- a/www/common/common-ui-elements.js
+++ b/www/common/common-ui-elements.js
@@ -98,8 +98,8 @@ define([
         var user = common.getMetadataMgr().getUserData();
         var edPublic = priv.edPublic;
         var channel = data.channel;
-        var owners = data.owners;
-        var pending_owners = data.pending_owners;
+        var owners = data.owners || [];
+        var pending_owners = data.pending_owners || [];
 
         var redrawAll = function () {};
 
@@ -316,22 +316,21 @@ define([
             return $div2;
         };
 
-        var pending = false;
-        redrawAll = function () {
-            if (pending) { return; }
-            pending = true;
-            common.getPadMetadata({
-                channel: data.channel
-            }, function (obj) {
-                pending = false;
+        redrawAll = function (md) {
+            var todo = function (obj) {
                 if (obj && obj.error) { return; }
-                owners = obj.owners;
-                pending_owners = obj.pending_owners;
+                owners = obj.owners || [];
+                pending_owners = obj.pending_owners || [];
                 $div1.empty();
                 $div2.empty();
                 $div1.append(drawRemove(false)).append(drawRemove(true));
                 $div2.append(drawAdd());
-            });
+            };
+
+            if (md) { return void todo(md); }
+            common.getPadMetadata({
+                channel: data.channel
+            }, todo);
         };
 
         $div1.append(drawRemove(false)).append(drawRemove(true));
@@ -341,9 +340,9 @@ define([
             if (!$div1.length) {
                 return void handler.stop();
             }
-            owners = md.owners;
-            pending_owners = md.pending_owners;
-            redrawAll();
+            owners = md.owners || [];
+            pending_owners = md.pending_owners || [];
+            redrawAll(md);
         });
 
         // Create modal
@@ -3394,6 +3393,8 @@ define([
                     data.metadata = res;
 
                     // Add the pad to your drive
+                    // This command will also add your mailbox to the metadata log
+                    // The callback is called when the pad is stored, independantly of the metadata command
                     sframeChan.query('Q_ACCEPT_OWNERSHIP', data, function (err, res) {
                         if (err || (res && res.error)) {
                             return void console.error(err | res.error);
diff --git a/www/common/sframe-common-outer.js b/www/common/sframe-common-outer.js
index ba6a7d481..3c13e0e8e 100644
--- a/www/common/sframe-common-outer.js
+++ b/www/common/sframe-common-outer.js
@@ -489,6 +489,28 @@ define([
                 Cryptpad.setPadTitle(_data, function (err) {
                     cb({error: err});
                 });
+
+                // Also add your mailbox to the metadata object
+                var padParsed = Utils.Hash.parsePadUrl(data.href);
+                var padSecret = Utils.Hash.getSecrets(padParsed.type, padParsed.hash, data.password);
+                var padCrypto = Utils.Crypto.createEncryptor(padSecret.keys);
+                try {
+                    var value = {};
+                    value[edPublic] = padCrypto.encrypt(JSON.stringify({
+                        notifications: notifications,
+                        curvePublic: curvePublic
+                    }));
+                    var msg = {
+                        channel: data.channel,
+                        command: 'ADD_MAILBOX',
+                        value: value
+                    };
+                    Cryptpad.setPadMetadata(msg, function (res) {
+                        if (res.error) { console.error(res.error); }
+                    });
+                } catch (err) {
+                    return void console.error(err);
+                }
             });
 
             sframeChan.on('Q_IMPORT_MEDIATAG', function (obj, cb) {
@@ -1001,9 +1023,17 @@ define([
                     }, waitFor(function (obj) {
                         obj = obj || {};
                         if (obj.error) { return; }
-                        if (obj.mailbox) {
+                        var mailbox;
+                        // Get the first available mailbox (the field can be an string or an object)
+                        // TODO maybe we should send the request to all the owners?
+                        if (typeof (obj.mailbox) === "string") {
+                            mailbox = obj.mailbox;
+                        } else if (obj.mailbox && obj.owners && obj.owners.length) {
+                            mailbox = obj.mailbox[obj.owners[0]];
+                        }
+                        if (mailbox) {
                             try {
-                                var dataStr = crypto.decrypt(obj.mailbox, true, true);
+                                var dataStr = crypto.decrypt(mailbox, true, true);
                                 var data = JSON.parse(dataStr);
                                 if (!data.notifications || !data.curvePublic) { return; }
                                 owner = data;
@@ -1156,7 +1186,8 @@ define([
                 };
                 if (data.owned) {
                     rtConfig.metadata.owners = [edPublic];
-                    rtConfig.metadata.mailbox = Utils.crypto.encrypt(JSON.stringify({
+                    rtConfig.metadata.mailbox = {};
+                    rtConfig.metadata.mailbox[edPublic] = Utils.crypto.encrypt(JSON.stringify({
                         notifications: notifications,
                         curvePublic: curvePublic
                     }));

From 2eafb2190c126f3ea49a5186b7ee8880ca4b01af Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Tue, 3 Sep 2019 15:12:09 +0200
Subject: [PATCH 12/16] Remove XXX

---
 www/common/proxy-manager.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/www/common/proxy-manager.js b/www/common/proxy-manager.js
index 9ef3a9563..1db67f680 100644
--- a/www/common/proxy-manager.js
+++ b/www/common/proxy-manager.js
@@ -492,8 +492,8 @@ define([
             _addSharedFolder(Env, {
                 path: parentPath,
                 name: folderName,
-                owned: data.owned, // XXX FIXME hardcoded preference
-                password: data.password || '', // XXX FIXME hardcoded preference
+                owned: data.owned,
+                password: data.password || '',
             }, waitFor(function (id) {
                 // _addSharedFolder can be an id or an error
                 if (typeof(id) === 'object' && id && id.error) {

From c64adea8ffd5a7531cfcd78f471848913432a355 Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Tue, 3 Sep 2019 15:28:23 +0200
Subject: [PATCH 13/16] Translation keys

---
 www/common/common-ui-elements.js | 51 ++++++++++++++++----------------
 www/common/notifications.js      |  5 ----
 2 files changed, 26 insertions(+), 30 deletions(-)

diff --git a/www/common/common-ui-elements.js b/www/common/common-ui-elements.js
index 293931a60..d73977572 100644
--- a/www/common/common-ui-elements.js
+++ b/www/common/common-ui-elements.js
@@ -127,13 +127,13 @@ define([
                     }
                 }
                 _owners[ed] = f || {
-                    displayName: 'Unknown user: '+ ed, // XXX
+                    displayName: Messages._getKey('owner_unknownUser', [ed]),
                     notifications: true,
                     edPublic: ed,
                 };
             });
-            var msg = pending ? 'Remove a pending owner:'
-                        : 'Remove an existing owner:'; // XXX
+            var msg = pending ? Messages.owner_removePendingText
+                        : Messages.owner_removeText
             var removeCol = UIElements.getFriendsList(msg, {
                 common: common,
                 friends: _owners,
@@ -156,7 +156,7 @@ define([
             });
             // When clicking on the remove button, we check the selected users.
             // If you try to remove yourself, we'll display an additional warning message
-            var btnMsg = pending ? 'Remove pending owners' : 'Remove owners'; // XXX
+            var btnMsg = pending ? Messages.owner_removePendingButton : Messages.owner_removeButton;
             var removeButton = h('button.no-margin', btnMsg);
             $(removeButton).click(function () {
                 // Check selection
@@ -170,9 +170,7 @@ define([
                     return ed;
                 }).filter(function (x) { return x; });
                 NThen(function (waitFor) {
-                    var msg = me ?
-                      "Are you sure? You're going to give up on your rights, this can't be undone!" :
-                      "Are you sure?"; // XXX
+                    var msg = me ? Messages.owner_removeMeConfirm : Messages.owner_removeConfirm;
                     UI.confirm(msg, waitFor(function (yes) {
                         if (!yes) {
                             waitFor.abort();
@@ -190,9 +188,11 @@ define([
                         if (err) {
                             waitFor.abort();
                             redrawAll();
-                            return void UI.warn('ERROR' + err);
-                        } // XXX
-                        UI.log('DONE'); // XXX
+                            var text = err === "INSUFFICIENT_PERMISSIONS" ? Messages.fm_forbidden
+                                                                          : Messages.error;
+                            return void UI.warn(text);
+                        }
+                        UI.log(Messages.saved);
                     }));
                 }).nThen(function (waitFor) {
                     sel.forEach(function (el) {
@@ -232,12 +232,11 @@ define([
                     delete _friends[curve];
                 }
             });
-            var addCol = UIElements.getFriendsList('Ask a friend to be an owner.', {
+            var addCol = UIElements.getFriendsList(Messages.owner_addText, {
                 common: common,
                 friends: _friends
             }, function () {
-                // XXX onSelect...
-                console.log(arguments);
+                //console.log(arguments);
             });
             $div2 = $(addCol.div);
             var others2 = addCol.others;
@@ -251,10 +250,9 @@ define([
                     order = order ? 'order:'+order : '';
                     $(this).removeClass('cp-selected').attr('style', order);
                 }
-                // XXX onSelect...
             });
             // When clicking on the add button, we get the selected users.
-            var addButton = h('button.no-margin', 'Add owners'); // XXX
+            var addButton = h('button.no-margin', Messages.owner_addButton);
             $(addButton).click(function () {
                 // Check selection
                 var $sel = $div2.find('.cp-share-friend.cp-selected');
@@ -264,7 +262,7 @@ define([
                 }).filter(function (x) { return x; });
 
                 NThen(function (waitFor) {
-                    var msg = "Are you sure?"; // XXX
+                    var msg = Messages.owner_addConfirm;
                     UI.confirm(msg, waitFor(function (yes) {
                         if (!yes) {
                             waitFor.abort();
@@ -282,8 +280,10 @@ define([
                         if (err) {
                             waitFor.abort();
                             redrawAll();
-                            return void UI.warn('ERROR' + err);
-                        } // XXX
+                            var text = err === "INSUFFICIENT_PERMISSIONS" ? Messages.fm_forbidden
+                                                                          : Messages.error;
+                            return void UI.warn(text);
+                        }
                     }));
                 }).nThen(function (waitFor) {
                     sel.forEach(function (el) {
@@ -309,7 +309,7 @@ define([
                     });
                 }).nThen(function () {
                     redrawAll();
-                    UI.log('DONE'); // XXX
+                    UI.log(Messages.saved);
                 });
             });
             $div2.append(h('p', addButton));
@@ -354,7 +354,7 @@ define([
         ]);
         var linkButtons = [{
             className: 'cancel',
-            name: 'CLOSE', // XXX existing key?
+            name: Messages.filePicker_close,
             onClick: function () {},
             keys: [27]
         }];
@@ -403,7 +403,7 @@ define([
                 id: 'cp-app-prop-owners',
             }));
             if (owned) {
-                var manageOwners = h('button.no-margin', 'Manage owners'); // XXX
+                var manageOwners = h('button.no-margin', Messages.owner_openModalButton);
                 $(manageOwners).click(function () {
                     var modal = createOwnerModal(common, data);
                     UI.openCustomModal(modal, {
@@ -3325,7 +3325,6 @@ define([
         var name = Util.fixHTML(msg.content.user.displayName) || Messages.anonymous;
         var title = Util.fixHTML(msg.content.title);
 
-        Messages.owner_add = '{0} wants you to be an owner of the pad <b>{1}</b>. Do you accept?'; //XXX
         var text = Messages._getKey('owner_add', [name, title]);
 
         var link = h('a', {
@@ -3382,9 +3381,11 @@ define([
                 }, function (err, res) {
                     err = err || (res && res.error);
                     if (err) {
-                        return void UI.warn('ERROR ' + err);
-                    } // XXX
-                    UI.log('DONE'); // XXX
+                        var text = err === "INSUFFICIENT_PERMISSIONS" ? Messages.fm_forbidden
+                                                                      : Messages.error;
+                        return void UI.warn(text);
+                    }
+                    UI.log(Messages.saved);
 
                     // Send notification to the sender
                     answer(true);
diff --git a/www/common/notifications.js b/www/common/notifications.js
index ef64c303a..9dfce68e4 100644
--- a/www/common/notifications.js
+++ b/www/common/notifications.js
@@ -218,7 +218,6 @@ define([
         // Display the notification
         var name = Util.fixHTML(msg.content.user.displayName) || Messages.anonymous;
         var title = Util.fixHTML(msg.content.title);
-        Messages.owner_request = '{0} wants you to be an owner of <b>{1}</b>'; // XXX
         content.getFormatText = function () {
             return Messages._getKey('owner_request', [name, title]);
         };
@@ -241,8 +240,6 @@ define([
         // Display the notification
         var name = Util.fixHTML(msg.content.user.displayName) || Messages.anonymous;
         var title = Util.fixHTML(msg.content.title);
-        Messages.owner_request_accepted = '{0} has accepted your offer to be an owner of <b>{1}</b>'; // XXX
-        Messages.owner_request_declined = '{0} has declined your offer to be an owner of <b>{1}</b>'; // XXX
         var key = 'owner_request_' + (msg.content.answer ? 'accepted' : 'declined');
         content.getFormatText = function () {
             return Messages._getKey(key, [name, title]);
@@ -259,8 +256,6 @@ define([
         // Display the notification
         var name = Util.fixHTML(msg.content.user.displayName) || Messages.anonymous;
         var title = Util.fixHTML(msg.content.title);
-        Messages.owner_removed = '{0} has removed your ownership of <b>{1}</b>'; // XXX
-        Messages.owner_removedPending = '{0} has removed your pending ownership of <b>{1}</b>'; // XXX
         var key = 'owner_removed' + (msg.content.pending ? 'Pending' : '');
         content.getFormatText = function () {
             return Messages._getKey(key, [name, title]);

From e15b57989b37c00ab1083752a22a402770ea30e8 Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Tue, 3 Sep 2019 16:40:09 +0200
Subject: [PATCH 14/16] Fix UI issues

---
 customize.dist/src/less2/include/alertify.less | 9 +++++++++
 www/common/common-ui-elements.js               | 7 ++++---
 2 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/customize.dist/src/less2/include/alertify.less b/customize.dist/src/less2/include/alertify.less
index c73c27c78..683584461 100644
--- a/customize.dist/src/less2/include/alertify.less
+++ b/customize.dist/src/less2/include/alertify.less
@@ -462,6 +462,10 @@
                 }
             }
             margin-bottom: 15px;
+            &:empty {
+                margin: 0;
+                display: none;
+            }
         }
         .cp-share-friend {
             width: 70px;
@@ -493,6 +497,11 @@
                 visibility: hidden;
             }
         }
+        .cp-ownership {
+            & > label {
+                font-weight: bold;
+            }
+        }
     }
 }
 
diff --git a/www/common/common-ui-elements.js b/www/common/common-ui-elements.js
index d73977572..ac855f5c5 100644
--- a/www/common/common-ui-elements.js
+++ b/www/common/common-ui-elements.js
@@ -103,8 +103,8 @@ define([
 
         var redrawAll = function () {};
 
-        var div1 = h('div.cp-share-friends.cp-share-column');
-        var div2 = h('div.cp-share-friends.cp-share-column');
+        var div1 = h('div.cp-share-friends.cp-share-column.cp-ownership');
+        var div2 = h('div.cp-share-friends.cp-share-column.cp-ownership');
         var $div1 = $(div1);
         var $div2 = $(div2);
 
@@ -139,7 +139,6 @@ define([
                 friends: _owners,
                 noFilter: true
             }, function () {
-                console.log(arguments);
             });
             var $div = $(removeCol.div);
             var others1 = removeCol.others;
@@ -162,6 +161,7 @@ define([
                 // Check selection
                 var $sel = $div.find('.cp-share-friend.cp-selected');
                 var sel = $sel.toArray();
+                if (!sel.length) { return; }
                 var me = false;
                 var toRemove = sel.map(function (el) {
                     var ed = $(el).attr('data-ed');
@@ -256,6 +256,7 @@ define([
             $(addButton).click(function () {
                 // Check selection
                 var $sel = $div2.find('.cp-share-friend.cp-selected');
+                if (!sel.length) { return; }
                 var sel = $sel.toArray();
                 var toAdd = sel.map(function (el) {
                     return friends[$(el).attr('data-curve')].edPublic;

From e2178f5aa76920897f2451bf99bec8b7d7aaa69b Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Tue, 3 Sep 2019 17:03:30 +0200
Subject: [PATCH 15/16] French translation (weblate is slow)

---
 www/common/translations/messages.fr.json | 23 ++++++++++++++++++++++-
 1 file changed, 22 insertions(+), 1 deletion(-)

diff --git a/www/common/translations/messages.fr.json b/www/common/translations/messages.fr.json
index 1fb078376..89e20f810 100644
--- a/www/common/translations/messages.fr.json
+++ b/www/common/translations/messages.fr.json
@@ -1138,5 +1138,26 @@
     "homePage": "Page d'accueil",
     "features_noData": "Aucune donnée personnelle requise",
     "features_pricing": "Entre {0} et {2}€ par mois",
-    "features_emailRequired": "Adresse email requise"
+    "features_emailRequired": "Adresse email requise",
+    "register_emailWarning0": "Il semble que vous ayez entré votre adresse email à la place du nom d'utilisateur.",
+    "register_emailWarning1": "Vous pouvez continuer, mais ces données ne sont pas nécessaires et ne seront pas envoyées à notre serveur.",
+    "register_emailWarning2": "Vous ne pourrez pas réinitialiser votre mot de passe en utilisant votre adresse email comme sur beaucoup d'autres services",
+    "register_emailWarning3": "Si vous souhaitez tout de même utiliser votre adresse email comme nom d'utilisateur, appuyez sur OK",
+    "owner_removeText": "Supprimer un propriétaire existant",
+    "owner_removePendingText": "Annuler une offre en attente",
+    "owner_addText": "Proposer à un ami d'être co-propriétaire de ce document",
+    "owner_unknownUser": "Utilisateur inconnu",
+    "owner_removeButton": "Supprimer les propriétaires sélectionnés",
+    "owner_removePendingButton": "Annuler les offres sélectionnées",
+    "owner_addButton": "Proposer la co-propriété",
+    "owner_removeConfirm": "Êtes-vous sûr de vouloir suppprimer les droits de propriétaire pour les utilisateurs sélectionnés ? Ils seront notifiés de cette action.",
+    "owner_removeMeConfirm": "Vous êtes sur le point de renoncer à vos droits de propriétaire. Vous ne serez pas en mesure d'annuler cette action. Continuer ?",
+    "owner_addConfirm": "Les co-propriétaires seront en mesure de changer le contenu du document et pourront supprimer vos droits de propriétaire. Continuer ?",
+    "owner_openModalButton": "Gérer les propriétaires",
+    "owner_add": "{0} souhaite que vous soyez propriétaire du pad <b>{1}</b>. Acceptez-vous ?",
+    "owner_request": "{0} souhaite que vous soyez propriétaire de <b>{1}</b>",
+    "owner_request_accepted": "{0} a accepté votre offre de devenir propriétaire de <b>{1}</b>",
+    "owner_request_declined": "{0} a refusé votre offre de devenir propriétaire de <b>{1}</b>",
+    "owner_removed": "{0} a supprimé vos droits de propriétaire de <b>{1}</b>",
+    "owner_removedPending": "{0} a annulé l'offre de co-propriété reçue pour <b>{1}</b>"
 }

From 2b4c615cd4e94acb943bffad540e4d6249ad1ac3 Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Tue, 3 Sep 2019 17:06:29 +0200
Subject: [PATCH 16/16] lint compliance

---
 www/common/common-ui-elements.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/www/common/common-ui-elements.js b/www/common/common-ui-elements.js
index ac855f5c5..bdfa56d7d 100644
--- a/www/common/common-ui-elements.js
+++ b/www/common/common-ui-elements.js
@@ -133,7 +133,7 @@ define([
                 };
             });
             var msg = pending ? Messages.owner_removePendingText
-                        : Messages.owner_removeText
+                        : Messages.owner_removeText;
             var removeCol = UIElements.getFriendsList(msg, {
                 common: common,
                 friends: _owners,
@@ -256,8 +256,8 @@ define([
             $(addButton).click(function () {
                 // Check selection
                 var $sel = $div2.find('.cp-share-friend.cp-selected');
-                if (!sel.length) { return; }
                 var sel = $sel.toArray();
+                if (!sel.length) { return; }
                 var toAdd = sel.map(function (el) {
                     return friends[$(el).attr('data-curve')].edPublic;
                 }).filter(function (x) { return x; });