infra
/
cryptpad
2
1
Fork 0
Code Issues Pull Requests Projects Releases 1 Activity

Merge branch 'staging' into c

pull/1/head
yflory 2021-02-24 10:08:39 +01:00
parent 3d4adb4598 c84ecbabc0
commit 6cbeb9c28f
8 changed files with 154 additions and 48 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CHANGELOG.md
View File

@ -56,6 +56,10 @@
* refactor /assert/
* introduce /checkup/ page for detecting incorrect instance configuration
* fix tippy popper color
* loss of access to shared folders
* related to access lists and the offline cache
* remove old and unused translations
* fix plaintext colors in file app
# 4.1.0 (B)

57
customize.dist/src/less2/pages/page-checkup.less Normal file
View File

@ -0,0 +1,57 @@
@import (reference) "../include/colortheme-all.less";
@import (reference) "../include/font.less";
//@import (reference) "../include/forms.less";
@import (reference) "../include/alertify.less";
html, body {
.font_main();
.alertify_main();
height: 100%;
margin: 0px;
padding: 0px;
background-color: @cp_static-bg !important;
color: @cryptpad_text_col;
font-family: "IBM Plex Mono";
.report {
font-size: 30px;
max-width: 50%;
margin: auto;
padding-top: 15px;
}
.success {
border: 1px solid green;
}
.failure {
border: 1px solid red;
}
.error {
border: 1px solid red;
}
.hidden {
display: none;
}
.failures div.error, .summary {
padding: 15px;
}
table {
td {
padding: 5px;
border: 1px solid white;
}
}
.advisory-text {
display: inline-block;
word-break: break-all;
padding: 5px;
//font-size: 16px;
border: 1px solid red;
background-color: @cp_alerts-danger-bg;
color: @cp_alerts-danger-text;
}
}

20
www/checkup/index.html
View File

@ -4,26 +4,6 @@
<meta content="text/html; charset=utf-8" http-equiv="content-type"/>
<meta name="viewport" content="width=device-width, initial-scale=1.0"/>
<script data-bootload="main.js" data-main="/common/boot.js" src="/bower_components/requirejs/require.js"></script>
<style>
.report {
font-size: 40px;
}
.success {
border: 3px solid green;
}
.failure {
border: 3px solid red;
}
.error {
border: 1px solid red;
}
.hidden {
display: none;
}
</style>
</head>
<body>

94
www/checkup/main.js
View File

@ -4,25 +4,74 @@ define([
'/assert/assertions.js',
'/common/hyperscript.js',
'/customize/messages.js',
'/common/sframe-common-outer.js',
'/bower_components/tweetnacl/nacl-fast.min.js',
'less!/customize/src/less2/pages/page-assert.less',
], function ($, ApiConfig, Assertions, h, Messages) {
'less!/customize/src/less2/pages/page-checkup.less',
], function ($, ApiConfig, Assertions, h, Messages, SFCommonO) {
var assert = Assertions();
assert(function (cb) {
var c = ApiConfig;
cb(Boolean(c.httpUnsafeOrigin && c.httpSafeOrigin));
}, "Sandbox configuration: ensure that both httpUnsafeOrigin and httpSafeOrigin are defined"); // XXX
var trimSlashes = function (s) {
if (typeof(s) !== 'string') { return s; }
return s.replace(/\/+$/, '');
};
var _alert = function (content) {
return h('span.advisory-text', content);
};
var trimmedSafe = trimSlashes(ApiConfig.httpSafeOrigin);
var trimmedUnsafe = trimSlashes(ApiConfig.httpUnsafeOrigin);
assert(function (cb) {
var c = ApiConfig;
return void cb(c.httpUnsafeOrigin !== c.httpSafeOrigin);
}, 'Sandbox configuration: httpUnsafeOrigin !== httpSafeOrigin'); // XXX
//console.error(trimmedSafe, trimmedUnsafe);
cb(Boolean(trimmedSafe && trimmedUnsafe));
}, _alert("Sandbox configuration: ensure that both httpUnsafeOrigin and httpSafeOrigin are defined"));
assert(function (cb) {
return void cb(trimmedSafe !== trimmedUnsafe);
}, _alert('Sandbox configuration: httpUnsafeOrigin !== httpSafeOrigin'));
assert(function (cb) {
cb((window.location.origin + '/') === ApiConfig.httpUnsafeOrigin);
}, 'Sandbox configuration: loading via httpUnsafeOrigin'); // XXX
}, _alert('Sandbox configuration: loading via httpUnsafeOrigin'));
var checkAvailability = function (url, cb) {
$.ajax({
url: url,
date: {},
complete: function (xhr) {
cb(xhr.status === 200);
},
});
};
assert(function (cb) {
checkAvailability(trimmedUnsafe, cb);
}, _alert("Main domain is not available"));
assert(function (cb) {
console.log(trimmedSafe);
checkAvailability(trimmedSafe, cb);
}, _alert("Sandbox domain is not available")); // XXX Blocked by CSP. try loading it via sframe ?
var row = function (cells) {
return h('tr', cells.map(function (cell) {
return h('td', cell);
}));
};
var failureReport = function (obj) {
return h('div.error', [
h('h5', obj.message),
h('table', [
row(["Failed test number", obj.test + 1]),
row(["Returned value", obj.output]),
]),
]);
};
assert.run(function (state) {
var errors = state.errors;
@ -31,19 +80,20 @@ define([
Messages.assert_numberOfTestsPassed = "{0} / {1} tests passed.";
var statusClass = failed? 'failure': 'success';
$('body').prepend(h('div.report.' + statusClass, [
Messages._getKey('assert_numberOfTestsPassed', [
var summary = h('div.summary.' + statusClass, [
h('p', Messages._getKey('assert_numberOfTestsPassed', [
state.passed,
state.total
]),
h('div.failures', errors.map(function (obj) {
return h('p.error', [
h('p', "Test number: " + obj.test),
h('p', "Error message: " + obj.message),
h('p', "Returned value: " + obj.output),
h('br'),
]);
})),
]));
])),
h('p', "Details found below"),
]);
var report = h('div.report', [
summary,
h('div.failures', errors.map(failureReport)),
]);
$('body').prepend(report);
});
});

3
www/common/outer/async-store.js
View File

@ -67,6 +67,8 @@ define([
modules: {}
};
Store.onReadyEvt = onReadyEvt;
var getStore = function (teamId) {
if (!teamId) { return store; }
try {
@ -2247,6 +2249,7 @@ define([
isNew: isNew,
network: store.network || store.networkPromise,
store: s,
Store: Store,
isNewChannel: Store.isNewChannel
}, id, data, cb);
};

17
www/common/outer/sharedfolder.js
View File

@ -164,6 +164,16 @@ define([
readOnly: !Boolean(secondaryKey)
};
// If there is an allow list and we're offline, try again when we're synced
var onRejected = function (allowed, _cb) {
var cb = Util.once(Util.mkAsync(_cb));
if (store.offline && config.Store) {
config.Store.onReadyEvt.reg(cb);
return;
}
cb('ERESTRICTED');
};
var owners = data.owners;
var listmapConfig = {
data: {},
@ -179,7 +189,8 @@ define([
metadata: {
validateKey: secret.keys.validateKey || undefined,
owners: owners
}
},
onRejected: onRejected
};
var rt = sf.rt = Listmap.create(listmapConfig);
rt.proxy.on('cacheready', function () {
@ -246,8 +257,6 @@ define([
return void cb();
}
if (info.error === "ERESTRICTED" ) {
// This shouldn't happen: allow list are disabled for shared folders
// but call "cb" to make sure we won't block the initial "waitFor"
sf.teams.forEach(function (obj) {
obj.store.manager.restrictedProxy(obj.id, secret.channel);
});
@ -326,6 +335,7 @@ define([
network: network,
store: s,
updatePassword: true,
Store: Store,
isNewChannel: Store.isNewChannel
}, sfId, sf, waitFor());
if (!s.rpc) { return; }
@ -356,6 +366,7 @@ define([
SF.load({
network: network,
store: store,
Store: Store,
isNewChannel: Store.isNewChannel
}, id, sf, waitFor(function () {
progress({

3
www/common/outer/team.js
View File

@ -277,7 +277,8 @@ define([
isNew: isNew,
network: ctx.store.network || ctx.store.networkPromise,
store: team,
isNewChannel: ctx.Store.isNewChannel
isNewChannel: ctx.Store.isNewChannel,
Store: ctx.Store
}, id, data, cb);
};
var teamData = ctx.store.proxy.teams[team.id];

4
www/file/app-file.less
View File

@ -58,8 +58,8 @@
width: 90vw;
height: 100%;
padding: 2em;
background-color: @cp_mediatag-text-bg;
color: @cp_mediatag-text-fg;
background-color: @cp_markdown-block-bg;
color: @cp_markdown-block-fg;
overflow-y: auto;
word-wrap: break-word;
white-space: pre-wrap;