From 67cdb6bd13b0aa09dfd8b51438bacaa7cdb6c270 Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Mon, 19 Mar 2018 17:25:31 +0100
Subject: [PATCH] Fix initial values in the pad creation screen

---
 www/common/common-ui-elements.js | 43 ++------------------------------
 www/common/sframe-common.js      |  1 -
 2 files changed, 2 insertions(+), 42 deletions(-)

diff --git a/www/common/common-ui-elements.js b/www/common/common-ui-elements.js
index 877bea596..bb285e3dc 100644
--- a/www/common/common-ui-elements.js
+++ b/www/common/common-ui-elements.js
@@ -1947,7 +1947,6 @@ define([
                     'class': 'cp-creation-template-element',
                     'title': name,
                 }).appendTo($container);
-                console.log(obj.id);
                 $span.data('id', obj.id);
                 if (idx === 0) { $span.addClass('cp-creation-template-selected'); }
                 $span.append(obj.icon || UI.getFileIcon({type: type}));
@@ -2015,10 +2014,10 @@ define([
 
         // Initial values
         if (!cfg.owned && typeof cfg.owned !== "undefined") {
-            $creation.find('#cp-creation-owned').attr('checked', false);
+            $creation.find('#cp-creation-owned').prop('checked', false);
         }
         if (cfg.skip) {
-            $creation.find('#cp-creation-remember').attr('checked', 'checked');
+            $creation.find('#cp-creation-remember').prop('checked', true).trigger('change');
         }
         UIElements.setExpirationValue(cfg.expire, $creation);
 
@@ -2079,44 +2078,6 @@ define([
             create();
         });
 
-        // Save settings button
-        /*var $ok = $('<span>', {'class': 'fa fa-check', title: Messages.saved}).hide();
-        var $spinner = $('<span>', {'class': 'fa fa-spinner fa-pulse'}).hide();
-        var okTo;
-        var $saveButton = $('<button>').text(Messages.creation_saveSettings).click(function () {
-            if (okTo) { clearTimeout(okTo); }
-            $ok.hide();
-            $spinner.show();
-            var val = getFormValues();
-            NThen(function (waitFor) {
-                common.setAttribute(['general', 'creation', 'owned'], val.owned, waitFor(function (e) {
-                    if (e) { return void console.error(e); }
-                }));
-                common.setAttribute(['general', 'creation', 'expire'], val.expire, waitFor(function (e) {
-                    if (e) { return void console.error(e); }
-                }));
-            }).nThen(function () {
-                $spinner.hide();
-                $ok.show();
-                okTo = setTimeout(function () {
-                    $ok.hide();
-                }, 5000);
-            });
-        });
-
-        var settings = h('div.cp-creation-settings', [
-            h('button.cp-creation-settings-save', Messages.creation_saveSettings),
-            $ok[0],
-            $spinner[0],
-            h('span.cp-filler'),
-            createHelper('/settings/#creation')
-            //h('a', {
-            //    href: origin + '/settings/#creation',
-            //    target: '_blank'
-            //}, Messages.creation_settings),
-        ]);*/
-
-
         $creation.keydown(function (e) {
             if (e.which === 9) {
                 e.preventDefault();
diff --git a/www/common/sframe-common.js b/www/common/sframe-common.js
index 36f896d52..7433fa2f0 100644
--- a/www/common/sframe-common.js
+++ b/www/common/sframe-common.js
@@ -189,7 +189,6 @@ define([
                 return void funcs.createPad(c, waitFor());
             }
             // If we display the pad creation screen, it will handle deleted pads directly
-            console.log('here');
             funcs.getPadCreationScreen(c, waitFor());
         }
     };