From 6f1e281cf877523d31e81defd7082747b0256209 Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Thu, 11 Jul 2019 14:16:04 +0200
Subject: [PATCH 1/3] request capabilities temp

---
 www/common/cryptpad-common.js        |  4 ++
 www/common/notifications.js          | 27 ++++++++++++-
 www/common/outer/async-store.js      | 60 ++++++++++++++++++++++++++++
 www/common/outer/mailbox-handlers.js | 28 +++++++++++++
 www/common/outer/mailbox.js          |  2 +-
 www/common/outer/store-rpc.js        |  1 +
 www/common/sframe-app-framework.js   |  1 +
 www/common/sframe-common-outer.js    |  7 ++++
 www/common/toolbar3.js               | 38 ++++++++++++++++++
 9 files changed, 166 insertions(+), 2 deletions(-)

diff --git a/www/common/cryptpad-common.js b/www/common/cryptpad-common.js
index fef46951c..bd467b764 100644
--- a/www/common/cryptpad-common.js
+++ b/www/common/cryptpad-common.js
@@ -693,6 +693,10 @@ define([
     pad.onConnectEvent = Util.mkEvent();
     pad.onErrorEvent = Util.mkEvent();
 
+    pad.requestAccess = function (data, cb) {
+        postMessage("REQUEST_PAD_ACCESS", data, cb);
+    };
+
     common.changePadPassword = function (Crypt, href, newPassword, edPublic, cb) {
         if (!href) { return void cb({ error: 'EINVAL_HREF' }); }
         var parsed = Hash.parsePadUrl(href);
diff --git a/www/common/notifications.js b/www/common/notifications.js
index 2e4bfce62..8aa46fde1 100644
--- a/www/common/notifications.js
+++ b/www/common/notifications.js
@@ -2,9 +2,10 @@ define([
     'jquery',
     '/common/hyperscript.js',
     '/common/common-hash.js',
+    '/common/common-interface.js',
     '/common/common-ui-elements.js',
     '/customize/messages.js',
-], function ($, h, Hash, UIElements, Messages) {
+], function ($, h, Hash, UI, UIElements, Messages) {
 
     var handlers = {};
 
@@ -84,12 +85,36 @@ define([
                 key: 'newPadPassword',
                 value: msg.content.password
             }, todo);
+            common.mailbox.dismiss(data, function (err) {
+                if (err) { return void console.error(err); }
+            });
         };
         if (!content.archived) {
             content.dismissHandler = defaultDismiss(common, data);
         }
     };
 
+    handlers['REQUEST_PAD_ACCESS'] = function (common, data) {
+        var content = data.content;
+        var msg = content.msg;
+
+        // Check authenticity
+        if (msg.author !== msg.content.user.curvePublic) { return; }
+
+        // Display the notification
+        content.getFormatText = function () {
+            return 'Edit access request: ' + msg.content.channel + ' - ' + msg.content.user.displayName;
+        };
+
+        // if not archived, add handlers
+        content.handler = function () {
+            UI.confirm("Give edit rights?", function (yes) {
+                if (!yes) { return; }
+                // XXX Command to worker to get the edit href and send it to msg.content.user
+            });
+        };
+    };
+
     return {
         add: function (common, data) {
             var type = data.content.msg.type;
diff --git a/www/common/outer/async-store.js b/www/common/outer/async-store.js
index fb1bcd202..a4aaf2b5c 100644
--- a/www/common/outer/async-store.js
+++ b/www/common/outer/async-store.js
@@ -1090,6 +1090,7 @@ define([
         var channels = Store.channels = store.channels = {};
 
         Store.joinPad = function (clientId, data) {
+            console.log('joining', data.channel);
             var isNew = typeof channels[data.channel] === "undefined";
             var channel = channels[data.channel] = channels[data.channel] || {
                 queue: [],
@@ -1243,6 +1244,65 @@ define([
             channel.sendMessage(msg, clientId, cb);
         };
 
+        Store.requestPadAccess = function (clientId, data, cb) {
+            // Get owners from pad metadata
+            // Try to find an owner in our friend list
+            // Mailbox...
+            var channel = channels[data.channel];
+            if (!data.send && channel && (!channel.data || !channel.data.channel)) {
+                var i = 0;
+                var it = setInterval(function () {
+                    if (channel.data && channel.data.channel) {
+                        clearInterval(it);
+                        Store.requestPadAccess(clientId, data, cb);
+                        return;
+                    }
+                    if (i >= 300) { // One minute timeout
+                        clearInterval(it);
+                    }
+                    i++
+                }, 200);
+                return;
+            };
+            var fData = channel.data || {};
+            if (fData.owners) {
+                var friends = store.proxy.friends || {};
+                if (Object.keys(friends).length > 1) {
+                    var owner;
+                    fData.owners.some(function (edPublic) {
+                        return Object.keys(friends).some(function (curve) {
+                            if (curve === "me") { return; }
+                            if (edPublic === friends[curve].edPublic &&
+                                friends[curve].notifications) {
+                                owner = friends[curve];
+                                return true;
+                            }
+                        });
+                    });
+                    if (owner) {
+                        console.log(owner);
+                        if (data.send) {
+                            // XXX send the pad title here...? or get it from the recipient's drive
+                            var myData = Messaging.createData(store.proxy);
+                            delete myData.channel;
+                            store.mailbox.sendTo('REQUEST_PAD_ACCESS', {
+                                channel: data.channel,
+                                user: myData
+                            }, {
+                                channel: owner.notifications,
+                                curvePublic: owner.curvePublic
+                            }, function () {
+                                cb({state: true});
+                            });
+                            return;
+                        }
+                        return void cb({state: true});
+                    }
+                }
+            }
+            cb({sent: false});
+        };
+
         // GET_FULL_HISTORY from sframe-common-outer
         Store.getFullHistory = function (clientId, data, cb) {
             var network = store.network;
diff --git a/www/common/outer/mailbox-handlers.js b/www/common/outer/mailbox-handlers.js
index 10e61fb60..e460233c2 100644
--- a/www/common/outer/mailbox-handlers.js
+++ b/www/common/outer/mailbox-handlers.js
@@ -201,6 +201,34 @@ define([
         }
     };
 
+    // Incoming edit rights request: add data before sending it to inner
+    handlers['REQUEST_PAD_ACCESS'] = function (ctx, box, data, hash) {
+        var msg = data.msg;
+        var hash = data.hash;
+        var content = msg.content;
+
+        if (msg.author !== content.user.curvePublic) { return void cb(true); }
+
+        var channel = content.channel;
+        var res = ctx.store.manager.findChannel(channel);
+
+        if (!res.length) { return void cb(true); }
+
+        var edPublic = store.proxy.edPublic;
+        var title;
+        if (!res.some(functon (obj) {
+            if (obj.data &&
+                Array.isArray(obj.data.owners) && obj.data.owners.indexOf(edPublic) !== -1 &&
+                obj.data.href) {
+                    title = obj.data.filename || obj.data.title;
+                    return true;
+            }
+        })) { return void cb(true); }
+
+        content.title = title;
+
+    });
+
     return {
         add: function (ctx, box, data, cb) {
             /**
diff --git a/www/common/outer/mailbox.js b/www/common/outer/mailbox.js
index 08e7b9351..24d14345f 100644
--- a/www/common/outer/mailbox.js
+++ b/www/common/outer/mailbox.js
@@ -339,10 +339,10 @@ proxy.mailboxes = {
 
             var txid = parsed[1];
             var req = ctx.req[txid];
+            if (!req) { return; }
             var type = parsed[0];
             var _msg = parsed[2];
             var box = req.box;
-            if (!req) { return; }
 
             if (type === 'HISTORY_RANGE') {
                 if (!Array.isArray(_msg)) { return; }
diff --git a/www/common/outer/store-rpc.js b/www/common/outer/store-rpc.js
index 6b774339c..adfe4115c 100644
--- a/www/common/outer/store-rpc.js
+++ b/www/common/outer/store-rpc.js
@@ -78,6 +78,7 @@ define([
             GET_FULL_HISTORY: Store.getFullHistory,
             GET_HISTORY_RANGE: Store.getHistoryRange,
             IS_NEW_CHANNEL: Store.isNewChannel,
+            REQUEST_PAD_ACCESS: Store.requestPadAccess,
             // Drive
             DRIVE_USEROBJECT: Store.userObjectCommand,
             // Settings,
diff --git a/www/common/sframe-app-framework.js b/www/common/sframe-app-framework.js
index f1068a6de..af856d1d7 100644
--- a/www/common/sframe-app-framework.js
+++ b/www/common/sframe-app-framework.js
@@ -603,6 +603,7 @@ define([
                     'newpad',
                     'share',
                     'limit',
+                    'request',
                     'unpinnedWarning',
                     'notifications'
                 ],
diff --git a/www/common/sframe-common-outer.js b/www/common/sframe-common-outer.js
index fba08279a..8c6f79eb2 100644
--- a/www/common/sframe-common-outer.js
+++ b/www/common/sframe-common-outer.js
@@ -941,6 +941,13 @@ define([
                 sframeChan.event('EV_WORKER_TIMEOUT');
             });
 
+            sframeChan.on('Q_REQUEST_ACCESS', function (data, cb) {
+                Cryptpad.padRpc.requestAccess({
+                    send: data,
+                    channel: secret.channel
+                }, cb);
+            });
+
             if (cfg.messaging) {
                 Notifier.getPermission();
 
diff --git a/www/common/toolbar3.js b/www/common/toolbar3.js
index d6b116df3..98c2801e7 100644
--- a/www/common/toolbar3.js
+++ b/www/common/toolbar3.js
@@ -574,6 +574,43 @@ MessengerUI, Messages) {
         return $shareBlock;
     };
 
+    var createRequest = function (toolbar, config) {
+        console.error('test');
+        if (!config.metadataMgr) {
+            throw new Error("You must provide a `metadataMgr` to display the request access button");
+        }
+
+        // We can only requets more access if we're in read-only mode
+        if (config.readOnly !== 1) { return; }
+
+        var $requestBlock = $('<button>', {
+            'class': 'fa fa-lock cp-toolbar-share-button',
+            title: 'REQUEST ACCESS' // XXX
+        }).hide();
+
+        // If we have access to the owner's mailbox, display the button and enable it
+        // XXX the data sent to outer is false if we want to check if we can contact the owner
+        // and it is true if we change to contact it (action)
+        // XXX get pad title here??
+        Common.getSframeChannel().query('Q_REQUEST_ACCESS', false, function (err, obj) {
+            if (obj && obj.state) {
+                $requestBlock.show().click(function () {
+                    Common.getSframeChannel().query('Q_REQUEST_ACCESS', true, function (err, obj) {
+                        if (obj && obj.state) {
+                            UI.log('sent'); // XXX
+                        }
+                    });
+                });
+            }
+        });
+
+
+        toolbar.$leftside.append($requestBlock);
+        toolbar.request = $requestBlock;
+
+        return $requestBlock;
+    };
+
     var createTitle = function (toolbar, config) {
         var $titleContainer = $('<span>', {
             'class': TITLE_CLS
@@ -1178,6 +1215,7 @@ MessengerUI, Messages) {
         tb['fileshare'] = createFileShare;
         tb['title'] = createTitle;
         tb['pageTitle'] = createPageTitle;
+        tb['request'] = createRequest;
         tb['lag'] = $.noop;
         tb['spinner'] = createSpinner;
         tb['state'] = $.noop;

From 2ba6e40161445bfbcdb09336c187d0b5736fdb5b Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Sat, 13 Jul 2019 10:07:04 +0200
Subject: [PATCH 2/3] Fix issue with merging anon drive

---
 www/common/mergeDrive.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/common/mergeDrive.js b/www/common/mergeDrive.js
index 9247656e1..aa6e57b0a 100644
--- a/www/common/mergeDrive.js
+++ b/www/common/mergeDrive.js
@@ -49,7 +49,7 @@ define([
                             // We want to merge an edit pad: check if we have the same channel
                             // but read-only and upgrade it in that case
                             datas.forEach(function (pad) {
-                                if (!pad.href) { data.href = pad.href; }
+                                if (pad.data && !pad.data.href) { pad.data.href = data.href; }
                             });
                             return;
                         }

From 60bea6b33b5a85c713d914e5f01dca7eed2ba0c1 Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Sat, 13 Jul 2019 11:47:58 +0200
Subject: [PATCH 3/3] Request capabilities part 2

---
 www/common/cryptpad-common.js        |  3 ++
 www/common/notifications.js          | 43 +++++++++++++++++++++++-----
 www/common/outer/async-store.js      | 40 +++++++++++++++++++++++---
 www/common/outer/mailbox-handlers.js | 30 +++++++++++++++----
 www/common/outer/store-rpc.js        |  1 +
 www/common/sframe-common-outer.js    |  6 ++++
 www/common/toolbar3.js               |  5 ++--
 www/notifications/inner.js           |  2 +-
 8 files changed, 110 insertions(+), 20 deletions(-)

diff --git a/www/common/cryptpad-common.js b/www/common/cryptpad-common.js
index bd467b764..0311387ee 100644
--- a/www/common/cryptpad-common.js
+++ b/www/common/cryptpad-common.js
@@ -696,6 +696,9 @@ define([
     pad.requestAccess = function (data, cb) {
         postMessage("REQUEST_PAD_ACCESS", data, cb);
     };
+    pad.giveAccess = function (data, cb) {
+        postMessage("GIVE_PAD_ACCESS", data, cb);
+    };
 
     common.changePadPassword = function (Crypt, href, newPassword, edPublic, cb) {
         if (!href) { return void cb({ error: 'EINVAL_HREF' }); }
diff --git a/www/common/notifications.js b/www/common/notifications.js
index 8aa46fde1..e57228265 100644
--- a/www/common/notifications.js
+++ b/www/common/notifications.js
@@ -79,15 +79,15 @@ define([
             return Messages._getKey(key, [msg.content.name || Messages.anonymous, msg.content.title]);
         };
         content.handler = function () {
-            var todo = function () { common.openURL(msg.content.href); };
+            var todo = function () {
+                common.openURL(msg.content.href);
+                defaultDismiss(common, data)();
+            };
             if (!msg.content.password) { return void todo(); }
             common.getSframeChannel().query('Q_SESSIONSTORAGE_PUT', {
                 key: 'newPadPassword',
                 value: msg.content.password
             }, todo);
-            common.mailbox.dismiss(data, function (err) {
-                if (err) { return void console.error(err); }
-            });
         };
         if (!content.archived) {
             content.dismissHandler = defaultDismiss(common, data);
@@ -103,16 +103,45 @@ define([
 
         // Display the notification
         content.getFormatText = function () {
-            return 'Edit access request: ' + msg.content.channel + ' - ' + msg.content.user.displayName;
-        };
+            return 'Edit access request: ' + msg.content.title + ' - ' + msg.content.user.displayName;
+        }; // XXX
 
         // if not archived, add handlers
         content.handler = function () {
             UI.confirm("Give edit rights?", function (yes) {
                 if (!yes) { return; }
-                // XXX Command to worker to get the edit href and send it to msg.content.user
+                common.getSframeChannel().event('EV_GIVE_ACCESS', {
+                    channel: msg.content.channel,
+                    user: msg.content.user
+                });
+                defaultDismiss(common, data)();
             });
         };
+
+        if (!content.archived) {
+            content.dismissHandler = defaultDismiss(common, data);
+        }
+    };
+
+    handlers['GIVE_PAD_ACCESS'] = function (common, data) {
+        var content = data.content;
+        var msg = content.msg;
+
+        // Check authenticity
+        if (msg.author !== msg.content.user.curvePublic) { return; }
+
+        if (!msg.content.href) { return; }
+
+        // Display the notification
+        content.getFormatText = function () {
+            return 'Edit access received: ' + msg.content.title + ' from ' + msg.content.user.displayName;
+        }; // XXX
+
+        // if not archived, add handlers
+        content.handler = function () {
+            common.openURL(msg.content.href);
+            defaultDismiss(common, data)();
+        };
     };
 
     return {
diff --git a/www/common/outer/async-store.js b/www/common/outer/async-store.js
index a4aaf2b5c..ca7e4cd7c 100644
--- a/www/common/outer/async-store.js
+++ b/www/common/outer/async-store.js
@@ -1260,10 +1260,10 @@ define([
                     if (i >= 300) { // One minute timeout
                         clearInterval(it);
                     }
-                    i++
+                    i++;
                 }, 200);
                 return;
-            };
+            }
             var fData = channel.data || {};
             if (fData.owners) {
                 var friends = store.proxy.friends || {};
@@ -1280,9 +1280,7 @@ define([
                         });
                     });
                     if (owner) {
-                        console.log(owner);
                         if (data.send) {
-                            // XXX send the pad title here...? or get it from the recipient's drive
                             var myData = Messaging.createData(store.proxy);
                             delete myData.channel;
                             store.mailbox.sendTo('REQUEST_PAD_ACCESS', {
@@ -1302,6 +1300,40 @@ define([
             }
             cb({sent: false});
         };
+        Store.givePadAccess = function (clientId, data, cb) {
+            var edPublic = store.proxy.edPublic;
+            var channel = data.channel;
+            var res = store.manager.findChannel(channel);
+
+            if (!data.user || !data.user.notifications || !data.user.curvePublic) {
+                return void cb({error: 'EINVAL'});
+            }
+
+            var href, title;
+
+            if (!res.some(function (obj) {
+                if (obj.data &&
+                    Array.isArray(obj.data.owners) && obj.data.owners.indexOf(edPublic) !== -1 &&
+                    obj.data.href) {
+                        href = obj.data.href;
+                        title = obj.data.title;
+                        return true;
+                }
+            })) { return void cb({error: 'ENOTFOUND'}); }
+
+            var myData = Messaging.createData(store.proxy);
+            delete myData.channel;
+            store.mailbox.sendTo("GIVE_PAD_ACCESS", {
+                channel: channel,
+                href: href,
+                title: title,
+                user: myData
+            }, {
+                channel: data.user.notifications,
+                curvePublic: data.user.curvePublic
+            });
+            cb();
+        };
 
         // GET_FULL_HISTORY from sframe-common-outer
         Store.getFullHistory = function (clientId, data, cb) {
diff --git a/www/common/outer/mailbox-handlers.js b/www/common/outer/mailbox-handlers.js
index e460233c2..42997b3e0 100644
--- a/www/common/outer/mailbox-handlers.js
+++ b/www/common/outer/mailbox-handlers.js
@@ -202,9 +202,8 @@ define([
     };
 
     // Incoming edit rights request: add data before sending it to inner
-    handlers['REQUEST_PAD_ACCESS'] = function (ctx, box, data, hash) {
+    handlers['REQUEST_PAD_ACCESS'] = function (ctx, box, data, cb) {
         var msg = data.msg;
-        var hash = data.hash;
         var content = msg.content;
 
         if (msg.author !== content.user.curvePublic) { return void cb(true); }
@@ -214,9 +213,9 @@ define([
 
         if (!res.length) { return void cb(true); }
 
-        var edPublic = store.proxy.edPublic;
+        var edPublic = ctx.store.proxy.edPublic;
         var title;
-        if (!res.some(functon (obj) {
+        if (!res.some(function (obj) {
             if (obj.data &&
                 Array.isArray(obj.data.owners) && obj.data.owners.indexOf(edPublic) !== -1 &&
                 obj.data.href) {
@@ -226,8 +225,29 @@ define([
         })) { return void cb(true); }
 
         content.title = title;
+        cb(false);
+    };
+
+    handlers['GIVE_PAD_ACCESS'] = function (ctx, box, data, cb) {
+        var msg = data.msg;
+        var content = msg.content;
+
+        if (msg.author !== content.user.curvePublic) { return void cb(true); }
 
-    });
+        var channel = content.channel;
+        var res = ctx.store.manager.findChannel(channel);
+
+        var title;
+        res.forEach(function (obj) {
+            if (obj.data && !obj.data.href) {
+                if (!title) { title = obj.data.filename || obj.data.title; }
+                obj.data.href = content.href;
+            }
+        });
+
+        content.title = title || content.title;
+        cb(false);
+    };
 
     return {
         add: function (ctx, box, data, cb) {
diff --git a/www/common/outer/store-rpc.js b/www/common/outer/store-rpc.js
index adfe4115c..bb8e0a674 100644
--- a/www/common/outer/store-rpc.js
+++ b/www/common/outer/store-rpc.js
@@ -79,6 +79,7 @@ define([
             GET_HISTORY_RANGE: Store.getHistoryRange,
             IS_NEW_CHANNEL: Store.isNewChannel,
             REQUEST_PAD_ACCESS: Store.requestPadAccess,
+            GIVE_PAD_ACCESS: Store.givePadAccess,
             // Drive
             DRIVE_USEROBJECT: Store.userObjectCommand,
             // Settings,
diff --git a/www/common/sframe-common-outer.js b/www/common/sframe-common-outer.js
index 8c6f79eb2..81ea43d81 100644
--- a/www/common/sframe-common-outer.js
+++ b/www/common/sframe-common-outer.js
@@ -941,7 +941,13 @@ define([
                 sframeChan.event('EV_WORKER_TIMEOUT');
             });
 
+            sframeChan.on('EV_GIVE_ACCESS', function (data, cb) {
+                Cryptpad.padRpc.giveAccess(data, cb);
+            });
             sframeChan.on('Q_REQUEST_ACCESS', function (data, cb) {
+                if (readOnly && hashes.editHash) {
+                    return void cb({error: 'ALREADYKNOWN'});
+                }
                 Cryptpad.padRpc.requestAccess({
                     send: data,
                     channel: secret.channel
diff --git a/www/common/toolbar3.js b/www/common/toolbar3.js
index 98c2801e7..53aa93f4f 100644
--- a/www/common/toolbar3.js
+++ b/www/common/toolbar3.js
@@ -589,9 +589,8 @@ MessengerUI, Messages) {
         }).hide();
 
         // If we have access to the owner's mailbox, display the button and enable it
-        // XXX the data sent to outer is false if we want to check if we can contact the owner
-        // and it is true if we change to contact it (action)
-        // XXX get pad title here??
+        // false => check if we can contact the owner
+        // true ==> send the request
         Common.getSframeChannel().query('Q_REQUEST_ACCESS', false, function (err, obj) {
             if (obj && obj.state) {
                 $requestBlock.show().click(function () {
diff --git a/www/notifications/inner.js b/www/notifications/inner.js
index fd5f69de0..eba1ad7dc 100644
--- a/www/notifications/inner.js
+++ b/www/notifications/inner.js
@@ -44,7 +44,7 @@ define([
         ],
     };
 
-    var notifsAllowedTypes = ["FRIEND_REQUEST", "FRIEND_REQUEST_ACCEPTED", "FRIEND_REQUEST_DECLINED", "SHARE_PAD"];
+    var notifsAllowedTypes = ["FRIEND_REQUEST", "FRIEND_REQUEST_ACCEPTED", "FRIEND_REQUEST_DECLINED", "SHARE_PAD", "REQUEST_PAD_ACCESS"];
 
     var create = {};