From 5f0244beb3e6526890ce59e7018cef019454c4db Mon Sep 17 00:00:00 2001 From: yflory Date: Thu, 12 Dec 2019 16:09:07 +0100 Subject: [PATCH] Fix kanban UI issues --- www/kanban/app-kanban.less | 3 +++ www/kanban/inner.js | 3 +++ www/kanban/jkanban.css | 1 + www/kanban/jkanban.js | 3 --- 4 files changed, 7 insertions(+), 3 deletions(-) diff --git a/www/kanban/app-kanban.less b/www/kanban/app-kanban.less index 76efd749c..248c66c1d 100644 --- a/www/kanban/app-kanban.less +++ b/www/kanban/app-kanban.less @@ -74,6 +74,9 @@ #kanban-edit { font-weight: bold; } + &:hover { + cursor: move; + } } } diff --git a/www/kanban/inner.js b/www/kanban/inner.js index 035794b2a..5a9e10f47 100644 --- a/www/kanban/inner.js +++ b/www/kanban/inner.js @@ -184,6 +184,9 @@ define([ var save = function () { // Store the value var name = $input.val(); + if (!name || !name.trim()) { + return kanban.onChange(); + } // Remove the input $(el).text(name); // Save the value for the correct board diff --git a/www/kanban/jkanban.css b/www/kanban/jkanban.css index 4bbb28128..ed5a8f5db 100644 --- a/www/kanban/jkanban.css +++ b/www/kanban/jkanban.css @@ -36,6 +36,7 @@ margin: 0; padding: 0; display: inline; + cursor: text; } .kanban-board header .kanban-title-button { diff --git a/www/kanban/jkanban.js b/www/kanban/jkanban.js index f1f70955a..f3f4bf6d4 100644 --- a/www/kanban/jkanban.js +++ b/www/kanban/jkanban.js @@ -151,9 +151,6 @@ return handle.classList.contains('kanban-item'); }, accepts: function (el, target, source, sibling) { - if (sibling === null) { - return false; - } if (self.options.readOnly) { return false; } return true; },