From 01b6dd539bfc07fce697b87fa4202657ebc91d3e Mon Sep 17 00:00:00 2001 From: ansuz Date: Mon, 4 Apr 2022 20:38:52 +0530 Subject: [PATCH 1/3] add trailing slash if /convert/ is loaded without its trailing slash --- docs/example.nginx.conf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/example.nginx.conf b/docs/example.nginx.conf index f5c0e1643..a2d1cb1ce 100644 --- a/docs/example.nginx.conf +++ b/docs/example.nginx.conf @@ -237,7 +237,7 @@ server { # The nodejs server has some built-in forwarding rules to prevent # URLs like /pad from resulting in a 404. This simply adds a trailing slash # to a variety of applications. - location ~ ^/(register|login|settings|user|pad|drive|poll|slide|code|whiteboard|file|media|profile|contacts|todo|filepicker|debug|kanban|sheet|support|admin|notifications|teams|calendar|presentation|doc|form|report|convert)$ { + location ~ ^/(register|login|settings|user|pad|drive|poll|slide|code|whiteboard|file|media|profile|contacts|todo|filepicker|debug|kanban|sheet|support|admin|notifications|teams|calendar|presentation|doc|form|report|convert|checkup)$ { rewrite ^(.*)$ $1/ redirect; } From 6bc1c24608626dbe74b2295d4e9592f681f6c428 Mon Sep 17 00:00:00 2001 From: ansuz Date: Mon, 4 Apr 2022 20:56:07 +0530 Subject: [PATCH 2/3] fix incorrectly concatenated assertion messages --- www/assert/assertions.js | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/www/assert/assertions.js b/www/assert/assertions.js index d5f806e03..6db10fb24 100644 --- a/www/assert/assertions.js +++ b/www/assert/assertions.js @@ -16,20 +16,18 @@ define([], function () { } if (called) { return; } + if (msg && !msg.innerText) { + msg.innerText = "An unexpected error occurred. See your browser's console for more details"; + } + called = true; _cb(arg); }; - var _msg = document.createElement('span'); - _msg.innerText = "An unexpected error occurred. See your browser's console for more details"; - if (msg && !msg.innerText) { - msg.innerText = _msg.innerText; - } - to = setTimeout(function () { cb({ test: i, - message: msg || _msg, + message: msg, output: "TIMEOUT", }); }, 25000); @@ -42,7 +40,7 @@ define([], function () { } else { cb({ test: i, - message: msg || _msg, + message: msg, output: result, }); } @@ -54,7 +52,7 @@ define([], function () { //from ${err.fileName} line ${err.lineNumber}`; cb({ test: i, - message: msg || _msg, + message: msg, output: { message: err.message, file: err.fileName, From fce63af2c13b4894204cde3d24122df6cb11ac0b Mon Sep 17 00:00:00 2001 From: ansuz Date: Tue, 5 Apr 2022 15:21:02 +0530 Subject: [PATCH 3/3] always show the markdown toolbar in the kanban editor --- www/kanban/app-kanban.less | 3 +++ 1 file changed, 3 insertions(+) diff --git a/www/kanban/app-kanban.less b/www/kanban/app-kanban.less index 79d5a87a3..accff3219 100644 --- a/www/kanban/app-kanban.less +++ b/www/kanban/app-kanban.less @@ -64,6 +64,9 @@ display: flex; flex-flow: column; overflow: hidden; + .cp-markdown-toolbar { + display: block; + } } #cp-kanban-edit-conflicts { padding: 5px;