From 4d3bc7d8e612b3749bdd95c476bc0935e8c734e4 Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Fri, 8 Nov 2019 17:35:15 +0100
Subject: [PATCH] Improve permissions table

---
 www/teams/app-team.less |  3 +++
 www/teams/inner.js      | 18 ++++++++++++++----
 2 files changed, 17 insertions(+), 4 deletions(-)

diff --git a/www/teams/app-team.less b/www/teams/app-team.less
index fefdbb59f..cef46ee4b 100644
--- a/www/teams/app-team.less
+++ b/www/teams/app-team.less
@@ -201,6 +201,9 @@
         p {
             text-align: left;
         }
+        h5 {
+            text-align: left;
+        }
         ul {
             text-align: left;
             padding-left: 30px;
diff --git a/www/teams/inner.js b/www/teams/inner.js
index 013d3592e..2699fd63c 100644
--- a/www/teams/inner.js
+++ b/www/teams/inner.js
@@ -741,7 +741,7 @@ define([
             };
             // Global rights
             var rows = [];
-            var firstRow = ['', Messages.share_linkView, Messages.share_linkEdit,
+            var firstRow = [Messages.teams_table_role, Messages.share_linkView, Messages.share_linkEdit,
                                 Messages.teams_table_admins, Messages.teams_table_owners];
             rows.push(h('tr', makeRow(firstRow, true)));
             rows.push(h('tr', makeRow([Messages.team_viewers, 'x', '', '', ''])));
@@ -752,28 +752,38 @@ define([
 
             var content = [
                 h('h4', Messages.teams_table_generic),
-                h('p', Messages.teams_table_genericHint),
+                h('p', [
+                    Messages.teams_table_generic_view,
+                    h('br'),
+                    Messages.teams_table_generic_edit,
+                    h('br'),
+                    Messages.teams_table_generic_admin,
+                    h('br'),
+                    Messages.teams_table_generic_own,
+                    h('br')
+                ]),
                 t
             ];
 
             APP.module.execCommand('GET_EDITABLE_FOLDERS', {
                 teamId: APP.team
             }, function (arr) {
-                console.log(arr);
                 if (!Array.isArray(arr) || !arr.length) {
                     return void $blockContainer.find('.cp-modal').append(content);
                 }
-                content.push(h('h4', Messages.teams_table_specific));
+                content.push(h('h5', Messages.teams_table_specific));
                 content.push(h('p', Messages.teams_table_specificHint));
                 var paths = arr.map(function (obj) {
                     obj.path.push(obj.name);
                     return h('li', obj.path.join('/'));
                 });
                 content.push(h('ul', paths));
+                /*
                 var rows = [];
                 rows.push(h('tr', makeRow(firstRow, true)));
                 rows.push(h('tr', makeRow([Messages.team_viewers, 'x', 'x', '', ''])));
                 content.push(h('table', rows));
+                */
                 $blockContainer.find('.cp-modal').append(content);
             });
         });