From 7db03efdc509be9aba6606b6a5c19aae66efed92 Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Mon, 23 Aug 2021 18:08:32 +0200
Subject: [PATCH 1/3] Fix type errors when changing question type in forms

---
 www/form/inner.js | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/www/form/inner.js b/www/form/inner.js
index 973b9e89c..150e80207 100644
--- a/www/form/inner.js
+++ b/www/form/inner.js
@@ -1204,7 +1204,7 @@ define([
                 Object.keys(answers).forEach(function (author) {
                     var obj = answers[author];
                     var answer = obj.msg[uid];
-                    if (!answer || !answer.trim()) { return empty++; }
+                    if (!answer || !answer.trim || !answer.trim()) { return empty++; }
                     Util.inc(count, answer);
                 });
 
@@ -1315,7 +1315,7 @@ define([
                     Object.keys(answer).forEach(function (q_uid) {
                         var c = count[q_uid] = count[q_uid] || {};
                         var res = answer[q_uid];
-                        if (!res || !res.trim()) { return; }
+                        if (!res || !res.trim || !res.trim()) { return; }
                         Util.inc(c, res);
                     });
                 });
@@ -1452,6 +1452,7 @@ define([
                 Object.keys(answers).forEach(function (author) {
                     var obj = answers[author];
                     var answer = obj.msg[uid];
+                    if (answer && typeof(answer) === "string") { answer = [answer]; }
                     if (!Array.isArray(answer) || !answer.length) { return empty++; }
                     answer.forEach(function (val) {
                         Util.inc(count, val);
@@ -1582,6 +1583,7 @@ define([
                     Object.keys(answer).forEach(function (q_uid) {
                         var c = count[q_uid] = count[q_uid] || {};
                         var res = answer[q_uid];
+                        if (res && typeof(res) === "string") { res = [res]; }
                         if (!Array.isArray(res) || !res.length) { return; }
                         res.forEach(function (v) {
                             Util.inc(c, v);
@@ -1745,6 +1747,7 @@ define([
                 Object.keys(answers).forEach(function (author) {
                     var obj = answers[author];
                     var answer = obj.msg[uid];
+                    if (answer && typeof(answer) === "string") { answer = [answer]; }
                     if (!Array.isArray(answer) || !answer.length) { return empty++; }
                     answer.forEach(function (el, i) {
                         var score = l - i;
@@ -1769,6 +1772,7 @@ define([
                 if (!opts) { opts = TYPES.poll.defaultOpts; }
                 if (!Array.isArray(opts.values)) { return; }
 
+                if (APP.isEditor) { answers = {}; }
                 var lines = makePollTable(answers, opts, false);
 
                 var disabled = false;

From 4e013520c5eb82c5d0cc70a82c331204984903ff Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Mon, 23 Aug 2021 18:14:26 +0200
Subject: [PATCH 2/3] Fix forms issues

---
 www/form/inner.js | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/www/form/inner.js b/www/form/inner.js
index 150e80207..d16a2b474 100644
--- a/www/form/inner.js
+++ b/www/form/inner.js
@@ -1271,6 +1271,7 @@ define([
                             $el.find('input').each(function (i, input) {
                                 var $i = $(input);
                                 if (res[uid]) { return; }
+                                res[uid] = undefined;
                                 if (Util.isChecked($i)) { res[uid] = $i.data('val'); }
                             });
                         });
@@ -1420,7 +1421,10 @@ define([
                         });
                         return res;
                     },
-                    reset: function () { $(tag).find('input').removeAttr('checked'); },
+                    reset: function () {
+                        $(tag).find('input').removeAttr('checked');
+                        checkDisabled();
+                    },
                     setEditable: function (state) {
                         if (state) { checkDisabled(); }
                         else { $tag.find('input').attr('disabled', 'disabled'); }
@@ -1543,7 +1547,10 @@ define([
                         });
                         return res;
                     },
-                    reset: function () { $(tag).find('input').removeAttr('checked'); },
+                    reset: function () {
+                        $(tag).find('input').removeAttr('checked');
+                        lines.forEach(checkDisabled);
+                    },
                     setEditable: function (state) {
                         if (state) { lines.forEach(checkDisabled); }
                         else { $(tag).find('input').attr('disabled', 'disabled'); }

From 5a8104e793fdd49bb1910dabb3920387338c49ce Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Mon, 23 Aug 2021 18:16:53 +0200
Subject: [PATCH 3/3] lint compliance

---
 www/form/inner.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/www/form/inner.js b/www/form/inner.js
index d16a2b474..4120df1df 100644
--- a/www/form/inner.js
+++ b/www/form/inner.js
@@ -259,9 +259,9 @@ define([
             if (placeholder) {
                 input.placeholder = val;
                 input.value = '';
-                $(input).change(function () {
-                    input.placeholder = '';
-                    $(input).off(change);
+                $(input).on('keypress', function () {
+                    $(input).removeAttr('placeholder');
+                    $(input).off('keypress');
                 });
             }
             if (uid) { $(input).data('uid', uid); }