From 47290fca1e60fc254d52214c2343f6772c2dec2f Mon Sep 17 00:00:00 2001
From: ansuz <ansuz@transitiontech.ca>
Date: Thu, 23 Jan 2020 14:10:20 -0500
Subject: [PATCH] leave some notes about something that was tricky to read

---
 rpc.js | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/rpc.js b/rpc.js
index 0a2c5b17f..69eb9313f 100644
--- a/rpc.js
+++ b/rpc.js
@@ -323,6 +323,14 @@ var setMetadata = function (Env, data, unsafeKey, cb) {
                 return void next();
             }
 
+            // if you are a pending owner and not an owner
+                // you can either ADD_OWNERS, or RM_PENDING_OWNERS
+                    // and you should only be able to add yourself as an owner
+                // everything else should be rejected
+            // else if you are not an owner
+                // you should be rejected
+            // else write the command
+
             // Confirm that the channel is owned by the user in question
             // or the user is accepting a pending ownership offer
             if (hasPendingOwners(metadata) &&
@@ -337,7 +345,9 @@ var setMetadata = function (Env, data, unsafeKey, cb) {
                     cb('INSUFFICIENT_PERMISSIONS');
                     return void next();
                 }
-                // XXX wacky fallthrough is hard to read
+                // FIXME wacky fallthrough is hard to read
+                // we could pass this off to a writeMetadataCommand function
+                // and make the flow easier to follow
             } else if (!isOwner(metadata, unsafeKey)) {
                 cb('INSUFFICIENT_PERMISSIONS');
                 return void next();