From 45c4765ce00950850dcb1ada86aac1836eae494d Mon Sep 17 00:00:00 2001
From: ansuz <ansuz@transitiontech.ca>
Date: Fri, 27 Aug 2021 20:10:17 +0530
Subject: [PATCH] update changelog and make a note about a bug in getAuthorId

---
 CHANGELOG.md                | 25 +++++++++++++++++++++++--
 www/common/sframe-common.js |  7 ++++++-
 2 files changed, 29 insertions(+), 3 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 185a9ae29..7325e2d21 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,11 +7,32 @@
 ## Features
 
 * unify unregistered/non-registered/anonymous terminology as 'guest'
-* prompt users that need support to subscribe
-* include bar graphs for multiple-answer form questions
+* support
+  * prompt users that need support to subscribe
+  * refactor debugging data generation to easily show users what data is included
+* form improvements
+  * include bar graphs for multiple-answer form questions
+  * move the tally of empty responses to the top of each question's summary (rather than the bottom)
+* bar charts on the admin page's 'Performance' tab
+* enhancements for guest users and registered users without names or avatars
+  * two initials for users with a custom name but no avatar (previously one initial, always capitalized)
+  * animal avatars as defaults instead of indistinguishable initials (A for Anonymous, G for Guest)
+    * configurable via `AppConfig.emojiAvatars = []`
+  * authorship data for guests in rich text comments, code editor author data
+  * emojis in cursor tooltips for guests (rich text, code, slide, kanban)
+  * emojis in the share and access modals for contacts with empty names
+* script to identify unnecessary duplication of translations
+
 
 ## Bug fixes
 
+* fix empty name fields in various places across the platform where we did not fall back to "anonymous/guest"
+  * teams
+  * contacts
+  * ???
+* clarified a comment in the nginx config about _professional support_
+* handled an edge case in ICS import to calendars where DTEND was not defined (use duration or consider it an "all-day" event
+
 
 # 4.10.0
 
diff --git a/www/common/sframe-common.js b/www/common/sframe-common.js
index 000d049b3..3575c95b0 100644
--- a/www/common/sframe-common.js
+++ b/www/common/sframe-common.js
@@ -235,7 +235,7 @@ define([
         };
     };
 
-    funcs.getAuthorId = function () {
+    funcs.getAuthorId = function () { // XXX
     };
 
     var authorUid = function(existing) {
@@ -263,6 +263,11 @@ define([
             });
             return uid || authorUid(existing);
         }
+        // XXX this should check for a matching curvePublic / uid if:
+        // 1. you are logged in OR
+        // 2. you have a token
+        // so that users that register recognize comments from before
+        // they registered as their own (same uid)
         existing.some(function(id) {
             var author = authors[id] || {};
             if (author.curvePublic !== curve) { return; }