From 41c3b38a111d19a5ea846c2716e2b82f0cc2ec16 Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Tue, 4 Jun 2019 11:23:38 +0200
Subject: [PATCH] lint compliance

---
 www/common/common-ui-elements.js | 25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)

diff --git a/www/common/common-ui-elements.js b/www/common/common-ui-elements.js
index 0262527c9..2c9d7a742 100644
--- a/www/common/common-ui-elements.js
+++ b/www/common/common-ui-elements.js
@@ -348,17 +348,6 @@ define([
             return friends[c].curvePublic.slice(0,8);
         });
 
-        // Fill with fake friends to have a uniform spacing (from the flexbox)
-        var addFake = function (els) {
-            $(bloc).find('.cp-fake-friend').remove();
-            var n = (6 - els.length%6)%6;
-            for (var j = 0; j < n; j++) {
-                els.push(h('div.cp-share-friend.cp-fake-friend', {
-                    style: 'order:9999999;'
-                }));
-            }
-        };
-        addFake(others);
         var noOthers = others.length === 0 ? '.cp-recent-only' : '';
 
         var buttonSelect = h('button.cp-share-with-friends', Messages.shareSelectAll || 'Select'); // XXX
@@ -377,6 +366,18 @@ define([
         ]);
         var $bloc = $(bloc);
 
+        // Fill with fake friends to have a uniform spacing (from the flexbox)
+        var addFake = function (els) {
+            $(bloc).find('.cp-fake-friend').remove();
+            var n = (6 - els.length%6)%6;
+            for (var j = 0; j < n; j++) {
+                els.push(h('div.cp-share-friend.cp-fake-friend', {
+                    style: 'order:9999999;'
+                }));
+            }
+        };
+        addFake(others);
+
         var redraw = function () {
             var name = $(inputFilter).val().trim().replace(/"/g, '');
             $bloc.find('.cp-share-friend').show();
@@ -462,7 +463,7 @@ define([
             });
             // Display them
             $bloc.append(h('div.cp-share-grid', others));
-            $bloc.find('.cp-share-friend').click(function (e) {
+            $bloc.find('.cp-share-friend').click(function () {
                 var sel = $(this).hasClass('cp-selected');
                 if (!sel) {
                     $(this).addClass('cp-selected');