infra
/
cryptpad
2
1
Fork 0
Code Issues Pull Requests Projects Releases 1 Activity

avoid displaying new comment while the document is not editable 

closes #570
pull/1/head
ansuz 2020-06-25 13:50:05 -04:00
parent 131b985902
commit 4053c4c1a6
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
www/pad/comments.js
View File

@ -747,6 +747,14 @@ define([
Env.$contentContainer.append(h('div.cp-comment-bubble', button));
};
var isEditable = function (document) {
try {
return document.body.getAttribute('contenteditable') === 'true';
} catch (err) {
return false;
}
};
var addAddCommentHandler = function(Env) {
Env.editor.plugins.comments.addComment = function(uid, addMark) {
if (!Env.ready) { return; }
@ -809,7 +817,7 @@ define([
$(Env.ifrWindow.document).on('selectionchange', function() {
removeCommentBubble(Env);
var applicable = Env.editor.plugins.comments.isApplicable();
if (!applicable) { return; }
if (!applicable || !isEditable(Env.ifrWindow.document)) { return; }
addCommentBubble(Env);
});
};