From 403d922ddd4ceb86cbeecce9a92096824342c77b Mon Sep 17 00:00:00 2001 From: ansuz Date: Mon, 26 Jul 2021 16:30:49 +0530 Subject: [PATCH] replace two XXX notes with comments --- www/common/drive-ui.js | 6 +++++- www/common/outer/async-store.js | 4 +++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/www/common/drive-ui.js b/www/common/drive-ui.js index 0e3b340a4..feec8543e 100644 --- a/www/common/drive-ui.js +++ b/www/common/drive-ui.js @@ -1925,7 +1925,11 @@ define([ var $name = $('', {'class': 'cp-app-drive-element-name'}).text(name); $element.append($name); if (getViewMode() === 'grid') { - $element.attr('title', name); // XXX Util.fixHTML + //console.error(name, Util.fixHTML(name)); + // this is only safe because our build of tippy sets titles as + // 'textContent' instead of innerHTML, otherwise + // we would need to use Util.fixHTML + $element.attr('title', name); } var type = Messages.fm_link; // XXX new translation key ("Link") diff --git a/www/common/outer/async-store.js b/www/common/outer/async-store.js index 30b71f1bd..d8e558dad 100644 --- a/www/common/outer/async-store.js +++ b/www/common/outer/async-store.js @@ -2062,10 +2062,12 @@ define([ // Tell all the owners that the pad was deleted from the server var curvePublic; try { + // users in noDrive mode don't have a proxy and + // unregistered users don't have a curvePublic curvePublic = store.proxy.curvePublic; } catch (err) { console.error(err); - return; // XXX anons can't send notifications... + return; } m.forEach(function (obj) { var mb = JSON.parse(obj);