From 402ce2db93fb56b4f2e7874b7231e94fdbb24958 Mon Sep 17 00:00:00 2001
From: ansuz <ansuz@transitiontech.ca>
Date: Fri, 14 Apr 2017 15:34:22 +0200
Subject: [PATCH] better validation of inputs

---
 www/common/pinpad.js | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/www/common/pinpad.js b/www/common/pinpad.js
index 275a68666..a9467cff9 100644
--- a/www/common/pinpad.js
+++ b/www/common/pinpad.js
@@ -38,8 +38,7 @@ define([
 
             // you can ask the server to pin a particular channel for you
             exp.pin = function (channels, cb) {
-                // TODO use isArray if it's safe
-                if (!channels && channels.length) {
+                if (!Array.isArray(channels)) {
                     window.setTimeout(function () {
                         cb('[TypeError] pin expects an array');
                     });
@@ -50,8 +49,7 @@ define([
 
             // you can also ask to unpin a particular channel
             exp.unpin = function (channels, cb) {
-                // TODO use isArray if it's safe
-                if (!channels && channels.length) {
+                if (!Array.isArray(channels)) {
                     window.setTimeout(function () {
                         cb('[TypeError] pin expects an array');
                     });
@@ -72,8 +70,7 @@ define([
 
             // if local and remote hashes don't match, send a reset
             exp.reset = function (channels, cb) {
-                // TODO use isArray if it's safe
-                if (!channels && channels.length) {
+                if (!Array.isArray(channels)) {
                     window.setTimeout(function () {
                         cb('[TypeError] pin expects an array');
                     });