From 89da14220468ece6905ed1b08295e8d84c62ca91 Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Wed, 1 Feb 2017 15:52:47 +0100
Subject: [PATCH 1/4] Fix pad creation from the context menu

---
 customize.dist/translations/messages.fr.js |  2 +-
 customize.dist/translations/messages.js    |  1 +
 www/drive/inner.html                       |  8 +++---
 www/drive/main.js                          | 29 +++++++++++-----------
 4 files changed, 21 insertions(+), 19 deletions(-)

diff --git a/customize.dist/translations/messages.fr.js b/customize.dist/translations/messages.fr.js
index 059a315cd..ed3c2c787 100644
--- a/customize.dist/translations/messages.fr.js
+++ b/customize.dist/translations/messages.fr.js
@@ -220,7 +220,7 @@ define(function () {
                              "Quiconque se trouve en possession de celle-ci peut modifier ou supprimer tous les fichiers de ce gestionnaire.<br>" +
                              '<input type="text" id="fm_backupUrl" value="{0}"/>';
     out.fm_backup_title = 'URL de secours';
-
+    out.fm_nameFile = 'Comment souhaitez-vous nommer ce fichier ?';
     // File - Context menu
     out.fc_newfolder = "Nouveau dossier";
     out.fc_rename = "Renommer";
diff --git a/customize.dist/translations/messages.js b/customize.dist/translations/messages.js
index 1f81836dc..ac3d235b6 100644
--- a/customize.dist/translations/messages.js
+++ b/customize.dist/translations/messages.js
@@ -217,6 +217,7 @@ define(function () {
                              "Anybody with that URL can edit or remove all the files in your file manager.<br>" +
                              '<input type="text" id="fm_backupUrl" value="{0}"/>';
     out.fm_backup_title = 'Backup URL';
+    out.fm_nameFile = 'How would you like to name that file?';
     // File - Context menu
     out.fc_newfolder = "New folder";
     out.fc_rename = "Rename";
diff --git a/www/drive/inner.html b/www/drive/inner.html
index 421443c4e..ed34f4f1a 100644
--- a/www/drive/inner.html
+++ b/www/drive/inner.html
@@ -29,10 +29,10 @@
         <div id="contentContextMenu" class="contextMenu dropdown clearfix" oncontextmenu="return false;">
             <ul class="dropdown-menu" role="menu" aria-labelledby="dropdownMenu" style="display:block;position:static;margin-bottom:5px;">
                 <li><a tabindex="-1" href="#" class="newfolder editable dropdown-item" data-localization="fc_newfolder">New folder</a></li>
-                <li><a tabindex="-1" href="#" class="newdoc own editable dropdown-item" data-type="pad" data-localization="fc_newpad" target="_blank">New pad</a></li>
-                <li><a tabindex="-1" href="#" class="newdoc own editable dropdown-item" data-type="code" data-localization="fc_newcode" target="_blank">New code</a></li>
-                <li><a tabindex="-1" href="#" class="newdoc own editable dropdown-item" data-type="slide" data-localization="fc_newslide" target="_blank">New slide</a></li>
-                <li><a tabindex="-1" href="#" class="newdoc own editable dropdown-item" data-type="poll" data-localization="fc_newpoll" target="_blank">New poll</a></li>
+                <li><a tabindex="-1" href="#" class="newdoc own editable dropdown-item" data-type="pad" data-localization="fc_newpad">New pad</a></li>
+                <li><a tabindex="-1" href="#" class="newdoc own editable dropdown-item" data-type="code" data-localization="fc_newcode">New code</a></li>
+                <li><a tabindex="-1" href="#" class="newdoc own editable dropdown-item" data-type="slide" data-localization="fc_newslide">New slide</a></li>
+                <li><a tabindex="-1" href="#" class="newdoc own editable dropdown-item" data-type="poll" data-localization="fc_newpoll">New poll</a></li>
             </ul>
         </div>
         <div id="defaultContextMenu" class="contextMenu dropdown clearfix" oncontextmenu="return false;">
diff --git a/www/drive/main.js b/www/drive/main.js
index 13a8c5b66..aa823c968 100644
--- a/www/drive/main.js
+++ b/www/drive/main.js
@@ -855,6 +855,18 @@ define([
             return $block;
         };
 
+        var createPadFromRootHandler = function (e) {
+            var type = $(this).data('type');
+            if (!type) {
+                throw new Error("Unable to get the pad type...");
+            }
+            var onNamed = function (name) {
+                if (!name) { return; }
+                var path = '/#?name=' + encodeURIComponent(name) + '&path=' + encodeURIComponent(currentPath);
+                window.open('/' + type + path);
+            };
+            Cryptpad.prompt(Messages.fm_nameFile, Cryptpad.getDefaultName({type: type}), onNamed);
+        };
         var createNewButton = function (isInRoot) {
             if (!APP.editable) { return; }
 
@@ -904,18 +916,7 @@ define([
                     };
                     filesOp.createNewFolder(currentPath, null, onCreated);
                 });
-                $block.find('a.newdoc').click(function () {
-                    var type = $(this).data('type');
-                    if (!type) {
-                        throw new Error("Unable to get the pad type...");
-                    }
-                    var onNamed = function (name) {
-                        var path = '/#?name=' + encodeURIComponent(name) + '&path=' + encodeURIComponent(currentPath);
-                        console.log(path);
-                        window.open('/' + type + path);
-                    };
-                    Cryptpad.prompt("How would you like to name your file?", Cryptpad.getDefaultName({type: type}), onNamed);
-                });
+                $block.find('a.newdoc').click(createPadFromRootHandler);
             }
 
             return $block;
@@ -1587,7 +1588,8 @@ define([
             }
             else if ($(this).hasClass("newdoc")) {
                 var type = $(this).data('type') || 'pad';
-                $(this).attr('href','/' + type + '/#?path=' + encodeURIComponent(path));
+                createPadFromRootHandler.apply(this);
+                e.preventDefault();
             }
             module.hideMenu();
         });
@@ -1853,7 +1855,6 @@ define([
                 $backupButton.attr('title', Messages.fm_backup_title);
                 $backupButton.on('click', function() {
                     var url = window.location.origin + window.location.pathname + '#' + editHash;
-                    //TODO change text & transalte
                     Cryptpad.alert(Messages._getKey('fm_alert_backupUrl', [url]));
                     $('#fm_backupUrl').val(url);
                     $('#fm_backupUrl').click(function () {

From 65054119cf631db0cefc4de6a16726ad4e36312d Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Wed, 1 Feb 2017 17:21:54 +0100
Subject: [PATCH 2/4] Fix a bug preventing reconnection in drive

---
 www/common/toolbar.js |  4 ++--
 www/drive/file.css    |  3 +++
 www/drive/file.less   |  4 ++++
 www/drive/main.js     | 34 +++++++++++++++++++++-------------
 4 files changed, 30 insertions(+), 15 deletions(-)

diff --git a/www/common/toolbar.js b/www/common/toolbar.js
index 810646e24..055e60fb6 100644
--- a/www/common/toolbar.js
+++ b/www/common/toolbar.js
@@ -270,11 +270,11 @@ define([
             'class': 'lag'
         });
         var title;
-        if (typeof lag !== "undefined") {
+        if (lag) {
             lagErrors = 0;
             firstConnection = false;
             title = Messages.lag + ' : ' + lag + ' ms\n';
-            if (lag.waiting || lag > 1000) {
+            if (lag && lag.waiting || lag > 1000) {
                 lagLight.addClass('lag-orange');
                 title += Messages.orangeLight;
             } else {
diff --git a/www/drive/file.css b/www/drive/file.css
index f406bf4c7..4ac44552f 100644
--- a/www/drive/file.css
+++ b/www/drive/file.css
@@ -180,6 +180,9 @@ span.fa-folder-open {
   display: flex;
   flex-flow: column;
 }
+#content.readonly {
+  background: #e6e6e6;
+}
 #content h1 {
   padding-left: 10px;
   margin-top: 10px;
diff --git a/www/drive/file.less b/www/drive/file.less
index 20b7175ca..fd18f54f3 100644
--- a/www/drive/file.less
+++ b/www/drive/file.less
@@ -3,6 +3,7 @@
 @tree-lines-col: #888;
 
 @content-bg: @tree-bg;
+@content-bg-ro: darken(@content-bg, 10%);
 @content-fg: @tree-fg;
 @info-box-bg: #ddddff;
 @info-box-border: #bbb;
@@ -219,6 +220,9 @@ span {
     flex: 1;
     display: flex;
     flex-flow: column;
+    &.readonly {
+        background: @content-bg-ro;
+    }
     h1 {
         padding-left: 10px;
         margin-top: 10px;
diff --git a/www/drive/main.js b/www/drive/main.js
index aa823c968..a6a440354 100644
--- a/www/drive/main.js
+++ b/www/drive/main.js
@@ -18,6 +18,15 @@ define([
     var $iframe = $('#pad-iframe').contents();
     var ifrw = $('#pad-iframe')[0].contentWindow;
 
+    var $tree = $iframe.find("#tree");
+    var $content = $iframe.find("#content");
+    var $driveToolbar = $iframe.find("#driveToolbar");
+    var $contextMenu = $iframe.find("#treeContextMenu");
+    var $contentContextMenu = $iframe.find("#contentContextMenu");
+    var $defaultContextMenu = $iframe.find("#defaultContextMenu");
+    var $trashTreeContextMenu = $iframe.find("#trashTreeContextMenu");
+    var $trashContextMenu = $iframe.find("#trashContextMenu");
+
     Cryptpad.addLoadingScreen();
     var onConnectError = function (info) {
         Cryptpad.errorLoadingScreen(Messages.websocketError);
@@ -127,8 +136,14 @@ define([
 
     var setEditable = function (state) {
         APP.editable = state;
-        if (!state) { $iframe.find('[draggable="true"]').attr('draggable', false); }
-        else { $iframe.find('[draggable="false"]').attr('draggable', true); }
+        if (!state) {
+            $content.addClass('readonly');
+            $iframe.find('[draggable="true"]').attr('draggable', false);
+        }
+        else {
+            $content.removeClass('readonly');
+            $iframe.find('[draggable="false"]').attr('draggable', true);
+        }
     };
 
     // Icons
@@ -196,16 +211,6 @@ define([
         var lastSelectTime;
         var selectedElement;
 
-        var $tree = $iframe.find("#tree");
-        var $content = $iframe.find("#content");
-        var $driveToolbar = $iframe.find("#driveToolbar");
-        var $contextMenu = $iframe.find("#treeContextMenu");
-        var $contentContextMenu = $iframe.find("#contentContextMenu");
-        var $defaultContextMenu = $iframe.find("#defaultContextMenu");
-        var $trashTreeContextMenu = $iframe.find("#trashTreeContextMenu");
-        var $trashContextMenu = $iframe.find("#trashContextMenu");
-
-
         if (!APP.readOnly) {
             setEditable(true);
         }
@@ -1288,7 +1293,10 @@ define([
 
             var $modeButton = createViewModeButton().appendTo($toolbar.find('.rightside'));
             var $title = createTitle(path).appendTo($toolbar.find('.rightside'));
-            createNewButton(isInRoot).appendTo($toolbar.find('.leftside'));
+
+            // NewButton can be undefined if we're in read only mode
+            $toolbar.find('.leftside').append(createNewButton(isInRoot));
+
 
             var $folderHeader = getFolderListHeader();
             var $fileHeader = getFileListHeader(true);

From 8881334ca8a04298e802214f5a3d74f3331c9456 Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Wed, 1 Feb 2017 17:38:16 +0100
Subject: [PATCH 3/4] Fix renaming folders from the tree

---
 www/drive/main.js | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/www/drive/main.js b/www/drive/main.js
index a6a440354..0ab2ab9bd 100644
--- a/www/drive/main.js
+++ b/www/drive/main.js
@@ -286,6 +286,9 @@ define([
             removeInput();
             removeSelected();
             var $name = $element.find('.name');
+            if (!$name.length) {
+                $name = $element.find('.element');
+            }
             $name.hide();
             var name = path[path.length - 1];
             var $input = $('<input>', {

From 6a5769405b6e431c25e7dd7ef3d0d801cb14931e Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Wed, 1 Feb 2017 18:48:30 +0100
Subject: [PATCH 4/4] Fix a race condition issue introduced with reconnecting
 patch

---
 www/drive/main.js | 23 +++++++++++++----------
 1 file changed, 13 insertions(+), 10 deletions(-)

diff --git a/www/drive/main.js b/www/drive/main.js
index 0ab2ab9bd..49f1a32fe 100644
--- a/www/drive/main.js
+++ b/www/drive/main.js
@@ -18,14 +18,8 @@ define([
     var $iframe = $('#pad-iframe').contents();
     var ifrw = $('#pad-iframe')[0].contentWindow;
 
-    var $tree = $iframe.find("#tree");
-    var $content = $iframe.find("#content");
-    var $driveToolbar = $iframe.find("#driveToolbar");
-    var $contextMenu = $iframe.find("#treeContextMenu");
-    var $contentContextMenu = $iframe.find("#contentContextMenu");
-    var $defaultContextMenu = $iframe.find("#defaultContextMenu");
-    var $trashTreeContextMenu = $iframe.find("#trashTreeContextMenu");
-    var $trashContextMenu = $iframe.find("#trashContextMenu");
+
+
 
     Cryptpad.addLoadingScreen();
     var onConnectError = function (info) {
@@ -137,11 +131,11 @@ define([
     var setEditable = function (state) {
         APP.editable = state;
         if (!state) {
-            $content.addClass('readonly');
+            $iframe.find('#content').addClass('readonly');
             $iframe.find('[draggable="true"]').attr('draggable', false);
         }
         else {
-            $content.removeClass('readonly');
+            $iframe.find('#content').removeClass('readonly');
             $iframe.find('[draggable="false"]').attr('draggable', true);
         }
     };
@@ -185,6 +179,15 @@ define([
 
         var error = filesOp.error;
 
+        var $tree = $iframe.find("#tree");
+        var $content = $iframe.find("#content");
+        var $driveToolbar = $iframe.find("#driveToolbar");
+        var $contextMenu = $iframe.find("#treeContextMenu");
+        var $contentContextMenu = $iframe.find("#contentContextMenu");
+        var $defaultContextMenu = $iframe.find("#defaultContextMenu");
+        var $trashTreeContextMenu = $iframe.find("#trashTreeContextMenu");
+        var $trashContextMenu = $iframe.find("#trashContextMenu");
+
         // TOOLBAR
 
         var getLastName = function (cb) {