From 0d912402e5e81c5ad0887f6a93f843ec33c58c83 Mon Sep 17 00:00:00 2001
From: ansuz <ansuz@transitiontech.ca>
Date: Thu, 12 Oct 2017 14:09:48 +0200
Subject: [PATCH 1/8] patch for bug in Firefox ESR

---
 www/slide/app-slide.less | 1 +
 1 file changed, 1 insertion(+)

diff --git a/www/slide/app-slide.less b/www/slide/app-slide.less
index f6ebf8cf0..c6ce3addf 100644
--- a/www/slide/app-slide.less
+++ b/www/slide/app-slide.less
@@ -281,6 +281,7 @@ div#cp-app-slide-modal #cp-app-slide-modal-content, #cp-app-slide-print {
             & + * {
                 margin-top: 1rem;
             }
+            img { margin: unset; }
         }
 
         img {

From 69dd3a60ab24d4ac91cfe9bba5eaea8e4f79b94f Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Thu, 12 Oct 2017 14:32:12 +0200
Subject: [PATCH 2/8] Hide template and fileupload buttons for anonymous users

---
 www/common/sframe-common-interface.js | 1 +
 www/filepicker/inner.js               | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/www/common/sframe-common-interface.js b/www/common/sframe-common-interface.js
index 52d95b040..97fcc9fb6 100644
--- a/www/common/sframe-common-interface.js
+++ b/www/common/sframe-common-interface.js
@@ -98,6 +98,7 @@ define([
                 break;
             case 'template':
                 if (!AppConfig.enableTemplates) { return; }
+                if (!common.isLoggedIn()) { return; }
                 button = $('<button>', {
                     title: Messages.saveTemplateButton,
                 }).append($('<span>', {'class':'fa fa-bookmark', style: 'font:'+size+' FontAwesome'}));
diff --git a/www/filepicker/inner.js b/www/filepicker/inner.js
index 62b798f8d..29b6e4f3f 100644
--- a/www/filepicker/inner.js
+++ b/www/filepicker/inner.js
@@ -109,7 +109,7 @@ define([
             });
 
             //If file, display the upload button
-            if (types.indexOf('file') !== -1) {
+            if (types.indexOf('file') !== -1 && common.isLoggedIn()) {
                 $filter.append(common.createButton('upload', false, data));
             }
 

From 62bc72847fec095729bf692a28cba10f36ebdf0a Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Thu, 12 Oct 2017 15:06:29 +0200
Subject: [PATCH 3/8] Add an error message when trying to tag a deleted pad

---
 customize.dist/translations/messages.fr.js |  1 +
 customize.dist/translations/messages.js    |  2 +-
 www/common/sframe-common-interface.js      |  7 ++++++-
 www/common/userObject.js                   | 11 -----------
 4 files changed, 8 insertions(+), 13 deletions(-)

diff --git a/customize.dist/translations/messages.fr.js b/customize.dist/translations/messages.fr.js
index 0dedf52ef..3b88a26ab 100644
--- a/customize.dist/translations/messages.fr.js
+++ b/customize.dist/translations/messages.fr.js
@@ -162,6 +162,7 @@ define(function () {
     out.tags_searchHint = "Commencez une recherche par # dans votre CryptDrive pour retrouver vos pads par mot-clé.";
     out.tags_notShared = "Vos mots-clés ne sont pas partagés avec les autres utilisateurs.";
     out.tags_duplicate = "Mot-clé déjà présent : {0}";
+    out.tags_noentry = "Vous ne pouvez pas ajouter de mots-clés à un pad supprimé!";
 
     out.slideOptionsText = "Options";
     out.slideOptionsTitle = "Personnaliser la présentation";
diff --git a/customize.dist/translations/messages.js b/customize.dist/translations/messages.js
index a3e254fbe..ba55838a9 100644
--- a/customize.dist/translations/messages.js
+++ b/customize.dist/translations/messages.js
@@ -164,8 +164,8 @@ define(function () {
     out.tags_searchHint = "Find files by their tags by searching in your CryptDrive";
     out.tags_searchHint = "Start a search with # in your CryptDrive to find your tagged pads.";
     out.tags_notShared = "Your tags are not shared with other users";
-
     out.tags_duplicate = "Duplicate tag: {0}";
+    out.tags_noentry = "You can't tag a deleted pad!";
 
     out.slideOptionsText = "Options";
     out.slideOptionsTitle = "Customize your slides";
diff --git a/www/common/sframe-common-interface.js b/www/common/sframe-common-interface.js
index 97fcc9fb6..422b76bfe 100644
--- a/www/common/sframe-common-interface.js
+++ b/www/common/sframe-common-interface.js
@@ -31,7 +31,12 @@ define([
     UI.updateTags = function (common, href) {
         var sframeChan = common.getSframeChannel();
         sframeChan.query('Q_TAGS_GET', href || null, function (err, res) {
-            if (err || res.error) { return void console.error(err || res.error); }
+            if (err || res.error) {
+                if (res.error === 'NO_ENTRY') {
+                    Cryptpad.alert(Messages.tags_noentry);
+                }
+                return void console.error(err || res.error);
+            }
             Cryptpad.dialog.tagPrompt(res.data, function (tags) {
                 if (!Array.isArray(tags)) { return; }
                 sframeChan.event('EV_TAGS_SET', {
diff --git a/www/common/userObject.js b/www/common/userObject.js
index 8a3662a7b..658a0243c 100644
--- a/www/common/userObject.js
+++ b/www/common/userObject.js
@@ -499,7 +499,6 @@ define([
             });
         };
         var spliceFileData = exp.removeData = function (id) {
-            files[FILES_DATA][id] = undefined;
             delete files[FILES_DATA][id];
         };
 
@@ -649,7 +648,6 @@ define([
                 var hash = f.indexOf('#') !== -1 ? f.slice(f.indexOf('#') + 1) : null;
                 if (hash && key.indexOf(hash) === 0) {
                     debug("Deleting pad attribute in the realtime object");
-                    files[key] = undefined;
                     delete files[key];
                 }
             });
@@ -709,7 +707,6 @@ define([
                 var parentPath = path.slice();
                 var key = parentPath.pop();
                 var parentEl = find(parentPath);
-                parentEl[key] = undefined;
                 delete parentEl[key];
             });
 
@@ -728,7 +725,6 @@ define([
                     return;
                 }
                 // Trash but not root: it's just a tree so remove the key
-                parentEl[key] = undefined;
                 delete parentEl[key];
             });
             deleteMultipleTrashRoot(trashRoot);
@@ -767,7 +763,6 @@ define([
                     return;
                 }
                 parentEl[newName] = element;
-                parentEl[oldName] = undefined;
                 delete parentEl[oldName];
                 if (typeof cb === "function") { cb(); }
                 return;
@@ -777,7 +772,6 @@ define([
             var data = files[FILES_DATA][element];
             if (!data) { return; }
             if (!newName || newName.trim() === "") {
-                data.filename = undefined;
                 delete data.filename;
                 if (typeof cb === "function") { cb(); }
                 return;
@@ -899,9 +893,7 @@ define([
                                 delete parent[okey];
                             });
                         });
-                        files[OLD_FILES_DATA] = undefined;
                         delete files[OLD_FILES_DATA];
-                        files.migrate = undefined;
                         delete files.migrate;
                         console.log('done');
                         todo();
@@ -942,7 +934,6 @@ define([
                 for (var el in element) {
                     if (!isFile(element[el], true) && !isFolder(element[el])) {
                         debug("An element in ROOT was not a folder nor a file. ", element[el]);
-                        element[el] = undefined;
                         delete element[el];
                         continue;
                     }
@@ -994,11 +985,9 @@ define([
                 for (var el in tr) {
                     if (!Array.isArray(tr[el])) {
                         debug("An element in TRASH root is not an array. ", tr[el]);
-                        tr[el] = undefined;
                         delete tr[el];
                     } else if (tr[el].length === 0) {
                         debug("Empty array in TRASH root. ", tr[el]);
-                        tr[el] = undefined;
                         delete tr[el];
                     } else {
                         toClean = [];

From 5ed60a0ad773b53e096ae2356bc42d8dcd8a0ee9 Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Thu, 12 Oct 2017 16:45:43 +0200
Subject: [PATCH 4/8] Fix image ratio in slides

---
 www/slide/app-slide.less | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/www/slide/app-slide.less b/www/slide/app-slide.less
index c6ce3addf..459e75b68 100644
--- a/www/slide/app-slide.less
+++ b/www/slide/app-slide.less
@@ -277,11 +277,13 @@ div#cp-app-slide-modal #cp-app-slide-modal-content, #cp-app-slide-print {
         // fixes image overflowing
         media-tag {
             height: 100%;
+            flex-flow: row;
+            justify-content: center;
 
             & + * {
                 margin-top: 1rem;
             }
-            img { margin: unset; }
+            img { flex: unset; }
         }
 
         img {

From b86f8e3f267f9ea001185d21c24486c7a242fd34 Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Thu, 12 Oct 2017 17:33:22 +0200
Subject: [PATCH 5/8] Fix uloaded files not moved to the correct folder in
 drive

---
 www/common/common-file.js        |  4 ++++
 www/common/sframe-common-file.js |  1 -
 www/drive/inner.js               | 28 ++++++++--------------------
 3 files changed, 12 insertions(+), 21 deletions(-)

diff --git a/www/common/common-file.js b/www/common/common-file.js
index 6b1f33505..97705e556 100644
--- a/www/common/common-file.js
+++ b/www/common/common-file.js
@@ -28,6 +28,9 @@ define([
         var u8 = file.blob; // This is not a blob but a uint8array
         var metadata = file.metadata;
 
+        // if it exists, dropEvent contains the new pad location in the drive
+        var dropEvent = file.dropEvent;
+
         var key = Nacl.randomBytes(32);
         var next = FileCrypto.encrypt(u8, metadata, key);
 
@@ -73,6 +76,7 @@ define([
 
                 if (noStore) { return void onComplete(href); }
 
+                common.initialPath = dropEvent && dropEvent.path;
                 common.renamePad(title || "", href, function (err) {
                     if (err) { return void console.error(err); }
                     onComplete(href);
diff --git a/www/common/sframe-common-file.js b/www/common/sframe-common-file.js
index a2abd006a..b4e167690 100644
--- a/www/common/sframe-common-file.js
+++ b/www/common/sframe-common-file.js
@@ -93,7 +93,6 @@ define([
             var metadata = file.metadata;
             var id = file.id;
             var dropEvent = file.dropEvent;
-            delete file.dropEvent;
             if (queue.inProgress) { return; }
             queue.inProgress = true;
 
diff --git a/www/drive/inner.js b/www/drive/inner.js
index 617a706ac..689627454 100644
--- a/www/drive/inner.js
+++ b/www/drive/inner.js
@@ -1038,7 +1038,11 @@ define([
         };
 
         var onFileDrop = APP.onFileDrop = function (file, e) {
-            APP.FM.onFileDrop(file, e);
+            var ev = {
+                target: e.target,
+                path: findDropPath(e.target)
+            };
+            APP.FM.onFileDrop(file, ev);
         };
         var findDropPath = function (target) {
             var $target = $(target);
@@ -1474,7 +1478,8 @@ define([
                     }).on('change', function (e) {
                         var file = e.target.files[0];
                         var ev = {
-                            target: $content[0]
+                            target: $content[0],
+                            path: findDropPath($content[0])
                         };
                         APP.FM.handleFile(file, ev);
                     });
@@ -2847,24 +2852,7 @@ define([
         var fmConfig = {
             noHandlers: true,
             onUploaded: function (ev, data) {
-                try {
-                    // Get the folder path
-                    console.log(ev.target);
-                    console.log(data);
-                    var newPath = findDropPath(ev.target);
-                    if (!newPath) { return void refresh(); }
-                    var href = data.url;
-                    // Get the current file location in ROOT
-                    var id = filesOp.getIdFromHref(href);
-                    var paths = filesOp.findFile(id);
-                    if (paths.length !== 1) { return; }
-                    // Try to move and refresh
-                    moveElements([paths[0]], newPath, true);
-                    refresh();
-                } catch (e) {
-                    console.error(e);
-                    refresh();
-                }
+                refresh();
             },
             body: $('body')
         };

From 1c8e1a36e8e6859057e3c72529bf3cf6195cd93a Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Thu, 12 Oct 2017 17:43:49 +0200
Subject: [PATCH 6/8] Add file type in the pad attributes for existing files

---
 www/common/sframe-common.js | 1 +
 www/file/inner.js           | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/www/common/sframe-common.js b/www/common/sframe-common.js
index 35865cdd8..507c8d323 100644
--- a/www/common/sframe-common.js
+++ b/www/common/sframe-common.js
@@ -190,6 +190,7 @@ define([
         });
     };
     funcs.setPadAttribute = function (key, value, cb) {
+        cb = cb || $.noop;
         ctx.sframeChan.query('Q_SET_PAD_ATTRIBUTE', {
             key: key,
             value: value
diff --git a/www/file/inner.js b/www/file/inner.js
index df5ba854f..b4860355c 100644
--- a/www/file/inner.js
+++ b/www/file/inner.js
@@ -94,6 +94,8 @@ define([
                 Title.updateTitle(title || Title.defaultTitle);
                 toolbar.addElement(['pageTitle'], {pageTitle: title});
 
+                common.setPadAttribute('fileType', metadata.type);
+
                 var displayFile = function (ev, sizeMb, CB) {
                     var called_back;
                     var cb = function (e) {

From 6926d42292037ad6728a39209c8a5fbc4d9c8172 Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Thu, 12 Oct 2017 18:18:01 +0200
Subject: [PATCH 7/8] Autoload template picker to make it faster to appear when
 used

---
 www/common/sframe-common-interface.js | 13 ++++++++-----
 www/common/sframe-common-outer.js     | 26 +++++++++++++++-----------
 2 files changed, 23 insertions(+), 16 deletions(-)

diff --git a/www/common/sframe-common-interface.js b/www/common/sframe-common-interface.js
index 422b76bfe..884f1b65c 100644
--- a/www/common/sframe-common-interface.js
+++ b/www/common/sframe-common-interface.js
@@ -587,11 +587,18 @@ define([
         var sframeChan = common.getSframeChannel();
         var focus;
 
+        var pickerCfg = {
+            types: [type],
+            where: ['template'],
+            hidden: true
+        };
         var onConfirm = function (yes) {
             if (!yes) {
                 if (focus) { focus.focus(); }
                 return;
             }
+            delete pickerCfg.hidden;
+            common.openFilePicker(pickerCfg);
             var first = true; // We can only pick a template once (for a new document)
             var fileDialogCfg = {
                 onSelect: function (data) {
@@ -608,15 +615,11 @@ define([
                 }
             };
             common.initFilePicker(fileDialogCfg);
-            var pickerCfg = {
-                types: [type],
-                where: ['template']
-            };
-            common.openFilePicker(pickerCfg);
         };
 
         sframeChan.query("Q_TEMPLATE_EXIST", type, function (err, data) {
             if (data) {
+                common.openFilePicker(pickerCfg);
                 focus = document.activeElement;
                 Cryptpad.confirm(Messages.useTemplate, onConfirm, {
                     ok: Messages.useTemplateOK,
diff --git a/www/common/sframe-common-outer.js b/www/common/sframe-common-outer.js
index 46534fe9d..2daa275f7 100644
--- a/www/common/sframe-common-outer.js
+++ b/www/common/sframe-common-outer.js
@@ -362,22 +362,26 @@ define([
 
             // File picker
             var FP = {};
-            var initFilePicker = function (types) {
-                var config = {};
-                config.onFilePicked = function (data) {
-                    sframeChan.event('EV_FILE_PICKED', data);
-                };
-                config.onClose = function () {
-                    FP.$iframe.hide();
-                };
-                config.onFileUpload = onFileUpload;
-                config.types = types;
+            var initFilePicker = function (cfg) {
                 if (!FP.$iframe) {
+                    var config = {};
+                    config.onFilePicked = function (data) {
+                        sframeChan.event('EV_FILE_PICKED', data);
+                    };
+                    config.onClose = function () {
+                        FP.$iframe.hide();
+                    };
+                    config.onFileUpload = onFileUpload;
+                    config.types = cfg;
                     FP.$iframe = $('<iframe>', {id: 'sbox-filePicker-iframe'}).appendTo($('body'));
                     FP.picker = FilePicker.create(config);
                 } else {
                     FP.$iframe.show();
-                    FP.picker.refresh(types);
+                    FP.picker.refresh(cfg);
+                }
+                if (cfg.hidden) {
+                    FP.$iframe.hide();
+                    return;
                 }
                 FP.$iframe.focus();
             };

From 7b6432f1346c35781d059fe2da44e8e717eafc1b Mon Sep 17 00:00:00 2001
From: yflory <yann.flory@xwiki.com>
Date: Thu, 12 Oct 2017 18:20:33 +0200
Subject: [PATCH 8/8] Lint

---
 www/drive/inner.js | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/www/drive/inner.js b/www/drive/inner.js
index 689627454..3f5320377 100644
--- a/www/drive/inner.js
+++ b/www/drive/inner.js
@@ -1037,13 +1037,6 @@ define([
             ev.dataTransfer.setData("text", stringify(data));
         };
 
-        var onFileDrop = APP.onFileDrop = function (file, e) {
-            var ev = {
-                target: e.target,
-                path: findDropPath(e.target)
-            };
-            APP.FM.onFileDrop(file, ev);
-        };
         var findDropPath = function (target) {
             var $target = $(target);
             var $el = findDataHolder($target);
@@ -1054,6 +1047,13 @@ define([
             }
             return newPath;
         };
+        var onFileDrop = APP.onFileDrop = function (file, e) {
+            var ev = {
+                target: e.target,
+                path: findDropPath(e.target)
+            };
+            APP.FM.onFileDrop(file, ev);
+        };
         var onDrop = function (ev) {
             ev.preventDefault();
             $('.cp-app-drive-element-droppable').removeClass('cp-app-drive-element-droppable');
@@ -2851,7 +2851,7 @@ define([
 
         var fmConfig = {
             noHandlers: true,
-            onUploaded: function (ev, data) {
+            onUploaded: function () {
                 refresh();
             },
             body: $('body')