From 17b4f918100c2242be8b351e725749ffd2b997cf Mon Sep 17 00:00:00 2001 From: yflory Date: Mon, 3 Oct 2016 16:05:39 +0200 Subject: [PATCH 1/2] Do not share the title in the doc if it is the default title --- www/code/main.js | 74 ++++++++++++++++++--------------- www/common/cryptpad-common.js | 4 ++ www/pad/main.js | 74 +++++++++++++++++---------------- www/slide/main.js | 77 +++++++++++++++++++---------------- 4 files changed, 127 insertions(+), 102 deletions(-) diff --git a/www/code/main.js b/www/code/main.js index 71f3bfd14..ae8d783e0 100644 --- a/www/code/main.js +++ b/www/code/main.js @@ -158,9 +158,11 @@ define([ // append the userlist to the hyperjson structure obj.metadata = { - users: userList, - title: document.title + users: userList }; + if (!isDefaultTitle()) { + obj.metadata.title = document.title; + } // set mode too... obj.highlightMode = module.highlightMode; @@ -239,11 +241,15 @@ define([ return text.trim(); }; + var isDefaultTitle = function () { + var parsed = Cryptpad.parsePadUrl(window.location.href); + return Cryptpad.isDefaultName(parsed, document.title); + }; var suggestName = function () { var parsed = Cryptpad.parsePadUrl(window.location.href); var name = Cryptpad.getDefaultName(parsed, []); - if (document.title.slice(0, name.length) === name) { + if (Cryptpad.isDefaultName(parsed, document.title)) { return getHeadingText() || document.title; } else { return document.title || getHeadingText() || name; @@ -328,42 +334,42 @@ define([ onLocal(); })); $rightside.append($import); - } - /* add a rename button */ - var $setTitle = Cryptpad.createButton('rename', true) - .click(function () { - var suggestion = suggestName(); - - Cryptpad.prompt(Messages.renamePrompt, - suggestion, function (title, ev) { - if (title === null) { return; } - - Cryptpad.causesNamingConflict(title, function (err, conflicts) { - if (err) { - console.log("Unable to determine if name caused a conflict"); - console.error(err); - return; - } + /* add a rename button */ + var $setTitle = Cryptpad.createButton('rename', true) + .click(function () { + var suggestion = suggestName(); - if (conflicts) { - Cryptpad.alert(Messages.renameConflict); - return; - } + Cryptpad.prompt(Messages.renamePrompt, + suggestion, function (title, ev) { + if (title === null) { return; } - Cryptpad.setPadTitle(title, function (err, data) { + Cryptpad.causesNamingConflict(title, function (err, conflicts) { if (err) { - console.log("unable to set pad title"); - console.log(err); + console.log("Unable to determine if name caused a conflict"); + console.error(err); return; } - document.title = title; - onLocal(); + + if (conflicts) { + Cryptpad.alert(Messages.renameConflict); + return; + } + + Cryptpad.setPadTitle(title, function (err, data) { + if (err) { + console.log("unable to set pad title"); + console.log(err); + return; + } + document.title = title; + onLocal(); + }); }); }); - }); - }); - $rightside.append($setTitle); + }); + $rightside.append($setTitle); + } /* add a forget button */ var $forgetPad = Cryptpad.createButton('forget', true) @@ -657,11 +663,13 @@ define([ var hjson2 = { content: localDoc, metadata: { - users: userList, - title: document.title + users: userList }, highlightMode: highlightMode, }; + if (!isDefaultTitle()) { + hjson2.metadata.title = document.title; + } var shjson2 = stringify(hjson2); if (shjson2 !== shjson) { console.error("shjson2 !== shjson"); diff --git a/www/common/cryptpad-common.js b/www/common/cryptpad-common.js index 68fa9be7a..7387808fa 100644 --- a/www/common/cryptpad-common.js +++ b/www/common/cryptpad-common.js @@ -295,6 +295,10 @@ define([ while (!isNameAvailable(name + ' - ' + untitledIndex, parsed, recentPads)) { untitledIndex++; } return name + ' - ' + untitledIndex; }; + var isDefaultName = common.isDefaultName = function (parsed, title) { + var name = getDefaultName(parsed, []); + return title.slice(0, name.length) === name; + }; var makePad = function (href, title) { var now = ''+new Date(); diff --git a/www/pad/main.js b/www/pad/main.js index 18274079f..9fb92992e 100644 --- a/www/pad/main.js +++ b/www/pad/main.js @@ -294,6 +294,21 @@ define([ }); }; + var isDefaultTitle = function () { + var parsed = Cryptpad.parsePadUrl(window.location.href); + return Cryptpad.isDefaultName(parsed, document.title); + }; + var suggestName = function () { + var parsed = Cryptpad.parsePadUrl(window.location.href); + var name = Cryptpad.getDefaultName(parsed, []); + + if (Cryptpad.isDefaultName(parsed, document.title)) { + return getHeadingText() || document.title; + } else { + return document.title || getHeadingText() || name; + } + }; + var DD = new DiffDom(diffOptions); // apply patches, and try not to lose the cursor in the process! @@ -312,9 +327,11 @@ define([ hjson[3] = { metadata: { users: userList, - title: document.title } }; + if (!isDefaultTitle()) { + hjson[3].metadata.title = document.title; + } return stringify(hjson); }; @@ -472,17 +489,6 @@ define([ })) { return text; } }; - var suggestName = module.suggestName = function () { - var parsed = Cryptpad.parsePadUrl(window.location.href); - var name = Cryptpad.getDefaultName(parsed, []); - - if (document.title.slice(0, name.length) === name) { - return getHeadingText() || document.title; - } else { - return document.title || getHeadingText() || name; - } - }; - var exportFile = function () { var html = getHTML(); var suggestion = suggestName(); @@ -536,34 +542,34 @@ define([ realtimeOptions.onLocal(); })); $rightside.append($import); - } - /* add a rename button */ - var $rename = Cryptpad.createButton('rename', true) - .click(function () { - var suggestion = suggestName(); - - Cryptpad.prompt(Messages.renamePrompt, suggestion, function (title) { - if (title === null) { return; } - Cryptpad.causesNamingConflict(title, function (err, conflicts) { - if (conflicts) { - Cryptpad.alert(Messages.renameConflict); - return; - } - - Cryptpad.setPadTitle(title, function (err, data) { - if (err) { - console.log("Couldn't set pad title"); - console.error(err); + /* add a rename button */ + var $rename = Cryptpad.createButton('rename', true) + .click(function () { + var suggestion = suggestName(); + + Cryptpad.prompt(Messages.renamePrompt, suggestion, function (title) { + if (title === null) { return; } + Cryptpad.causesNamingConflict(title, function (err, conflicts) { + if (conflicts) { + Cryptpad.alert(Messages.renameConflict); return; } - document.title = title; - editor.fire('change'); + + Cryptpad.setPadTitle(title, function (err, data) { + if (err) { + console.log("Couldn't set pad title"); + console.error(err); + return; + } + document.title = title; + editor.fire('change'); + }); }); }); }); - }); - $rightside.append($rename); + $rightside.append($rename); + } /* add a forget button */ var $forgetPad = Cryptpad.createButton('forget', true) diff --git a/www/slide/main.js b/www/slide/main.js index c9ff8d6aa..78ca23fb3 100644 --- a/www/slide/main.js +++ b/www/slide/main.js @@ -193,10 +193,11 @@ define([ // append the userlist to the hyperjson structure obj.metadata = { - users: userList, - title: APP.title + users: userList }; - + if (!isDefaultTitle()) { + obj.metadata.title = APP.title; + } // stringify the json and send it into chainpad var shjson = stringify(obj); @@ -254,11 +255,15 @@ define([ return text.trim(); }; + var isDefaultTitle = function () { + var parsed = Cryptpad.parsePadUrl(window.location.href); + return Cryptpad.isDefaultName(parsed, APP.title); + }; var suggestName = function () { var parsed = Cryptpad.parsePadUrl(window.location.href); var name = Cryptpad.getDefaultName(parsed, []); - if (APP.title.slice(0, name.length) === name) { + if (Cryptpad.isDefaultName(parsed, APP.title)) { return getHeadingText() || APP.title; } else { return APP.title || getHeadingText() || name; @@ -343,43 +348,43 @@ define([ onLocal(); })); $rightside.append($import); - } - /* add a rename button */ - var $setTitle = Cryptpad.createButton('rename', true) - .click(function () { - var suggestion = suggestName(); - - Cryptpad.prompt(Messages.renamePrompt, - suggestion, function (title, ev) { - if (title === null) { return; } - - Cryptpad.causesNamingConflict(title, function (err, conflicts) { - if (err) { - console.log("Unable to determine if name caused a conflict"); - console.error(err); - return; - } + /* add a rename button */ + var $setTitle = Cryptpad.createButton('rename', true) + .click(function () { + var suggestion = suggestName(); - if (conflicts) { - Cryptpad.alert(Messages.renameConflict); - return; - } + Cryptpad.prompt(Messages.renamePrompt, + suggestion, function (title, ev) { + if (title === null) { return; } - Cryptpad.setPadTitle(title, function (err, data) { + Cryptpad.causesNamingConflict(title, function (err, conflicts) { if (err) { - console.log("unable to set pad title"); - console.log(err); + console.log("Unable to determine if name caused a conflict"); + console.error(err); return; } - APP.title = title; - setTabTitle(); - onLocal(); + + if (conflicts) { + Cryptpad.alert(Messages.renameConflict); + return; + } + + Cryptpad.setPadTitle(title, function (err, data) { + if (err) { + console.log("unable to set pad title"); + console.log(err); + return; + } + APP.title = title; + setTabTitle(); + onLocal(); + }); }); }); - }); - }); - $rightside.append($setTitle); + }); + $rightside.append($setTitle); + } /* add a forget button */ var $forgetPad = Cryptpad.createButton('forget', true) @@ -684,11 +689,13 @@ define([ var hjson2 = { content: localDoc, metadata: { - users: userList, - title: APP.title + users: userList }, highlightMode: highlightMode, }; + if (!isDefaultTitle()) { + hjson2.metadata.title = APP.title; + } var shjson2 = stringify(hjson2); if (shjson2 !== shjson) { console.error("shjson2 !== shjson"); From 76fdadee7f929ede08270de077c21175935c6a97 Mon Sep 17 00:00:00 2001 From: yflory Date: Mon, 3 Oct 2016 18:23:59 +0200 Subject: [PATCH 2/2] Store only the strongest hash in the localstorage --- www/code/main.js | 2 +- www/common/cryptpad-common.js | 82 +++++++++++++++++------------------ www/pad/main.js | 2 +- www/poll/main.js | 2 +- www/slide/main.js | 2 +- 5 files changed, 44 insertions(+), 46 deletions(-) diff --git a/www/code/main.js b/www/code/main.js index ae8d783e0..fc10fd7c9 100644 --- a/www/code/main.js +++ b/www/code/main.js @@ -476,7 +476,7 @@ define([ return; } document.title = title || info.channel.slice(0, 8); - Cryptpad.rememberPad(title, function (err, data) { + Cryptpad.setPadTitle(title, function (err, data) { if (err) { console.log("Unable to set pad title"); console.error(err); diff --git a/www/common/cryptpad-common.js b/www/common/cryptpad-common.js index 7387808fa..6b7562551 100644 --- a/www/common/cryptpad-common.js +++ b/www/common/cryptpad-common.js @@ -137,6 +137,26 @@ define([ }; + var parseHash = common.parseHash = function (hash) { + var parsed = {}; + if (hash.slice(0,1) !== '/' && hash.length >= 56) { + // Old hash + parsed.channel = hash.slice(0, 32); + parsed.key = hash.slice(32); + parsed.version = 0; + return parsed; + } + var hashArr = hash.split('/'); + if (hashArr[1] && hashArr[1] === '1') { + parsed.version = 1; + parsed.mode = hashArr[2]; + parsed.channel = hashArr[3]; + parsed.key = hashArr[4]; + parsed.present = hashArr[5] && hashArr[5] === 'present'; + return parsed; + } + return; + }; var getEditHashFromKeys = common.getEditHashFromKeys = function (chanKey, keys) { if (typeof keys === 'string') { return chanKey + keys; @@ -401,51 +421,10 @@ define([ }, legacy); }; - // STORAGE - var rememberPad = common.rememberPad = window.rememberPad = function (title, cb) { - // bail out early - if (!/#/.test(window.location.hash)) { return; } - - getRecentPads(function (err, pads) { - if (err) { - cb(err); - return; - } - - var now = ''+new Date(); - var href = window.location.href; - - var parsed = parsePadUrl(window.location.href); - var isUpdate = false; - - var out = pads.map(function (pad) { - var p = parsePadUrl(pad.href); - if (p.hash === parsed.hash && p.type === parsed.type) { - isUpdate = true; - // bump the atime - pad.atime = now; - - pad.title = title; - pad.href = href; - } - return pad; - }); - - if (!isUpdate) { - // href, ctime, atime, title - out.push(makePad(href, title)); - } - setRecentPads(out, function (err, data) { - cb(err, data); - }); - }); - }; - // STORAGE var setPadTitle = common.setPadTitle = function (name, cb) { var href = window.location.href; var parsed = parsePadUrl(href); - getRecentPads(function (err, recent) { if (err) { cb(err); @@ -456,7 +435,26 @@ define([ var renamed = recent.map(function (pad) { var p = parsePadUrl(pad.href); - if (p.hash === parsed.hash && p.type === parsed.type) { + + if (p.type !== parsed.type) { return pad; } + + // Version 1 : we have up to 4 differents hash for 1 pad, keep the strongest : + // Edit > Edit (present) > View > View (present) + var bypass = false; + var pHash = parseHash(p.hash); + var parsedHash = parseHash(parsed.hash); + if (pHash.version === 1 && parsedHash.version === 1 && pHash.channel === parsedHash.channel) { + if (pHash.mode === 'view' && parsedHash.mode === 'edit') { bypass = true; } + else if (pHash.mode === parsedHash.mode && pHash.present) { bypass = true; } + else { + // Editing a "weaker" version of a stored hash : update the date and do not push the current hash + pad.atime = new Date().toISOString(); + contains = true; + return pad; + } + } + + if (p.hash === parsed.hash || bypass) { contains = true; // update the atime pad.atime = new Date().toISOString(); diff --git a/www/pad/main.js b/www/pad/main.js index 9fb92992e..0c28055f6 100644 --- a/www/pad/main.js +++ b/www/pad/main.js @@ -608,7 +608,7 @@ define([ return; } document.title = title || info.channel.slice(0, 8); - Cryptpad.rememberPad(title, function (err, data) { + Cryptpad.setPadTitle(title, function (err, data) { if (err) { console.log("Couldn't remember pad"); console.error(err); diff --git a/www/poll/main.js b/www/poll/main.js index 9b1ab0e68..05c452f5a 100644 --- a/www/poll/main.js +++ b/www/poll/main.js @@ -923,7 +923,7 @@ define([ Cryptpad.getPadTitle(function (err, title) { title = document.title = title || info.channel.slice(0, 8); - Cryptpad.rememberPad(title, function (err, data) { + Cryptpad.setPadTitle(title, function (err, data) { if (err) { console.log("unable to remember pad"); console.log(err); diff --git a/www/slide/main.js b/www/slide/main.js index 78ca23fb3..f0f139a6a 100644 --- a/www/slide/main.js +++ b/www/slide/main.js @@ -490,7 +490,7 @@ define([ return; } document.title = APP.title = title || info.channel.slice(0, 8); - Cryptpad.rememberPad(title, function (err, data) { + Cryptpad.setPadTitle(title, function (err, data) { if (err) { console.log("Unable to set pad title"); console.error(err);